* [PATCH net 1/1] net: stmmac: remove redunctant disable xPCS EEE call
@ 2022-07-15 12:24 Wong Vee Khee
2022-07-19 3:40 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Wong Vee Khee @ 2022-07-15 12:24 UTC (permalink / raw)
To: David S . Miller, Giuseppe Cavallaro, Alexandre Torgue,
Jose Abreu, Jakub Kicinski, Maxime Coquelin, Eric Dumazet,
Paolo Abeni
Cc: netdev, linux-stm32, linux-arm-kernel, linux-kernel, Wong Vee Khee
Disable is done in stmmac_init_eee() on the event of MAC link down.
Since setting enable/disable EEE via ethtool will eventually trigger
a MAC down, removing this redunctant call in stmmac_ethtool.c to avoid
calling xpcs_config_eee() twice.
Fixes: d4aeaed80b0e ("net: stmmac: trigger PCS to turn off on link down")
Signed-off-by: Wong Vee Khee <vee.khee.wong@linux.intel.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c
index abfb3cd5958d..9c3055ee2608 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c
@@ -803,14 +803,6 @@ static int stmmac_ethtool_op_set_eee(struct net_device *dev,
netdev_warn(priv->dev,
"Setting EEE tx-lpi is not supported\n");
- if (priv->hw->xpcs) {
- ret = xpcs_config_eee(priv->hw->xpcs,
- priv->plat->mult_fact_100ns,
- edata->eee_enabled);
- if (ret)
- return ret;
- }
-
if (!edata->eee_enabled)
stmmac_disable_eee_mode(priv);
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net 1/1] net: stmmac: remove redunctant disable xPCS EEE call
2022-07-15 12:24 [PATCH net 1/1] net: stmmac: remove redunctant disable xPCS EEE call Wong Vee Khee
@ 2022-07-19 3:40 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-07-19 3:40 UTC (permalink / raw)
To: Wong Vee Khee
Cc: davem, peppe.cavallaro, alexandre.torgue, joabreu, kuba,
mcoquelin.stm32, edumazet, pabeni, netdev, linux-stm32,
linux-arm-kernel, linux-kernel
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Fri, 15 Jul 2022 20:24:02 +0800 you wrote:
> Disable is done in stmmac_init_eee() on the event of MAC link down.
> Since setting enable/disable EEE via ethtool will eventually trigger
> a MAC down, removing this redunctant call in stmmac_ethtool.c to avoid
> calling xpcs_config_eee() twice.
>
> Fixes: d4aeaed80b0e ("net: stmmac: trigger PCS to turn off on link down")
> Signed-off-by: Wong Vee Khee <vee.khee.wong@linux.intel.com>
>
> [...]
Here is the summary with links:
- [net,1/1] net: stmmac: remove redunctant disable xPCS EEE call
https://git.kernel.org/netdev/net/c/da791bac104a
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-19 3:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-15 12:24 [PATCH net 1/1] net: stmmac: remove redunctant disable xPCS EEE call Wong Vee Khee
2022-07-19 3:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).