* [PATCH -next RESEND] soc: qcom: icc-bwmon: Remove unnecessary print function dev_err()
@ 2022-07-14 7:55 Yang Li
2022-07-14 8:02 ` Krzysztof Kozlowski
2022-07-19 4:48 ` (subset) " Bjorn Andersson
0 siblings, 2 replies; 3+ messages in thread
From: Yang Li @ 2022-07-14 7:55 UTC (permalink / raw)
To: krzysztof.kozlowski
Cc: agross, bjorn.andersson, konrad.dybcio, linux-arm-msm,
linux-kernel, Yang Li
Eliminate the follow coccicheck warning:
./drivers/soc/qcom/icc-bwmon.c:349:2-9: line 349 is redundant because platform_get_irq() already prints an error
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/soc/qcom/icc-bwmon.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/soc/qcom/icc-bwmon.c b/drivers/soc/qcom/icc-bwmon.c
index bea3ea1de7a4..7f8aca533cd3 100644
--- a/drivers/soc/qcom/icc-bwmon.c
+++ b/drivers/soc/qcom/icc-bwmon.c
@@ -345,10 +345,8 @@ static int bwmon_probe(struct platform_device *pdev)
}
bwmon->irq = platform_get_irq(pdev, 0);
- if (bwmon->irq < 0) {
- dev_err(dev, "failed to acquire bwmon IRQ\n");
+ if (bwmon->irq < 0)
return bwmon->irq;
- }
ret = devm_pm_opp_of_add_table(dev);
if (ret)
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next RESEND] soc: qcom: icc-bwmon: Remove unnecessary print function dev_err()
2022-07-14 7:55 [PATCH -next RESEND] soc: qcom: icc-bwmon: Remove unnecessary print function dev_err() Yang Li
@ 2022-07-14 8:02 ` Krzysztof Kozlowski
2022-07-19 4:48 ` (subset) " Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2022-07-14 8:02 UTC (permalink / raw)
To: Yang Li
Cc: agross, bjorn.andersson, konrad.dybcio, linux-arm-msm, linux-kernel
On 14/07/2022 09:55, Yang Li wrote:
> Eliminate the follow coccicheck warning:
> ./drivers/soc/qcom/icc-bwmon.c:349:2-9: line 349 is redundant because platform_get_irq() already prints an error
>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: (subset) [PATCH -next RESEND] soc: qcom: icc-bwmon: Remove unnecessary print function dev_err()
2022-07-14 7:55 [PATCH -next RESEND] soc: qcom: icc-bwmon: Remove unnecessary print function dev_err() Yang Li
2022-07-14 8:02 ` Krzysztof Kozlowski
@ 2022-07-19 4:48 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2022-07-19 4:48 UTC (permalink / raw)
To: yang.lee, krzysztof.kozlowski
Cc: agross, konrad.dybcio, linux-arm-msm, linux-kernel
On Thu, 14 Jul 2022 15:55:32 +0800, Yang Li wrote:
> Eliminate the follow coccicheck warning:
> ./drivers/soc/qcom/icc-bwmon.c:349:2-9: line 349 is redundant because platform_get_irq() already prints an error
>
>
Applied, thanks!
[1/1] soc: qcom: icc-bwmon: Remove unnecessary print function dev_err()
commit: 947bb0d16576bdac27f3355f268f51acfe29bfa7
Best regards,
--
Bjorn Andersson <bjorn.andersson@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-07-19 4:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-14 7:55 [PATCH -next RESEND] soc: qcom: icc-bwmon: Remove unnecessary print function dev_err() Yang Li
2022-07-14 8:02 ` Krzysztof Kozlowski
2022-07-19 4:48 ` (subset) " Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).