linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] arm64: dta: qcom: sc7280: delete vdda-1p2 and vdda-0p9 from both dp and edp
@ 2022-07-11 16:23 Kuogee Hsieh
  2022-07-11 16:47 ` Doug Anderson
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Kuogee Hsieh @ 2022-07-11 16:23 UTC (permalink / raw)
  To: robdclark, sean, swboyd, dianders, vkoul, agross,
	bjorn.andersson, robh+dt, devicetree
  Cc: quic_abhinavk, quic_aravindh, quic_khsieh, quic_sbillaka,
	quic_mkrishn, quic_kalyant, freedreno, linux-arm-msm,
	linux-kernel

Both vdda-1p2-supply and vdda-0p9-supply regulators are controlled
by dp combo phy. Therefore remove them from dp controller.

Signed-off-by: Kuogee Hsieh <quic_khsieh@quicinc.com>
---
 arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 2 --
 arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi     | 3 ---
 2 files changed, 5 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
index ed800817..3f8996c 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
@@ -435,8 +435,6 @@ ap_i2c_tpm: &i2c14 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&dp_hot_plug_det>;
 	data-lanes = <0 1>;
-	vdda-1p2-supply = <&vdd_a_usbssdp_0_1p2>;
-	vdda-0p9-supply = <&vdd_a_usbssdp_0_core>;
 };
 
 &mdss_mdp {
diff --git a/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi b/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi
index 4c25ffc..7adf31b 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi
@@ -311,9 +311,6 @@
 
 /* NOTE: Not all Qcards have eDP connector stuffed */
 &mdss_edp {
-	vdda-0p9-supply = <&vdd_a_edp_0_0p9>;
-	vdda-1p2-supply = <&vdd_a_edp_0_1p2>;
-
 	aux-bus {
 		edp_panel: panel {
 			compatible = "edp-panel";
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] arm64: dta: qcom: sc7280: delete vdda-1p2 and vdda-0p9 from both dp and edp
  2022-07-11 16:23 [PATCH v2] arm64: dta: qcom: sc7280: delete vdda-1p2 and vdda-0p9 from both dp and edp Kuogee Hsieh
@ 2022-07-11 16:47 ` Doug Anderson
  2022-07-19  0:00 ` Bjorn Andersson
  2022-07-19  4:48 ` (subset) " Bjorn Andersson
  2 siblings, 0 replies; 4+ messages in thread
From: Doug Anderson @ 2022-07-11 16:47 UTC (permalink / raw)
  To: Kuogee Hsieh
  Cc: Rob Clark, Sean Paul, Stephen Boyd, Vinod Koul, Andy Gross,
	Bjorn Andersson, Rob Herring,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Abhinav Kumar (QUIC), Aravind Venkateswaran (QUIC),
	Sankeerth Billakanti, quic_mkrishn, quic_kalyant, freedreno,
	linux-arm-msm, LKML

Hi,

On Mon, Jul 11, 2022 at 9:23 AM Kuogee Hsieh <quic_khsieh@quicinc.com> wrote:
>
> Both vdda-1p2-supply and vdda-0p9-supply regulators are controlled
> by dp combo phy. Therefore remove them from dp controller.
>
> Signed-off-by: Kuogee Hsieh <quic_khsieh@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 2 --
>  arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi     | 3 ---
>  2 files changed, 5 deletions(-)

Reviewed-by: Douglas Anderson <dianders@chromium.org>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] arm64: dta: qcom: sc7280: delete vdda-1p2 and vdda-0p9 from both dp and edp
  2022-07-11 16:23 [PATCH v2] arm64: dta: qcom: sc7280: delete vdda-1p2 and vdda-0p9 from both dp and edp Kuogee Hsieh
  2022-07-11 16:47 ` Doug Anderson
@ 2022-07-19  0:00 ` Bjorn Andersson
  2022-07-19  4:48 ` (subset) " Bjorn Andersson
  2 siblings, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2022-07-19  0:00 UTC (permalink / raw)
  To: Kuogee Hsieh
  Cc: robdclark, sean, swboyd, dianders, vkoul, agross, robh+dt,
	devicetree, quic_abhinavk, quic_aravindh, quic_sbillaka,
	quic_mkrishn, quic_kalyant, freedreno, linux-arm-msm,
	linux-kernel

On Mon 11 Jul 11:23 CDT 2022, Kuogee Hsieh wrote:

Please double check that the subject prefix matches existing changes
next time.

Thanks,
Bjorn

> Both vdda-1p2-supply and vdda-0p9-supply regulators are controlled
> by dp combo phy. Therefore remove them from dp controller.
> 
> Signed-off-by: Kuogee Hsieh <quic_khsieh@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 2 --
>  arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi     | 3 ---
>  2 files changed, 5 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
> index ed800817..3f8996c 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
> @@ -435,8 +435,6 @@ ap_i2c_tpm: &i2c14 {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&dp_hot_plug_det>;
>  	data-lanes = <0 1>;
> -	vdda-1p2-supply = <&vdd_a_usbssdp_0_1p2>;
> -	vdda-0p9-supply = <&vdd_a_usbssdp_0_core>;
>  };
>  
>  &mdss_mdp {
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi b/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi
> index 4c25ffc..7adf31b 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi
> @@ -311,9 +311,6 @@
>  
>  /* NOTE: Not all Qcards have eDP connector stuffed */
>  &mdss_edp {
> -	vdda-0p9-supply = <&vdd_a_edp_0_0p9>;
> -	vdda-1p2-supply = <&vdd_a_edp_0_1p2>;
> -
>  	aux-bus {
>  		edp_panel: panel {
>  			compatible = "edp-panel";
> -- 
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: (subset) [PATCH v2] arm64: dta: qcom: sc7280: delete vdda-1p2 and vdda-0p9 from both dp and edp
  2022-07-11 16:23 [PATCH v2] arm64: dta: qcom: sc7280: delete vdda-1p2 and vdda-0p9 from both dp and edp Kuogee Hsieh
  2022-07-11 16:47 ` Doug Anderson
  2022-07-19  0:00 ` Bjorn Andersson
@ 2022-07-19  4:48 ` Bjorn Andersson
  2 siblings, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2022-07-19  4:48 UTC (permalink / raw)
  To: robh+dt, robdclark, quic_khsieh, sean, vkoul, swboyd, agross,
	devicetree, dianders
  Cc: quic_sbillaka, freedreno, quic_aravindh, linux-arm-msm,
	quic_kalyant, quic_abhinavk, linux-kernel, quic_mkrishn

On Mon, 11 Jul 2022 09:23:23 -0700, Kuogee Hsieh wrote:
> Both vdda-1p2-supply and vdda-0p9-supply regulators are controlled
> by dp combo phy. Therefore remove them from dp controller.
> 
> 

Applied, thanks!

[1/1] arm64: dta: qcom: sc7280: delete vdda-1p2 and vdda-0p9 from both dp and edp
      commit: 8ed85d1e515ff5f302a929308c7ccc06bec68632

Best regards,
-- 
Bjorn Andersson <bjorn.andersson@linaro.org>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-07-19  4:48 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-11 16:23 [PATCH v2] arm64: dta: qcom: sc7280: delete vdda-1p2 and vdda-0p9 from both dp and edp Kuogee Hsieh
2022-07-11 16:47 ` Doug Anderson
2022-07-19  0:00 ` Bjorn Andersson
2022-07-19  4:48 ` (subset) " Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).