* [PATCH 0/2] platform/chrome: avoid garbage bytes in `msg->result`
@ 2022-07-20 4:47 Tzung-Bi Shih
2022-07-20 4:47 ` [PATCH 1/2] platform/chrome: merge Kunit utils and test cases Tzung-Bi Shih
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Tzung-Bi Shih @ 2022-07-20 4:47 UTC (permalink / raw)
To: bleung, groeck; +Cc: chrome-platform, linux-kernel, tzungbi
The 1st patch merges Kunit utils and test cases. The idea is basically from
the review comment in [1].
The 2nd patch fixes that `msg->result` would be garbage bytes if the mock list
is empty. This is separated from previous series [2].
[1]: https://patchwork.kernel.org/project/chrome-platform/patch/20220718050914.2267370-2-tzungbi@kernel.org/#24944149
[2]: https://patchwork.kernel.org/project/chrome-platform/patch/20220718050914.2267370-2-tzungbi@kernel.org/
Tzung-Bi Shih (2):
platform/chrome: merge Kunit utils and test cases
platform/chrome: cros_kunit_util: add default value for `msg->result`
drivers/platform/chrome/Kconfig | 10 ++--------
drivers/platform/chrome/Makefile | 5 +++--
drivers/platform/chrome/cros_kunit_util.c | 20 +++++---------------
drivers/platform/chrome/cros_kunit_util.h | 1 +
4 files changed, 11 insertions(+), 25 deletions(-)
--
2.37.0.170.g444d1eabd0-goog
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/2] platform/chrome: merge Kunit utils and test cases
2022-07-20 4:47 [PATCH 0/2] platform/chrome: avoid garbage bytes in `msg->result` Tzung-Bi Shih
@ 2022-07-20 4:47 ` Tzung-Bi Shih
2022-07-20 13:01 ` Guenter Roeck
2022-07-20 4:47 ` [PATCH 2/2] platform/chrome: cros_kunit_util: add default value for `msg->result` Tzung-Bi Shih
` (2 subsequent siblings)
3 siblings, 1 reply; 7+ messages in thread
From: Tzung-Bi Shih @ 2022-07-20 4:47 UTC (permalink / raw)
To: bleung, groeck; +Cc: chrome-platform, linux-kernel, tzungbi
Merge CROS_KUNIT and CROS_EC_PROTO_KUNIT_TEST so that when they're built
as modules cros_kunit_util doesn't need to export the symbols.
Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
---
drivers/platform/chrome/Kconfig | 10 ++--------
drivers/platform/chrome/Makefile | 5 +++--
drivers/platform/chrome/cros_kunit_util.c | 14 --------------
3 files changed, 5 insertions(+), 24 deletions(-)
diff --git a/drivers/platform/chrome/Kconfig b/drivers/platform/chrome/Kconfig
index cae859f0bc06..c45fb376d653 100644
--- a/drivers/platform/chrome/Kconfig
+++ b/drivers/platform/chrome/Kconfig
@@ -269,17 +269,11 @@ source "drivers/platform/chrome/wilco_ec/Kconfig"
# Kunit test cases
config CROS_KUNIT
- tristate
- help
- ChromeOS Kunit.
-
-config CROS_EC_PROTO_KUNIT_TEST
- tristate "Kunit tests for ChromeOS EC protocol" if !KUNIT_ALL_TESTS
+ tristate "Kunit tests for ChromeOS" if !KUNIT_ALL_TESTS
depends on KUNIT && CROS_EC
default KUNIT_ALL_TESTS
select CROS_EC_PROTO
- select CROS_KUNIT
help
- Kunit tests for the ChromeOS Embedded Controller protocol.
+ ChromeOS Kunit tests.
endif # CHROMEOS_PLATFORMS
diff --git a/drivers/platform/chrome/Makefile b/drivers/platform/chrome/Makefile
index a06bc56d12a8..f7e74a845afc 100644
--- a/drivers/platform/chrome/Makefile
+++ b/drivers/platform/chrome/Makefile
@@ -32,5 +32,6 @@ obj-$(CONFIG_CROS_USBPD_NOTIFY) += cros_usbpd_notify.o
obj-$(CONFIG_WILCO_EC) += wilco_ec/
# Kunit test cases
-obj-$(CONFIG_CROS_KUNIT) += cros_kunit_util.o
-obj-$(CONFIG_CROS_EC_PROTO_KUNIT_TEST) += cros_ec_proto_test.o
+obj-$(CONFIG_CROS_KUNIT) += cros_kunit.o
+cros_kunit-objs := cros_kunit_util.o
+cros_kunit-objs += cros_ec_proto_test.o
diff --git a/drivers/platform/chrome/cros_kunit_util.c b/drivers/platform/chrome/cros_kunit_util.c
index d37c334b416d..090927d43035 100644
--- a/drivers/platform/chrome/cros_kunit_util.c
+++ b/drivers/platform/chrome/cros_kunit_util.c
@@ -14,11 +14,8 @@
#include "cros_kunit_util.h"
int cros_kunit_ec_xfer_mock_default_ret;
-EXPORT_SYMBOL_GPL(cros_kunit_ec_xfer_mock_default_ret);
int cros_kunit_ec_cmd_xfer_mock_called;
-EXPORT_SYMBOL_GPL(cros_kunit_ec_cmd_xfer_mock_called);
int cros_kunit_ec_pkt_xfer_mock_called;
-EXPORT_SYMBOL_GPL(cros_kunit_ec_pkt_xfer_mock_called);
static struct list_head cros_kunit_ec_xfer_mock_in;
static struct list_head cros_kunit_ec_xfer_mock_out;
@@ -48,27 +45,23 @@ int cros_kunit_ec_xfer_mock(struct cros_ec_device *ec_dev, struct cros_ec_comman
return mock->ret;
}
-EXPORT_SYMBOL_GPL(cros_kunit_ec_xfer_mock);
int cros_kunit_ec_cmd_xfer_mock(struct cros_ec_device *ec_dev, struct cros_ec_command *msg)
{
++cros_kunit_ec_cmd_xfer_mock_called;
return cros_kunit_ec_xfer_mock(ec_dev, msg);
}
-EXPORT_SYMBOL_GPL(cros_kunit_ec_cmd_xfer_mock);
int cros_kunit_ec_pkt_xfer_mock(struct cros_ec_device *ec_dev, struct cros_ec_command *msg)
{
++cros_kunit_ec_pkt_xfer_mock_called;
return cros_kunit_ec_xfer_mock(ec_dev, msg);
}
-EXPORT_SYMBOL_GPL(cros_kunit_ec_pkt_xfer_mock);
struct ec_xfer_mock *cros_kunit_ec_xfer_mock_add(struct kunit *test, size_t size)
{
return cros_kunit_ec_xfer_mock_addx(test, size, EC_RES_SUCCESS, size);
}
-EXPORT_SYMBOL_GPL(cros_kunit_ec_xfer_mock_add);
struct ec_xfer_mock *cros_kunit_ec_xfer_mock_addx(struct kunit *test,
int ret, int result, size_t size)
@@ -91,7 +84,6 @@ struct ec_xfer_mock *cros_kunit_ec_xfer_mock_addx(struct kunit *test,
return mock;
}
-EXPORT_SYMBOL_GPL(cros_kunit_ec_xfer_mock_addx);
struct ec_xfer_mock *cros_kunit_ec_xfer_mock_next(void)
{
@@ -103,14 +95,10 @@ struct ec_xfer_mock *cros_kunit_ec_xfer_mock_next(void)
return mock;
}
-EXPORT_SYMBOL_GPL(cros_kunit_ec_xfer_mock_next);
int cros_kunit_readmem_mock_offset;
-EXPORT_SYMBOL_GPL(cros_kunit_readmem_mock_offset);
u8 *cros_kunit_readmem_mock_data;
-EXPORT_SYMBOL_GPL(cros_kunit_readmem_mock_data);
int cros_kunit_readmem_mock_ret;
-EXPORT_SYMBOL_GPL(cros_kunit_readmem_mock_ret);
int cros_kunit_readmem_mock(struct cros_ec_device *ec_dev, unsigned int offset,
unsigned int bytes, void *dest)
@@ -121,7 +109,6 @@ int cros_kunit_readmem_mock(struct cros_ec_device *ec_dev, unsigned int offset,
return cros_kunit_readmem_mock_ret;
}
-EXPORT_SYMBOL_GPL(cros_kunit_readmem_mock);
void cros_kunit_mock_reset(void)
{
@@ -135,6 +122,5 @@ void cros_kunit_mock_reset(void)
cros_kunit_readmem_mock_data = NULL;
cros_kunit_readmem_mock_ret = 0;
}
-EXPORT_SYMBOL_GPL(cros_kunit_mock_reset);
MODULE_LICENSE("GPL");
--
2.37.0.170.g444d1eabd0-goog
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/2] platform/chrome: cros_kunit_util: add default value for `msg->result`
2022-07-20 4:47 [PATCH 0/2] platform/chrome: avoid garbage bytes in `msg->result` Tzung-Bi Shih
2022-07-20 4:47 ` [PATCH 1/2] platform/chrome: merge Kunit utils and test cases Tzung-Bi Shih
@ 2022-07-20 4:47 ` Tzung-Bi Shih
2022-07-20 13:02 ` Guenter Roeck
2022-07-21 9:00 ` [PATCH 0/2] platform/chrome: avoid garbage bytes in `msg->result` patchwork-bot+chrome-platform
2022-07-22 0:20 ` patchwork-bot+chrome-platform
3 siblings, 1 reply; 7+ messages in thread
From: Tzung-Bi Shih @ 2022-07-20 4:47 UTC (permalink / raw)
To: bleung, groeck; +Cc: chrome-platform, linux-kernel, tzungbi
Add default value for `msg->result` so that it won't be garbage bytes
when the mock list is empty.
Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
---
drivers/platform/chrome/cros_kunit_util.c | 6 +++++-
drivers/platform/chrome/cros_kunit_util.h | 1 +
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/chrome/cros_kunit_util.c b/drivers/platform/chrome/cros_kunit_util.c
index 090927d43035..f0fda96b11bd 100644
--- a/drivers/platform/chrome/cros_kunit_util.c
+++ b/drivers/platform/chrome/cros_kunit_util.c
@@ -13,6 +13,7 @@
#include "cros_ec.h"
#include "cros_kunit_util.h"
+int cros_kunit_ec_xfer_mock_default_result;
int cros_kunit_ec_xfer_mock_default_ret;
int cros_kunit_ec_cmd_xfer_mock_called;
int cros_kunit_ec_pkt_xfer_mock_called;
@@ -25,8 +26,10 @@ int cros_kunit_ec_xfer_mock(struct cros_ec_device *ec_dev, struct cros_ec_comman
struct ec_xfer_mock *mock;
mock = list_first_entry_or_null(&cros_kunit_ec_xfer_mock_in, struct ec_xfer_mock, list);
- if (!mock)
+ if (!mock) {
+ msg->result = cros_kunit_ec_xfer_mock_default_result;
return cros_kunit_ec_xfer_mock_default_ret;
+ }
list_del(&mock->list);
@@ -112,6 +115,7 @@ int cros_kunit_readmem_mock(struct cros_ec_device *ec_dev, unsigned int offset,
void cros_kunit_mock_reset(void)
{
+ cros_kunit_ec_xfer_mock_default_result = 0;
cros_kunit_ec_xfer_mock_default_ret = 0;
cros_kunit_ec_cmd_xfer_mock_called = 0;
cros_kunit_ec_pkt_xfer_mock_called = 0;
diff --git a/drivers/platform/chrome/cros_kunit_util.h b/drivers/platform/chrome/cros_kunit_util.h
index 88134c9f1acf..414002271c9c 100644
--- a/drivers/platform/chrome/cros_kunit_util.h
+++ b/drivers/platform/chrome/cros_kunit_util.h
@@ -23,6 +23,7 @@ struct ec_xfer_mock {
u32 o_data_len;
};
+extern int cros_kunit_ec_xfer_mock_default_result;
extern int cros_kunit_ec_xfer_mock_default_ret;
extern int cros_kunit_ec_cmd_xfer_mock_called;
extern int cros_kunit_ec_pkt_xfer_mock_called;
--
2.37.0.170.g444d1eabd0-goog
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] platform/chrome: merge Kunit utils and test cases
2022-07-20 4:47 ` [PATCH 1/2] platform/chrome: merge Kunit utils and test cases Tzung-Bi Shih
@ 2022-07-20 13:01 ` Guenter Roeck
0 siblings, 0 replies; 7+ messages in thread
From: Guenter Roeck @ 2022-07-20 13:01 UTC (permalink / raw)
To: Tzung-Bi Shih
Cc: Benson Leung, Guenter Roeck,
open list:CHROME HARDWARE PLATFORM SUPPORT, linux-kernel
On Tue, Jul 19, 2022 at 9:48 PM Tzung-Bi Shih <tzungbi@kernel.org> wrote:
>
> Merge CROS_KUNIT and CROS_EC_PROTO_KUNIT_TEST so that when they're built
> as modules cros_kunit_util doesn't need to export the symbols.
>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
> Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
> ---
> drivers/platform/chrome/Kconfig | 10 ++--------
> drivers/platform/chrome/Makefile | 5 +++--
> drivers/platform/chrome/cros_kunit_util.c | 14 --------------
> 3 files changed, 5 insertions(+), 24 deletions(-)
>
> diff --git a/drivers/platform/chrome/Kconfig b/drivers/platform/chrome/Kconfig
> index cae859f0bc06..c45fb376d653 100644
> --- a/drivers/platform/chrome/Kconfig
> +++ b/drivers/platform/chrome/Kconfig
> @@ -269,17 +269,11 @@ source "drivers/platform/chrome/wilco_ec/Kconfig"
>
> # Kunit test cases
> config CROS_KUNIT
> - tristate
> - help
> - ChromeOS Kunit.
> -
> -config CROS_EC_PROTO_KUNIT_TEST
> - tristate "Kunit tests for ChromeOS EC protocol" if !KUNIT_ALL_TESTS
> + tristate "Kunit tests for ChromeOS" if !KUNIT_ALL_TESTS
> depends on KUNIT && CROS_EC
> default KUNIT_ALL_TESTS
> select CROS_EC_PROTO
> - select CROS_KUNIT
> help
> - Kunit tests for the ChromeOS Embedded Controller protocol.
> + ChromeOS Kunit tests.
>
> endif # CHROMEOS_PLATFORMS
> diff --git a/drivers/platform/chrome/Makefile b/drivers/platform/chrome/Makefile
> index a06bc56d12a8..f7e74a845afc 100644
> --- a/drivers/platform/chrome/Makefile
> +++ b/drivers/platform/chrome/Makefile
> @@ -32,5 +32,6 @@ obj-$(CONFIG_CROS_USBPD_NOTIFY) += cros_usbpd_notify.o
> obj-$(CONFIG_WILCO_EC) += wilco_ec/
>
> # Kunit test cases
> -obj-$(CONFIG_CROS_KUNIT) += cros_kunit_util.o
> -obj-$(CONFIG_CROS_EC_PROTO_KUNIT_TEST) += cros_ec_proto_test.o
> +obj-$(CONFIG_CROS_KUNIT) += cros_kunit.o
> +cros_kunit-objs := cros_kunit_util.o
> +cros_kunit-objs += cros_ec_proto_test.o
> diff --git a/drivers/platform/chrome/cros_kunit_util.c b/drivers/platform/chrome/cros_kunit_util.c
> index d37c334b416d..090927d43035 100644
> --- a/drivers/platform/chrome/cros_kunit_util.c
> +++ b/drivers/platform/chrome/cros_kunit_util.c
> @@ -14,11 +14,8 @@
> #include "cros_kunit_util.h"
>
> int cros_kunit_ec_xfer_mock_default_ret;
> -EXPORT_SYMBOL_GPL(cros_kunit_ec_xfer_mock_default_ret);
> int cros_kunit_ec_cmd_xfer_mock_called;
> -EXPORT_SYMBOL_GPL(cros_kunit_ec_cmd_xfer_mock_called);
> int cros_kunit_ec_pkt_xfer_mock_called;
> -EXPORT_SYMBOL_GPL(cros_kunit_ec_pkt_xfer_mock_called);
>
> static struct list_head cros_kunit_ec_xfer_mock_in;
> static struct list_head cros_kunit_ec_xfer_mock_out;
> @@ -48,27 +45,23 @@ int cros_kunit_ec_xfer_mock(struct cros_ec_device *ec_dev, struct cros_ec_comman
>
> return mock->ret;
> }
> -EXPORT_SYMBOL_GPL(cros_kunit_ec_xfer_mock);
>
> int cros_kunit_ec_cmd_xfer_mock(struct cros_ec_device *ec_dev, struct cros_ec_command *msg)
> {
> ++cros_kunit_ec_cmd_xfer_mock_called;
> return cros_kunit_ec_xfer_mock(ec_dev, msg);
> }
> -EXPORT_SYMBOL_GPL(cros_kunit_ec_cmd_xfer_mock);
>
> int cros_kunit_ec_pkt_xfer_mock(struct cros_ec_device *ec_dev, struct cros_ec_command *msg)
> {
> ++cros_kunit_ec_pkt_xfer_mock_called;
> return cros_kunit_ec_xfer_mock(ec_dev, msg);
> }
> -EXPORT_SYMBOL_GPL(cros_kunit_ec_pkt_xfer_mock);
>
> struct ec_xfer_mock *cros_kunit_ec_xfer_mock_add(struct kunit *test, size_t size)
> {
> return cros_kunit_ec_xfer_mock_addx(test, size, EC_RES_SUCCESS, size);
> }
> -EXPORT_SYMBOL_GPL(cros_kunit_ec_xfer_mock_add);
>
> struct ec_xfer_mock *cros_kunit_ec_xfer_mock_addx(struct kunit *test,
> int ret, int result, size_t size)
> @@ -91,7 +84,6 @@ struct ec_xfer_mock *cros_kunit_ec_xfer_mock_addx(struct kunit *test,
>
> return mock;
> }
> -EXPORT_SYMBOL_GPL(cros_kunit_ec_xfer_mock_addx);
>
> struct ec_xfer_mock *cros_kunit_ec_xfer_mock_next(void)
> {
> @@ -103,14 +95,10 @@ struct ec_xfer_mock *cros_kunit_ec_xfer_mock_next(void)
>
> return mock;
> }
> -EXPORT_SYMBOL_GPL(cros_kunit_ec_xfer_mock_next);
>
> int cros_kunit_readmem_mock_offset;
> -EXPORT_SYMBOL_GPL(cros_kunit_readmem_mock_offset);
> u8 *cros_kunit_readmem_mock_data;
> -EXPORT_SYMBOL_GPL(cros_kunit_readmem_mock_data);
> int cros_kunit_readmem_mock_ret;
> -EXPORT_SYMBOL_GPL(cros_kunit_readmem_mock_ret);
>
> int cros_kunit_readmem_mock(struct cros_ec_device *ec_dev, unsigned int offset,
> unsigned int bytes, void *dest)
> @@ -121,7 +109,6 @@ int cros_kunit_readmem_mock(struct cros_ec_device *ec_dev, unsigned int offset,
>
> return cros_kunit_readmem_mock_ret;
> }
> -EXPORT_SYMBOL_GPL(cros_kunit_readmem_mock);
>
> void cros_kunit_mock_reset(void)
> {
> @@ -135,6 +122,5 @@ void cros_kunit_mock_reset(void)
> cros_kunit_readmem_mock_data = NULL;
> cros_kunit_readmem_mock_ret = 0;
> }
> -EXPORT_SYMBOL_GPL(cros_kunit_mock_reset);
>
> MODULE_LICENSE("GPL");
> --
> 2.37.0.170.g444d1eabd0-goog
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] platform/chrome: cros_kunit_util: add default value for `msg->result`
2022-07-20 4:47 ` [PATCH 2/2] platform/chrome: cros_kunit_util: add default value for `msg->result` Tzung-Bi Shih
@ 2022-07-20 13:02 ` Guenter Roeck
0 siblings, 0 replies; 7+ messages in thread
From: Guenter Roeck @ 2022-07-20 13:02 UTC (permalink / raw)
To: Tzung-Bi Shih
Cc: Benson Leung, Guenter Roeck,
open list:CHROME HARDWARE PLATFORM SUPPORT, linux-kernel
On Tue, Jul 19, 2022 at 9:48 PM Tzung-Bi Shih <tzungbi@kernel.org> wrote:
>
> Add default value for `msg->result` so that it won't be garbage bytes
> when the mock list is empty.
>
> Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
> ---
> drivers/platform/chrome/cros_kunit_util.c | 6 +++++-
> drivers/platform/chrome/cros_kunit_util.h | 1 +
> 2 files changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/platform/chrome/cros_kunit_util.c b/drivers/platform/chrome/cros_kunit_util.c
> index 090927d43035..f0fda96b11bd 100644
> --- a/drivers/platform/chrome/cros_kunit_util.c
> +++ b/drivers/platform/chrome/cros_kunit_util.c
> @@ -13,6 +13,7 @@
> #include "cros_ec.h"
> #include "cros_kunit_util.h"
>
> +int cros_kunit_ec_xfer_mock_default_result;
> int cros_kunit_ec_xfer_mock_default_ret;
> int cros_kunit_ec_cmd_xfer_mock_called;
> int cros_kunit_ec_pkt_xfer_mock_called;
> @@ -25,8 +26,10 @@ int cros_kunit_ec_xfer_mock(struct cros_ec_device *ec_dev, struct cros_ec_comman
> struct ec_xfer_mock *mock;
>
> mock = list_first_entry_or_null(&cros_kunit_ec_xfer_mock_in, struct ec_xfer_mock, list);
> - if (!mock)
> + if (!mock) {
> + msg->result = cros_kunit_ec_xfer_mock_default_result;
> return cros_kunit_ec_xfer_mock_default_ret;
> + }
>
> list_del(&mock->list);
>
> @@ -112,6 +115,7 @@ int cros_kunit_readmem_mock(struct cros_ec_device *ec_dev, unsigned int offset,
>
> void cros_kunit_mock_reset(void)
> {
> + cros_kunit_ec_xfer_mock_default_result = 0;
> cros_kunit_ec_xfer_mock_default_ret = 0;
> cros_kunit_ec_cmd_xfer_mock_called = 0;
> cros_kunit_ec_pkt_xfer_mock_called = 0;
> diff --git a/drivers/platform/chrome/cros_kunit_util.h b/drivers/platform/chrome/cros_kunit_util.h
> index 88134c9f1acf..414002271c9c 100644
> --- a/drivers/platform/chrome/cros_kunit_util.h
> +++ b/drivers/platform/chrome/cros_kunit_util.h
> @@ -23,6 +23,7 @@ struct ec_xfer_mock {
> u32 o_data_len;
> };
>
> +extern int cros_kunit_ec_xfer_mock_default_result;
> extern int cros_kunit_ec_xfer_mock_default_ret;
> extern int cros_kunit_ec_cmd_xfer_mock_called;
> extern int cros_kunit_ec_pkt_xfer_mock_called;
> --
> 2.37.0.170.g444d1eabd0-goog
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 0/2] platform/chrome: avoid garbage bytes in `msg->result`
2022-07-20 4:47 [PATCH 0/2] platform/chrome: avoid garbage bytes in `msg->result` Tzung-Bi Shih
2022-07-20 4:47 ` [PATCH 1/2] platform/chrome: merge Kunit utils and test cases Tzung-Bi Shih
2022-07-20 4:47 ` [PATCH 2/2] platform/chrome: cros_kunit_util: add default value for `msg->result` Tzung-Bi Shih
@ 2022-07-21 9:00 ` patchwork-bot+chrome-platform
2022-07-22 0:20 ` patchwork-bot+chrome-platform
3 siblings, 0 replies; 7+ messages in thread
From: patchwork-bot+chrome-platform @ 2022-07-21 9:00 UTC (permalink / raw)
To: Tzung-Bi Shih; +Cc: bleung, groeck, chrome-platform, linux-kernel
Hello:
This series was applied to chrome-platform/linux.git (for-kernelci)
by Tzung-Bi Shih <tzungbi@kernel.org>:
On Wed, 20 Jul 2022 04:47:52 +0000 you wrote:
> The 1st patch merges Kunit utils and test cases. The idea is basically from
> the review comment in [1].
>
> The 2nd patch fixes that `msg->result` would be garbage bytes if the mock list
> is empty. This is separated from previous series [2].
>
> [1]: https://patchwork.kernel.org/project/chrome-platform/patch/20220718050914.2267370-2-tzungbi@kernel.org/#24944149
> [2]: https://patchwork.kernel.org/project/chrome-platform/patch/20220718050914.2267370-2-tzungbi@kernel.org/
>
> [...]
Here is the summary with links:
- [1/2] platform/chrome: merge Kunit utils and test cases
https://git.kernel.org/chrome-platform/c/f92dd1475b06
- [2/2] platform/chrome: cros_kunit_util: add default value for `msg->result`
https://git.kernel.org/chrome-platform/c/afef1e1a0223
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 0/2] platform/chrome: avoid garbage bytes in `msg->result`
2022-07-20 4:47 [PATCH 0/2] platform/chrome: avoid garbage bytes in `msg->result` Tzung-Bi Shih
` (2 preceding siblings ...)
2022-07-21 9:00 ` [PATCH 0/2] platform/chrome: avoid garbage bytes in `msg->result` patchwork-bot+chrome-platform
@ 2022-07-22 0:20 ` patchwork-bot+chrome-platform
3 siblings, 0 replies; 7+ messages in thread
From: patchwork-bot+chrome-platform @ 2022-07-22 0:20 UTC (permalink / raw)
To: Tzung-Bi Shih; +Cc: bleung, groeck, chrome-platform, linux-kernel
Hello:
This series was applied to chrome-platform/linux.git (for-next)
by Tzung-Bi Shih <tzungbi@kernel.org>:
On Wed, 20 Jul 2022 04:47:52 +0000 you wrote:
> The 1st patch merges Kunit utils and test cases. The idea is basically from
> the review comment in [1].
>
> The 2nd patch fixes that `msg->result` would be garbage bytes if the mock list
> is empty. This is separated from previous series [2].
>
> [1]: https://patchwork.kernel.org/project/chrome-platform/patch/20220718050914.2267370-2-tzungbi@kernel.org/#24944149
> [2]: https://patchwork.kernel.org/project/chrome-platform/patch/20220718050914.2267370-2-tzungbi@kernel.org/
>
> [...]
Here is the summary with links:
- [1/2] platform/chrome: merge Kunit utils and test cases
https://git.kernel.org/chrome-platform/c/f92dd1475b06
- [2/2] platform/chrome: cros_kunit_util: add default value for `msg->result`
https://git.kernel.org/chrome-platform/c/afef1e1a0223
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-07-22 0:20 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-20 4:47 [PATCH 0/2] platform/chrome: avoid garbage bytes in `msg->result` Tzung-Bi Shih
2022-07-20 4:47 ` [PATCH 1/2] platform/chrome: merge Kunit utils and test cases Tzung-Bi Shih
2022-07-20 13:01 ` Guenter Roeck
2022-07-20 4:47 ` [PATCH 2/2] platform/chrome: cros_kunit_util: add default value for `msg->result` Tzung-Bi Shih
2022-07-20 13:02 ` Guenter Roeck
2022-07-21 9:00 ` [PATCH 0/2] platform/chrome: avoid garbage bytes in `msg->result` patchwork-bot+chrome-platform
2022-07-22 0:20 ` patchwork-bot+chrome-platform
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).