* [PATCH v4] memblock tests: fix compilation errors
@ 2022-07-27 10:07 Liu Xinpeng
2022-07-29 7:27 ` Mike Rapoport
0 siblings, 1 reply; 2+ messages in thread
From: Liu Xinpeng @ 2022-07-27 10:07 UTC (permalink / raw)
To: rppt, mawupeng1, jrdr.linux, david; +Cc: linux-mm, linux-kernel, Liu Xinpeng
Do 'make -C tools/testing/memblock', get the following errors:
memblock.o: In function `memblock_find_in_range.constprop.9':
memblock.c:(.text+0x4651): undefined reference to `pr_warn_ratelimited'
memblock.o: In function `memblock_mark_mirror':
memblock.c:(.text+0x7171): undefined reference to `mirrored_kernelcore'
Fixes: 902c2d91582c ("memblock: Disable mirror feature if kernelcore is not specified")
Fixes: 14d9a675fd0d ("mm: Ratelimited mirrored memory related warning messages")
Signed-off-by: Liu Xinpeng <liuxp11@chinatelecom.cn>
Tested-by: Ma Wupeng <mawupeng1@huawei.com>
---
Changelog:
V3 -> V4: Changed the title and add how to reproduce this issue.
V2 -> V3: Fixs should not have word wrap.
V1 -> V2: Removed comma in macro define and addressed review comments.
---
tools/testing/memblock/internal.h | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/tools/testing/memblock/internal.h b/tools/testing/memblock/internal.h
index c2a492c05e0c..fdb7f5db7308 100644
--- a/tools/testing/memblock/internal.h
+++ b/tools/testing/memblock/internal.h
@@ -9,6 +9,10 @@
static int memblock_debug = 1;
#endif
+#define pr_warn_ratelimited(fmt, ...) printf(fmt, ##__VA_ARGS__)
+
+bool mirrored_kernelcore = false;
+
struct page {};
void memblock_free_pages(struct page *page, unsigned long pfn,
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v4] memblock tests: fix compilation errors
2022-07-27 10:07 [PATCH v4] memblock tests: fix compilation errors Liu Xinpeng
@ 2022-07-29 7:27 ` Mike Rapoport
0 siblings, 0 replies; 2+ messages in thread
From: Mike Rapoport @ 2022-07-29 7:27 UTC (permalink / raw)
To: Liu Xinpeng; +Cc: mawupeng1, jrdr.linux, david, linux-mm, linux-kernel
On Wed, Jul 27, 2022 at 06:07:33PM +0800, Liu Xinpeng wrote:
> Do 'make -C tools/testing/memblock', get the following errors:
>
> memblock.o: In function `memblock_find_in_range.constprop.9':
> memblock.c:(.text+0x4651): undefined reference to `pr_warn_ratelimited'
> memblock.o: In function `memblock_mark_mirror':
> memblock.c:(.text+0x7171): undefined reference to `mirrored_kernelcore'
>
> Fixes: 902c2d91582c ("memblock: Disable mirror feature if kernelcore is not specified")
> Fixes: 14d9a675fd0d ("mm: Ratelimited mirrored memory related warning messages")
>
> Signed-off-by: Liu Xinpeng <liuxp11@chinatelecom.cn>
> Tested-by: Ma Wupeng <mawupeng1@huawei.com>
Applied, thanks!
> ---
> Changelog:
> V3 -> V4: Changed the title and add how to reproduce this issue.
> V2 -> V3: Fixs should not have word wrap.
> V1 -> V2: Removed comma in macro define and addressed review comments.
> ---
> tools/testing/memblock/internal.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/tools/testing/memblock/internal.h b/tools/testing/memblock/internal.h
> index c2a492c05e0c..fdb7f5db7308 100644
> --- a/tools/testing/memblock/internal.h
> +++ b/tools/testing/memblock/internal.h
> @@ -9,6 +9,10 @@
> static int memblock_debug = 1;
> #endif
>
> +#define pr_warn_ratelimited(fmt, ...) printf(fmt, ##__VA_ARGS__)
> +
> +bool mirrored_kernelcore = false;
> +
> struct page {};
>
> void memblock_free_pages(struct page *page, unsigned long pfn,
> --
> 1.8.3.1
>
--
Sincerely yours,
Mike.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-29 7:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-27 10:07 [PATCH v4] memblock tests: fix compilation errors Liu Xinpeng
2022-07-29 7:27 ` Mike Rapoport
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).