* [PATCH linux-next] spi: pxa2xx: Remove the unneeded result variable
@ 2022-08-25 7:28 cgel.zte
2022-08-25 13:09 ` Mark Brown
2022-08-25 15:28 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: cgel.zte @ 2022-08-25 7:28 UTC (permalink / raw)
To: broonie
Cc: daniel, haojian.zhuang, robert.jarzmik, linux-arm-kernel,
linux-spi, linux-kernel, ye xingchen, Zeal Robot
From: ye xingchen <ye.xingchen@zte.com.cn>
Return the value clk_prepare_enable() directly instead of storing it in
another redundant variable.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
---
drivers/spi/spi-pxa2xx.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/spi/spi-pxa2xx.c b/drivers/spi/spi-pxa2xx.c
index 838d12e65144..986ffc4bf1ed 100644
--- a/drivers/spi/spi-pxa2xx.c
+++ b/drivers/spi/spi-pxa2xx.c
@@ -1873,10 +1873,8 @@ static int pxa2xx_spi_runtime_suspend(struct device *dev)
static int pxa2xx_spi_runtime_resume(struct device *dev)
{
struct driver_data *drv_data = dev_get_drvdata(dev);
- int status;
- status = clk_prepare_enable(drv_data->ssp->clk);
- return status;
+ return clk_prepare_enable(drv_data->ssp->clk);
}
#endif
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH linux-next] spi: pxa2xx: Remove the unneeded result variable
2022-08-25 7:28 [PATCH linux-next] spi: pxa2xx: Remove the unneeded result variable cgel.zte
@ 2022-08-25 13:09 ` Mark Brown
2022-08-25 15:28 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2022-08-25 13:09 UTC (permalink / raw)
To: cgel.zte
Cc: daniel, linux-kernel, haojian.zhuang, robert.jarzmik, Zeal Robot,
linux-arm-kernel, ye xingchen, linux-spi
On Thu, 25 Aug 2022 07:28:28 +0000, cgel.zte@gmail.com wrote:
> From: ye xingchen <ye.xingchen@zte.com.cn>
>
> Return the value clk_prepare_enable() directly instead of storing it in
> another redundant variable.
>
>
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
Thanks!
[1/1] spi: pxa2xx: Remove the unneeded result variable
commit: d294e99cdc823f368530b8169e33a599fa2a1afe
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH linux-next] spi: pxa2xx: Remove the unneeded result variable
2022-08-25 7:28 [PATCH linux-next] spi: pxa2xx: Remove the unneeded result variable cgel.zte
2022-08-25 13:09 ` Mark Brown
@ 2022-08-25 15:28 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2022-08-25 15:28 UTC (permalink / raw)
To: cgel.zte
Cc: linux-kernel, linux-spi, haojian.zhuang, robert.jarzmik, daniel,
zealci, linux-arm-kernel, ye.xingchen
On Thu, 25 Aug 2022 07:28:28 +0000, cgel.zte@gmail.com wrote:
> From: ye xingchen <ye.xingchen@zte.com.cn>
>
> Return the value clk_prepare_enable() directly instead of storing it in
> another redundant variable.
>
>
Applied to
broonie/spi.git for-next
Thanks!
[1/1] spi: pxa2xx: Remove the unneeded result variable
commit: d294e99cdc823f368530b8169e33a599fa2a1afe
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-08-25 15:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-25 7:28 [PATCH linux-next] spi: pxa2xx: Remove the unneeded result variable cgel.zte
2022-08-25 13:09 ` Mark Brown
2022-08-25 15:28 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).