* [PATCH] pwm: mtk-disp: Fix the parameters calculated by the enabled flag of disp_pwm.
@ 2022-08-29 4:04 xinlei.lee
2022-08-30 10:36 ` AngeloGioacchino Del Regno
2022-09-13 9:05 ` Uwe Kleine-König
0 siblings, 2 replies; 3+ messages in thread
From: xinlei.lee @ 2022-08-29 4:04 UTC (permalink / raw)
To: thierry.reding, u.kleine-koenig, matthias.bgg, jitao.shi
Cc: linux-pwm, linux-arm-kernel, linux-mediatek, linux-kernel,
Project_Global_Chrome_Upstream_Group, xinlei lee
From: xinlei lee <xinlei.lee@mediatek.com>
In the original mtk_disp_pwm_get_state() function, the result of reading
con0 & BIT(0) is enabled as disp_pwm.
In order to conform to the register table, we should use the disp_pwm
base address as the enabled judgment.
Fixes: 3f2b16734914 ("pwm: mtk-disp: Implement atomic API .get_state()")
Signed-off-by: xinlei lee <xinlei.lee@mediatek.com>
Reviewed-by: Miles Chen <miles.chen@mediatek.com>
---
Base on the branch of Linux-next/master.
Split from series [1].
[1] https://patchwork.kernel.org/project/linux-mediatek/cover/1661239875-19841-1-git-send-email-xinlei.lee@mediatek.com/
---
---
drivers/pwm/pwm-mtk-disp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pwm/pwm-mtk-disp.c b/drivers/pwm/pwm-mtk-disp.c
index c605013..50425cd 100644
--- a/drivers/pwm/pwm-mtk-disp.c
+++ b/drivers/pwm/pwm-mtk-disp.c
@@ -197,7 +197,7 @@ static void mtk_disp_pwm_get_state(struct pwm_chip *chip,
rate = clk_get_rate(mdp->clk_main);
con0 = readl(mdp->base + mdp->data->con0);
con1 = readl(mdp->base + mdp->data->con1);
- state->enabled = !!(con0 & BIT(0));
+ state->enabled = !!(readl(mdp->base) & BIT(0));
clk_div = FIELD_GET(PWM_CLKDIV_MASK, con0);
period = FIELD_GET(PWM_PERIOD_MASK, con1);
/*
--
2.6.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] pwm: mtk-disp: Fix the parameters calculated by the enabled flag of disp_pwm.
2022-08-29 4:04 [PATCH] pwm: mtk-disp: Fix the parameters calculated by the enabled flag of disp_pwm xinlei.lee
@ 2022-08-30 10:36 ` AngeloGioacchino Del Regno
2022-09-13 9:05 ` Uwe Kleine-König
1 sibling, 0 replies; 3+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-08-30 10:36 UTC (permalink / raw)
To: xinlei.lee, thierry.reding, u.kleine-koenig, matthias.bgg, jitao.shi
Cc: linux-pwm, linux-arm-kernel, linux-mediatek, linux-kernel,
Project_Global_Chrome_Upstream_Group
Il 29/08/22 06:04, xinlei.lee@mediatek.com ha scritto:
> From: xinlei lee <xinlei.lee@mediatek.com>
>
> In the original mtk_disp_pwm_get_state() function, the result of reading
> con0 & BIT(0) is enabled as disp_pwm.
> In order to conform to the register table, we should use the disp_pwm
> base address as the enabled judgment.
>
> Fixes: 3f2b16734914 ("pwm: mtk-disp: Implement atomic API .get_state()")
>
> Signed-off-by: xinlei lee <xinlei.lee@mediatek.com>
> Reviewed-by: Miles Chen <miles.chen@mediatek.com>
This fix is valid for all MediaTek SoCs that are currently supported in
pwm-mtk-disp (and some others that aren't supported yet).
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pwm: mtk-disp: Fix the parameters calculated by the enabled flag of disp_pwm.
2022-08-29 4:04 [PATCH] pwm: mtk-disp: Fix the parameters calculated by the enabled flag of disp_pwm xinlei.lee
2022-08-30 10:36 ` AngeloGioacchino Del Regno
@ 2022-09-13 9:05 ` Uwe Kleine-König
1 sibling, 0 replies; 3+ messages in thread
From: Uwe Kleine-König @ 2022-09-13 9:05 UTC (permalink / raw)
To: xinlei.lee
Cc: thierry.reding, matthias.bgg, jitao.shi, linux-pwm,
linux-arm-kernel, linux-mediatek, linux-kernel,
Project_Global_Chrome_Upstream_Group
[-- Attachment #1: Type: text/plain, Size: 2071 bytes --]
Hello,
On Mon, Aug 29, 2022 at 12:04:12PM +0800, xinlei.lee@mediatek.com wrote:
> From: xinlei lee <xinlei.lee@mediatek.com>
>
> In the original mtk_disp_pwm_get_state() function, the result of reading
> con0 & BIT(0) is enabled as disp_pwm.
> In order to conform to the register table, we should use the disp_pwm
> base address as the enabled judgment.
Do you want to say:
The enable bit of the hardware is bit 0 of the DISP_PWM_EN
register at offset 0 for all supported hardwares. Up to now the
bit was wrongly assumed to be in the CON0 register.
?
> Fixes: 3f2b16734914 ("pwm: mtk-disp: Implement atomic API .get_state()")
>
This newline is unusal.
> Signed-off-by: xinlei lee <xinlei.lee@mediatek.com>
> Reviewed-by: Miles Chen <miles.chen@mediatek.com>
> ---
> Base on the branch of Linux-next/master.
> Split from series [1].
> [1] https://patchwork.kernel.org/project/linux-mediatek/cover/1661239875-19841-1-git-send-email-xinlei.lee@mediatek.com/
> ---
> ---
> drivers/pwm/pwm-mtk-disp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pwm/pwm-mtk-disp.c b/drivers/pwm/pwm-mtk-disp.c
> index c605013..50425cd 100644
> --- a/drivers/pwm/pwm-mtk-disp.c
> +++ b/drivers/pwm/pwm-mtk-disp.c
> @@ -197,7 +197,7 @@ static void mtk_disp_pwm_get_state(struct pwm_chip *chip,
> rate = clk_get_rate(mdp->clk_main);
> con0 = readl(mdp->base + mdp->data->con0);
> con1 = readl(mdp->base + mdp->data->con1);
> - state->enabled = !!(con0 & BIT(0));
> + state->enabled = !!(readl(mdp->base) & BIT(0));
I would expect this to better be:
state->enabled = !!(readl(mdp->base + DISP_PWM_EN) & BIT(0));
which is the same for the compiler but a bit more descriptive for the
human reader.
> clk_div = FIELD_GET(PWM_CLKDIV_MASK, con0);
> period = FIELD_GET(PWM_PERIOD_MASK, con1);
> /*
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-13 9:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-29 4:04 [PATCH] pwm: mtk-disp: Fix the parameters calculated by the enabled flag of disp_pwm xinlei.lee
2022-08-30 10:36 ` AngeloGioacchino Del Regno
2022-09-13 9:05 ` Uwe Kleine-König
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).