[PATCH -next] sched/deadline: Move __dl_clear_params out of dl_bw lock

[PATCH -next] sched/deadline: Move __dl_clear_params out of dl_bw lock

[Shang XiaoJing]

As members in sched_dl_entity are independent with dl_bw, move
__dl_clear_params out of dl_bw lock.

Signed-off-by: Shang XiaoJing <shangxiaojing@huawei.com>
---
 kernel/sched/deadline.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
index 58ca9aaa9c44..7b15885c8608 100644
--- a/kernel/sched/deadline.c
+++ b/kernel/sched/deadline.c
@@ -431,8 +431,8 @@ static void task_non_contending(struct task_struct *p)
 				sub_rq_bw(&p->dl, &rq->dl);
 			raw_spin_lock(&dl_b->lock);
 			__dl_sub(dl_b, p->dl.dl_bw, dl_bw_cpus(task_cpu(p)));
-			__dl_clear_params(p);
 			raw_spin_unlock(&dl_b->lock);
+			__dl_clear_params(p);
 		}
 
 		return;
-- 
2.17.1

Re: [PATCH -next] sched/deadline: Move __dl_clear_params out of dl_bw lock

[Daniel Bristot de Oliveira]

On 8/27/22 04:09, Shang XiaoJing wrote:

Why are y'all always setting "-next" to the subject?

> As members in sched_dl_entity are independent with dl_bw, move
> __dl_clear_params out of dl_bw lock.
> 
> Signed-off-by: Shang XiaoJing <shangxiaojing@huawei.com>

Reviewed-by: Daniel Bristot de Oliveira <bristot@kernel.org>

-- Daniel

Re: [PATCH -next] sched/deadline: Move __dl_clear_params out of dl_bw lock

[shangxiaojing]

On 2022/8/29 16:24, Daniel Bristot de Oliveira wrote:
> On 8/27/22 04:09, Shang XiaoJing wrote:
>
> Why are y'all always setting "-next" to the subject?
i heard that "-next" means prefer to merge into linux-next branch first, 
the subsequent patches from me wont set "-next".
>> As members in sched_dl_entity are independent with dl_bw, move
>> __dl_clear_params out of dl_bw lock.
>>
>> Signed-off-by: Shang XiaoJing <shangxiaojing@huawei.com>
> Reviewed-by: Daniel Bristot de Oliveira <bristot@kernel.org>
>
> -- Daniel

Thanks,

Shang XiaoJing

[tip: sched/core] sched/deadline: Move __dl_clear_params out of dl_bw lock

[tip-bot2 for Shang XiaoJing]

The following commit has been merged into the sched/core branch of tip:

Commit-ID:     33f93525799fa3c841b2ba93a56b2bb32ab11dc9
Gitweb:        https://git.kernel.org/tip/33f93525799fa3c841b2ba93a56b2bb32ab11dc9
Author:        Shang XiaoJing <shangxiaojing@huawei.com>
AuthorDate:    Sat, 27 Aug 2022 10:09:11 +08:00
Committer:     Peter Zijlstra <peterz@infradead.org>
CommitterDate: Thu, 01 Sep 2022 11:19:55 +02:00

sched/deadline: Move __dl_clear_params out of dl_bw lock

As members in sched_dl_entity are independent with dl_bw, move
__dl_clear_params out of dl_bw lock.

Signed-off-by: Shang XiaoJing <shangxiaojing@huawei.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Daniel Bristot de Oliveira <bristot@kernel.org>
Link: https://lore.kernel.org/r/20220827020911.30641-1-shangxiaojing@huawei.com
---
 kernel/sched/deadline.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
index 3bf4b12..d0fe6a2 100644
--- a/kernel/sched/deadline.c
+++ b/kernel/sched/deadline.c
@@ -431,8 +431,8 @@ static void task_non_contending(struct task_struct *p)
 				sub_rq_bw(&p->dl, &rq->dl);
 			raw_spin_lock(&dl_b->lock);
 			__dl_sub(dl_b, p->dl.dl_bw, dl_bw_cpus(task_cpu(p)));
-			__dl_clear_params(p);
 			raw_spin_unlock(&dl_b->lock);
+			__dl_clear_params(p);
 		}
 
 		return;