* [PATCH v3 linux-next] wifi: brcmfmac: remove redundant variable err
@ 2022-08-31 13:22 cgel.zte
2022-09-07 8:01 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: cgel.zte @ 2022-08-31 13:22 UTC (permalink / raw)
To: aspriel, franky.lin, hante.meuleman
Cc: kvalo, davem, edumazet, kuba, pabeni, johannes.berg, alsi,
loic.poulain, quic_vjakkam, cui.jinpeng2, smoch, hdegoede,
prestwoj, linux-wireless, brcm80211-dev-list.pdl,
SHA-cyfmac-dev-list, netdev, linux-kernel, Zeal Robot
From: Jinpeng Cui <cui.jinpeng2@zte.com.cn>
Return value from brcmf_fil_iovar_data_set() and
brcmf_config_ap_mgmt_ie() directly instead of
taking this in another redundant variable.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Jinpeng Cui <cui.jinpeng2@zte.com.cn>
---
.../wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 12 +++---------
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
index 7c72ea26a7d7..938a6ed10275 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
@@ -3988,7 +3988,6 @@ brcmf_update_pmklist(struct brcmf_cfg80211_info *cfg, struct brcmf_if *ifp)
struct brcmf_pmk_list_le *pmk_list;
int i;
u32 npmk;
- s32 err;
pmk_list = &cfg->pmk_list;
npmk = le32_to_cpu(pmk_list->npmk);
@@ -3997,10 +3996,8 @@ brcmf_update_pmklist(struct brcmf_cfg80211_info *cfg, struct brcmf_if *ifp)
for (i = 0; i < npmk; i++)
brcmf_dbg(CONN, "PMK[%d]: %pM\n", i, &pmk_list->pmk[i].bssid);
- err = brcmf_fil_iovar_data_set(ifp, "pmkid_info", pmk_list,
- sizeof(*pmk_list));
-
- return err;
+ return brcmf_fil_iovar_data_set(ifp, "pmkid_info", pmk_list,
+ sizeof(*pmk_list));
}
static s32
@@ -5046,13 +5043,10 @@ brcmf_cfg80211_change_beacon(struct wiphy *wiphy, struct net_device *ndev,
struct cfg80211_beacon_data *info)
{
struct brcmf_if *ifp = netdev_priv(ndev);
- s32 err;
brcmf_dbg(TRACE, "Enter\n");
- err = brcmf_config_ap_mgmt_ie(ifp->vif, info);
-
- return err;
+ return brcmf_config_ap_mgmt_ie(ifp->vif, info);
}
static int
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v3 linux-next] wifi: brcmfmac: remove redundant variable err
2022-08-31 13:22 [PATCH v3 linux-next] wifi: brcmfmac: remove redundant variable err cgel.zte
@ 2022-09-07 8:01 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2022-09-07 8:01 UTC (permalink / raw)
To: cgel.zte
Cc: aspriel, franky.lin, hante.meuleman, davem, edumazet, kuba,
pabeni, johannes.berg, alsi, loic.poulain, quic_vjakkam,
cui.jinpeng2, smoch, hdegoede, prestwoj, linux-wireless,
brcm80211-dev-list.pdl, SHA-cyfmac-dev-list, netdev,
linux-kernel, Zeal Robot
cgel.zte@gmail.com wrote:
> From: Jinpeng Cui <cui.jinpeng2@zte.com.cn>
>
> Return value from brcmf_fil_iovar_data_set() and
> brcmf_config_ap_mgmt_ie() directly instead of
> taking this in another redundant variable.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Jinpeng Cui <cui.jinpeng2@zte.com.cn>
Patch applied to wireless-next.git, thanks.
e56a770883b2 wifi: brcmfmac: remove redundant variable err
--
https://patchwork.kernel.org/project/linux-wireless/patch/20220831132254.303697-1-cui.jinpeng2@zte.com.cn/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-07 8:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-31 13:22 [PATCH v3 linux-next] wifi: brcmfmac: remove redundant variable err cgel.zte
2022-09-07 8:01 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).