* [PATCH net V5] eth: lan743x: reject extts for non-pci11x1x devices
@ 2022-09-30 9:27 Raju Lakkaraju
2022-09-30 11:36 ` Horatiu Vultur
2022-10-03 11:50 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Raju Lakkaraju @ 2022-09-30 9:27 UTC (permalink / raw)
To: netdev
Cc: davem, kuba, linux-kernel, bryan.whitehead, edumazet, pabeni,
UNGLinuxDriver
Remove PTP_PF_EXTTS support for non-PCI11x1x devices since they do not support
the PTP-IO Input event triggered timestamping mechanisms added
Fixes: 60942c397af6 ("net: lan743x: Add support for PTP-IO Event Input External Timestamp (extts)")
Signed-off-by: Raju Lakkaraju <Raju.Lakkaraju@microchip.com>
---
Changes:
========
V4 -> V5:
- Remove the Reviewed-by tag added by me
- Correct the Fixes tag subject line
V3 -> V4:
- Fix the Fixes tag line split
V2 -> V3:
- Correct the Fixes tag
V1 -> V2:
- Repost against net with a Fixes tag
drivers/net/ethernet/microchip/lan743x_ptp.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/net/ethernet/microchip/lan743x_ptp.c b/drivers/net/ethernet/microchip/lan743x_ptp.c
index 6a11e2ceb013..da3ea905adbb 100644
--- a/drivers/net/ethernet/microchip/lan743x_ptp.c
+++ b/drivers/net/ethernet/microchip/lan743x_ptp.c
@@ -1049,6 +1049,10 @@ static int lan743x_ptpci_verify_pin_config(struct ptp_clock_info *ptp,
enum ptp_pin_function func,
unsigned int chan)
{
+ struct lan743x_ptp *lan_ptp =
+ container_of(ptp, struct lan743x_ptp, ptp_clock_info);
+ struct lan743x_adapter *adapter =
+ container_of(lan_ptp, struct lan743x_adapter, ptp);
int result = 0;
/* Confirm the requested function is supported. Parameter
@@ -1057,7 +1061,10 @@ static int lan743x_ptpci_verify_pin_config(struct ptp_clock_info *ptp,
switch (func) {
case PTP_PF_NONE:
case PTP_PF_PEROUT:
+ break;
case PTP_PF_EXTTS:
+ if (!adapter->is_pci11x1x)
+ result = -1;
break;
case PTP_PF_PHYSYNC:
default:
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net V5] eth: lan743x: reject extts for non-pci11x1x devices
2022-09-30 9:27 [PATCH net V5] eth: lan743x: reject extts for non-pci11x1x devices Raju Lakkaraju
@ 2022-09-30 11:36 ` Horatiu Vultur
2022-10-03 11:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Horatiu Vultur @ 2022-09-30 11:36 UTC (permalink / raw)
To: Raju Lakkaraju
Cc: netdev, davem, kuba, linux-kernel, bryan.whitehead, edumazet,
pabeni, UNGLinuxDriver
The 09/30/2022 14:57, Raju Lakkaraju wrote:
> Remove PTP_PF_EXTTS support for non-PCI11x1x devices since they do not support
> the PTP-IO Input event triggered timestamping mechanisms added
>
> Fixes: 60942c397af6 ("net: lan743x: Add support for PTP-IO Event Input External Timestamp (extts)")
> Signed-off-by: Raju Lakkaraju <Raju.Lakkaraju@microchip.com>
Reviewed-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> ---
> Changes:
> ========
> V4 -> V5:
> - Remove the Reviewed-by tag added by me
> - Correct the Fixes tag subject line
>
> V3 -> V4:
> - Fix the Fixes tag line split
>
> V2 -> V3:
> - Correct the Fixes tag
>
> V1 -> V2:
> - Repost against net with a Fixes tag
>
> drivers/net/ethernet/microchip/lan743x_ptp.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/net/ethernet/microchip/lan743x_ptp.c b/drivers/net/ethernet/microchip/lan743x_ptp.c
> index 6a11e2ceb013..da3ea905adbb 100644
> --- a/drivers/net/ethernet/microchip/lan743x_ptp.c
> +++ b/drivers/net/ethernet/microchip/lan743x_ptp.c
> @@ -1049,6 +1049,10 @@ static int lan743x_ptpci_verify_pin_config(struct ptp_clock_info *ptp,
> enum ptp_pin_function func,
> unsigned int chan)
> {
> + struct lan743x_ptp *lan_ptp =
> + container_of(ptp, struct lan743x_ptp, ptp_clock_info);
> + struct lan743x_adapter *adapter =
> + container_of(lan_ptp, struct lan743x_adapter, ptp);
> int result = 0;
>
> /* Confirm the requested function is supported. Parameter
> @@ -1057,7 +1061,10 @@ static int lan743x_ptpci_verify_pin_config(struct ptp_clock_info *ptp,
> switch (func) {
> case PTP_PF_NONE:
> case PTP_PF_PEROUT:
> + break;
> case PTP_PF_EXTTS:
> + if (!adapter->is_pci11x1x)
> + result = -1;
> break;
> case PTP_PF_PHYSYNC:
> default:
> --
> 2.25.1
>
--
/Horatiu
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net V5] eth: lan743x: reject extts for non-pci11x1x devices
2022-09-30 9:27 [PATCH net V5] eth: lan743x: reject extts for non-pci11x1x devices Raju Lakkaraju
2022-09-30 11:36 ` Horatiu Vultur
@ 2022-10-03 11:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-10-03 11:50 UTC (permalink / raw)
To: Raju Lakkaraju
Cc: netdev, davem, kuba, linux-kernel, bryan.whitehead, edumazet,
pabeni, UNGLinuxDriver
Hello:
This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:
On Fri, 30 Sep 2022 14:57:40 +0530 you wrote:
> Remove PTP_PF_EXTTS support for non-PCI11x1x devices since they do not support
> the PTP-IO Input event triggered timestamping mechanisms added
>
> Fixes: 60942c397af6 ("net: lan743x: Add support for PTP-IO Event Input External Timestamp (extts)")
> Signed-off-by: Raju Lakkaraju <Raju.Lakkaraju@microchip.com>
> ---
> Changes:
> ========
> V4 -> V5:
> - Remove the Reviewed-by tag added by me
> - Correct the Fixes tag subject line
>
> [...]
Here is the summary with links:
- [net,V5] eth: lan743x: reject extts for non-pci11x1x devices
https://git.kernel.org/netdev/net/c/cb4b12071a4b
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-03 11:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-30 9:27 [PATCH net V5] eth: lan743x: reject extts for non-pci11x1x devices Raju Lakkaraju
2022-09-30 11:36 ` Horatiu Vultur
2022-10-03 11:50 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).