linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drivers/perf: ALIBABA_UNCORE_DRW_PMU should depend on ACPI
@ 2022-09-27 13:37 Geert Uytterhoeven
  2022-10-07 13:17 ` Will Deacon
  2022-10-07 16:43 ` Catalin Marinas
  0 siblings, 2 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2022-09-27 13:37 UTC (permalink / raw)
  To: Will Deacon, Mark Rutland, Neng Chen, Jonathan Cameron,
	Baolin Wang, Hongbo Yao
  Cc: linux-arm-kernel, linux-kernel, Geert Uytterhoeven

The Alibaba T-Head Yitian 710 DDR Sub-system Driveway PMU driver relies
solely on ACPI for matching.  Hence add a dependency on ACPI, to prevent
asking the user about this driver when configuring a kernel without ACPI
support.

Fixes: cf7b61073e4526ca ("drivers/perf: add DDR Sub-System Driveway PMU driver for Yitian 710 SoC")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/perf/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/perf/Kconfig b/drivers/perf/Kconfig
index 44c07ea487f4482a..341010f20b777905 100644
--- a/drivers/perf/Kconfig
+++ b/drivers/perf/Kconfig
@@ -185,7 +185,7 @@ config APPLE_M1_CPU_PMU
 
 config ALIBABA_UNCORE_DRW_PMU
 	tristate "Alibaba T-Head Yitian 710 DDR Sub-system Driveway PMU driver"
-	depends on ARM64 || COMPILE_TEST
+	depends on (ARM64 && ACPI) || COMPILE_TEST
 	help
 	  Support for Driveway PMU events monitoring on Yitian 710 DDR
 	  Sub-system.
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] drivers/perf: ALIBABA_UNCORE_DRW_PMU should depend on ACPI
  2022-09-27 13:37 [PATCH] drivers/perf: ALIBABA_UNCORE_DRW_PMU should depend on ACPI Geert Uytterhoeven
@ 2022-10-07 13:17 ` Will Deacon
  2022-10-07 16:43 ` Catalin Marinas
  1 sibling, 0 replies; 3+ messages in thread
From: Will Deacon @ 2022-10-07 13:17 UTC (permalink / raw)
  To: Geert Uytterhoeven, catalin.marinas
  Cc: Mark Rutland, Neng Chen, Jonathan Cameron, Baolin Wang,
	Hongbo Yao, linux-arm-kernel, linux-kernel

On Tue, Sep 27, 2022 at 03:37:16PM +0200, Geert Uytterhoeven wrote:
> The Alibaba T-Head Yitian 710 DDR Sub-system Driveway PMU driver relies
> solely on ACPI for matching.  Hence add a dependency on ACPI, to prevent
> asking the user about this driver when configuring a kernel without ACPI
> support.
> 
> Fixes: cf7b61073e4526ca ("drivers/perf: add DDR Sub-System Driveway PMU driver for Yitian 710 SoC")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  drivers/perf/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/perf/Kconfig b/drivers/perf/Kconfig
> index 44c07ea487f4482a..341010f20b777905 100644
> --- a/drivers/perf/Kconfig
> +++ b/drivers/perf/Kconfig
> @@ -185,7 +185,7 @@ config APPLE_M1_CPU_PMU
>  
>  config ALIBABA_UNCORE_DRW_PMU
>  	tristate "Alibaba T-Head Yitian 710 DDR Sub-system Driveway PMU driver"
> -	depends on ARM64 || COMPILE_TEST
> +	depends on (ARM64 && ACPI) || COMPILE_TEST
>  	help
>  	  Support for Driveway PMU events monitoring on Yitian 710 DDR
>  	  Sub-system.

Acked-by: Will Deacon <will@kernel.org>

Another one for Catalin to queue as a fix.

Will

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] drivers/perf: ALIBABA_UNCORE_DRW_PMU should depend on ACPI
  2022-09-27 13:37 [PATCH] drivers/perf: ALIBABA_UNCORE_DRW_PMU should depend on ACPI Geert Uytterhoeven
  2022-10-07 13:17 ` Will Deacon
@ 2022-10-07 16:43 ` Catalin Marinas
  1 sibling, 0 replies; 3+ messages in thread
From: Catalin Marinas @ 2022-10-07 16:43 UTC (permalink / raw)
  To: Geert Uytterhoeven, Jonathan Cameron, Mark Rutland, Neng Chen,
	Will Deacon, Hongbo Yao, Baolin Wang
  Cc: linux-kernel, linux-arm-kernel

On Tue, 27 Sep 2022 15:37:16 +0200, Geert Uytterhoeven wrote:
> The Alibaba T-Head Yitian 710 DDR Sub-system Driveway PMU driver relies
> solely on ACPI for matching.  Hence add a dependency on ACPI, to prevent
> asking the user about this driver when configuring a kernel without ACPI
> support.
> 
> 

Applied to arm64 (for-next/core), thanks!

[1/1] drivers/perf: ALIBABA_UNCORE_DRW_PMU should depend on ACPI
      https://git.kernel.org/arm64/c/e08d07dd9f80

-- 
Catalin


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-10-07 16:43 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-27 13:37 [PATCH] drivers/perf: ALIBABA_UNCORE_DRW_PMU should depend on ACPI Geert Uytterhoeven
2022-10-07 13:17 ` Will Deacon
2022-10-07 16:43 ` Catalin Marinas

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).