* [PATCH] ARM: dts: qcom: pmx65: use node name "gpio" for spmi-gpio
@ 2022-09-25 19:06 Luca Weiss
2022-09-26 8:19 ` Neil Armstrong
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Luca Weiss @ 2022-09-25 19:06 UTC (permalink / raw)
To: linux-arm-msm
Cc: ~postmarketos/upstreaming, phone-devel, Luca Weiss, Andy Gross,
Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
devicetree, linux-kernel
All other usages of qcom,spmi-gpio use the gpio@ node name, and this is
also validated by the dt binding check. Fix it.
Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
---
arch/arm/boot/dts/qcom-pmx65.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/qcom-pmx65.dtsi b/arch/arm/boot/dts/qcom-pmx65.dtsi
index abf229a8b75a..1c7fdf59c1f5 100644
--- a/arch/arm/boot/dts/qcom-pmx65.dtsi
+++ b/arch/arm/boot/dts/qcom-pmx65.dtsi
@@ -20,7 +20,7 @@ pmx65_temp: temp-alarm@a00 {
#thermal-sensor-cells = <0>;
};
- pmx65_gpios: pinctrl@8800 {
+ pmx65_gpios: gpio@8800 {
compatible = "qcom,pmx65-gpio", "qcom,spmi-gpio";
reg = <0x8800>;
gpio-controller;
--
2.37.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: qcom: pmx65: use node name "gpio" for spmi-gpio
2022-09-25 19:06 [PATCH] ARM: dts: qcom: pmx65: use node name "gpio" for spmi-gpio Luca Weiss
@ 2022-09-26 8:19 ` Neil Armstrong
2022-09-26 8:44 ` Krzysztof Kozlowski
2022-10-18 3:05 ` Bjorn Andersson
2 siblings, 0 replies; 4+ messages in thread
From: Neil Armstrong @ 2022-09-26 8:19 UTC (permalink / raw)
To: Luca Weiss, linux-arm-msm
Cc: ~postmarketos/upstreaming, phone-devel, Andy Gross,
Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
devicetree, linux-kernel
On 25/09/2022 21:06, Luca Weiss wrote:
> All other usages of qcom,spmi-gpio use the gpio@ node name, and this is
> also validated by the dt binding check. Fix it.
>
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> ---
> arch/arm/boot/dts/qcom-pmx65.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/qcom-pmx65.dtsi b/arch/arm/boot/dts/qcom-pmx65.dtsi
> index abf229a8b75a..1c7fdf59c1f5 100644
> --- a/arch/arm/boot/dts/qcom-pmx65.dtsi
> +++ b/arch/arm/boot/dts/qcom-pmx65.dtsi
> @@ -20,7 +20,7 @@ pmx65_temp: temp-alarm@a00 {
> #thermal-sensor-cells = <0>;
> };
>
> - pmx65_gpios: pinctrl@8800 {
> + pmx65_gpios: gpio@8800 {
> compatible = "qcom,pmx65-gpio", "qcom,spmi-gpio";
> reg = <0x8800>;
> gpio-controller;
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: qcom: pmx65: use node name "gpio" for spmi-gpio
2022-09-25 19:06 [PATCH] ARM: dts: qcom: pmx65: use node name "gpio" for spmi-gpio Luca Weiss
2022-09-26 8:19 ` Neil Armstrong
@ 2022-09-26 8:44 ` Krzysztof Kozlowski
2022-10-18 3:05 ` Bjorn Andersson
2 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-26 8:44 UTC (permalink / raw)
To: Luca Weiss, linux-arm-msm
Cc: ~postmarketos/upstreaming, phone-devel, Andy Gross,
Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
devicetree, linux-kernel
On 25/09/2022 21:06, Luca Weiss wrote:
> All other usages of qcom,spmi-gpio use the gpio@ node name, and this is
> also validated by the dt binding check. Fix it.
>
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: qcom: pmx65: use node name "gpio" for spmi-gpio
2022-09-25 19:06 [PATCH] ARM: dts: qcom: pmx65: use node name "gpio" for spmi-gpio Luca Weiss
2022-09-26 8:19 ` Neil Armstrong
2022-09-26 8:44 ` Krzysztof Kozlowski
@ 2022-10-18 3:05 ` Bjorn Andersson
2 siblings, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2022-10-18 3:05 UTC (permalink / raw)
To: luca, linux-arm-msm
Cc: phone-devel, devicetree, linux-kernel, robh+dt, agross,
Krzysztof Kozlowski, ~postmarketos/upstreaming, Konrad Dybcio
On Sun, 25 Sep 2022 21:06:21 +0200, Luca Weiss wrote:
> All other usages of qcom,spmi-gpio use the gpio@ node name, and this is
> also validated by the dt binding check. Fix it.
>
>
Applied, thanks!
[1/1] ARM: dts: qcom: pmx65: use node name "gpio" for spmi-gpio
commit: da76bc88bde1dc3f547078282e30a88c371699ad
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-10-18 3:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-25 19:06 [PATCH] ARM: dts: qcom: pmx65: use node name "gpio" for spmi-gpio Luca Weiss
2022-09-26 8:19 ` Neil Armstrong
2022-09-26 8:44 ` Krzysztof Kozlowski
2022-10-18 3:05 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).