* [PATCH] ARM: dts: qcom: msm8974-sony-*: fix multi-led node name
@ 2022-09-25 17:56 Luca Weiss
2022-09-26 8:50 ` Neil Armstrong
2022-10-18 3:05 ` Bjorn Andersson
0 siblings, 2 replies; 3+ messages in thread
From: Luca Weiss @ 2022-09-25 17:56 UTC (permalink / raw)
To: linux-arm-msm
Cc: ~postmarketos/upstreaming, phone-devel, Luca Weiss, Andy Gross,
Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
devicetree, linux-kernel
The name rgb-led is not allowed, multi-led is supposed to be used.
<snip>/arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine-amami.dtb: pm8941@1: pwm: 'rgb-led' does not match any of the regexes: '^led@[0-9a-f]$', 'pinctrl-[0-9]+'
From schema: <snip>/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
---
arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi | 2 +-
.../arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi b/arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi
index 5a70683d9103..c1d97190ea71 100644
--- a/arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi
+++ b/arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi
@@ -178,7 +178,7 @@ &pm8941_lpg {
qcom,power-source = <1>;
- rgb-led {
+ multi-led {
color = <LED_COLOR_ID_RGB>;
function = LED_FUNCTION_STATUS;
diff --git a/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts b/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts
index 85348562e861..94daa1a3240a 100644
--- a/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts
+++ b/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts
@@ -295,7 +295,7 @@ &pm8941_lpg {
qcom,power-source = <1>;
- rgb-led {
+ multi-led {
color = <LED_COLOR_ID_RGB>;
function = LED_FUNCTION_STATUS;
--
2.37.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: dts: qcom: msm8974-sony-*: fix multi-led node name
2022-09-25 17:56 [PATCH] ARM: dts: qcom: msm8974-sony-*: fix multi-led node name Luca Weiss
@ 2022-09-26 8:50 ` Neil Armstrong
2022-10-18 3:05 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Neil Armstrong @ 2022-09-26 8:50 UTC (permalink / raw)
To: Luca Weiss, linux-arm-msm
Cc: ~postmarketos/upstreaming, phone-devel, Andy Gross,
Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
devicetree, linux-kernel
On 25/09/2022 19:56, Luca Weiss wrote:
> The name rgb-led is not allowed, multi-led is supposed to be used.
>
> <snip>/arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine-amami.dtb: pm8941@1: pwm: 'rgb-led' does not match any of the regexes: '^led@[0-9a-f]$', 'pinctrl-[0-9]+'
> From schema: <snip>/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
>
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> ---
> arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi | 2 +-
> .../arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi b/arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi
> index 5a70683d9103..c1d97190ea71 100644
> --- a/arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi
> +++ b/arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi
> @@ -178,7 +178,7 @@ &pm8941_lpg {
>
> qcom,power-source = <1>;
>
> - rgb-led {
> + multi-led {
> color = <LED_COLOR_ID_RGB>;
> function = LED_FUNCTION_STATUS;
>
> diff --git a/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts b/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts
> index 85348562e861..94daa1a3240a 100644
> --- a/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts
> +++ b/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts
> @@ -295,7 +295,7 @@ &pm8941_lpg {
>
> qcom,power-source = <1>;
>
> - rgb-led {
> + multi-led {
> color = <LED_COLOR_ID_RGB>;
> function = LED_FUNCTION_STATUS;
>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: dts: qcom: msm8974-sony-*: fix multi-led node name
2022-09-25 17:56 [PATCH] ARM: dts: qcom: msm8974-sony-*: fix multi-led node name Luca Weiss
2022-09-26 8:50 ` Neil Armstrong
@ 2022-10-18 3:05 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2022-10-18 3:05 UTC (permalink / raw)
To: luca, linux-arm-msm
Cc: phone-devel, devicetree, linux-kernel, robh+dt, agross,
Krzysztof Kozlowski, ~postmarketos/upstreaming, Konrad Dybcio
On Sun, 25 Sep 2022 19:56:30 +0200, Luca Weiss wrote:
> The name rgb-led is not allowed, multi-led is supposed to be used.
>
> <snip>/arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine-amami.dtb: pm8941@1: pwm: 'rgb-led' does not match any of the regexes: '^led@[0-9a-f]$', 'pinctrl-[0-9]+'
> From schema: <snip>/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
>
>
Applied, thanks!
[1/1] ARM: dts: qcom: msm8974-sony-*: fix multi-led node name
commit: 5da0f6fedb18d447cbe6d8aa5be33291bce1e7ba
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-18 3:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-25 17:56 [PATCH] ARM: dts: qcom: msm8974-sony-*: fix multi-led node name Luca Weiss
2022-09-26 8:50 ` Neil Armstrong
2022-10-18 3:05 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).