* [PATCH] ASoC: dt-bindings: mt8192-mt6359: Set maxItems, not type, for sound-dai
@ 2022-10-24 23:06 Nícolas F. R. A. Prado
2022-10-26 1:09 ` Rob Herring
0 siblings, 1 reply; 2+ messages in thread
From: Nícolas F. R. A. Prado @ 2022-10-24 23:06 UTC (permalink / raw)
To: Mark Brown
Cc: AngeloGioacchino Del Regno, kernel, Nícolas F. R. A. Prado,
Jiaxin Yu, Krzysztof Kozlowski, Liam Girdwood, Matthias Brugger,
Rob Herring, Shane Chien, alsa-devel, devicetree,
linux-arm-kernel, linux-kernel, linux-mediatek
sound-dai is a standard property whose type is already set to
phandle-array by sound-dai.yaml, so there's no need to set it (and
wrongly so for headset-codec) in this binding. What should be set
however is the maximum number of items, which for headset-codec should
be 1.
Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
---
.../devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml b/Documentation/devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml
index 478be7e3fa29..c6e614c1c30b 100644
--- a/Documentation/devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml
+++ b/Documentation/devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml
@@ -34,7 +34,7 @@ properties:
properties:
sound-dai:
- $ref: /schemas/types.yaml#/definitions/phandle
+ maxItems: 1
required:
- sound-dai
@@ -48,7 +48,6 @@ properties:
maxItems: 2
items:
maxItems: 1
- $ref: /schemas/types.yaml#/definitions/phandle-array
required:
- sound-dai
--
2.38.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] ASoC: dt-bindings: mt8192-mt6359: Set maxItems, not type, for sound-dai
2022-10-24 23:06 [PATCH] ASoC: dt-bindings: mt8192-mt6359: Set maxItems, not type, for sound-dai Nícolas F. R. A. Prado
@ 2022-10-26 1:09 ` Rob Herring
0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring @ 2022-10-26 1:09 UTC (permalink / raw)
To: Nícolas F. R. A. Prado
Cc: Mark Brown, alsa-devel, kernel, Rob Herring, Jiaxin Yu,
Liam Girdwood, devicetree, linux-kernel, Matthias Brugger,
Shane Chien, linux-mediatek, linux-arm-kernel,
AngeloGioacchino Del Regno, Krzysztof Kozlowski
On Mon, 24 Oct 2022 19:06:57 -0400, Nícolas F. R. A. Prado wrote:
> sound-dai is a standard property whose type is already set to
> phandle-array by sound-dai.yaml, so there's no need to set it (and
> wrongly so for headset-codec) in this binding. What should be set
> however is the maximum number of items, which for headset-codec should
> be 1.
>
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
>
> ---
>
> .../devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-26 1:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-24 23:06 [PATCH] ASoC: dt-bindings: mt8192-mt6359: Set maxItems, not type, for sound-dai Nícolas F. R. A. Prado
2022-10-26 1:09 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).