* Re: [PATCH 2/2] dt-bindings: thermal: mediatek: add compatible string for MT7986 SoC
@ 2022-11-02 16:37 Rob Herring
0 siblings, 0 replies; 7+ messages in thread
From: Rob Herring @ 2022-11-02 16:37 UTC (permalink / raw)
To: Daniel Golle
Cc: Krzysztof Kozlowski, Amit Kucheria, linux-kernel, devicetree,
linux-mediatek, Daniel Lezcano, Rafael J. Wysocki,
Matthias Brugger, linux-pm, linux-arm-kernel, Zhang Rui
On Mon, 31 Oct 2022 22:16:53 +0000, Daniel Golle wrote:
> Add compatible string 'mediatek,mt7986-thermal' for V3 thermal unit
> found in MT7981 and MT7986 SoCs.
>
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>
> ---
> Documentation/devicetree/bindings/thermal/mediatek-thermal.txt | 1 +
> 1 file changed, 1 insertion(+)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] dt-bindings: thermal: mediatek: add compatible string for MT7986 SoC
2022-11-30 12:09 ` Daniel Golle
@ 2022-11-30 12:27 ` Krzysztof Kozlowski
0 siblings, 0 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-30 12:27 UTC (permalink / raw)
To: Daniel Golle
Cc: devicetree, linux-pm, linux-arm-kernel, linux-mediatek,
linux-kernel, Rafael J. Wysocki, Daniel Lezcano, Amit Kucheria,
Zhang Rui, Matthias Brugger, Krzysztof Kozlowski
On 30/11/2022 13:09, Daniel Golle wrote:
> On Wed, Nov 02, 2022 at 04:43:35PM -0400, Krzysztof Kozlowski wrote:
>> On 31/10/2022 18:16, Daniel Golle wrote:
>>> Add compatible string 'mediatek,mt7986-thermal' for V3 thermal unit
>>> found in MT7981 and MT7986 SoCs.
>>>
>>> Signed-off-by: Daniel Golle <daniel@makrotopia.org>
>>> ---
>>> Documentation/devicetree/bindings/thermal/mediatek-thermal.txt | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
>>> index 5c7e7bdd029abf..efc16ab5b22b5d 100644
>>> --- a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
>>> +++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
>>> @@ -13,6 +13,7 @@ Required properties:
>>> - "mediatek,mt2701-thermal" : For MT2701 family of SoCs
>>> - "mediatek,mt2712-thermal" : For MT2712 family of SoCs
>>> - "mediatek,mt7622-thermal" : For MT7622 SoC
>>> + - "mediatek,mt7986-thermal" : For MT7981 and MT7986 SoC
>>
>> Then recommended is to have specific compatible followed by fallback (so
>> 7986 followed by 7981)
>
> I'm a bit confused about the order you are suggesting. It may seem
> counter-intuitive, but MT7986 was released before MT7981, the thermal
> units found in both SoCs seems to be exactly identical.
> Or are you suggesting to list MT7981 first to maintain alphabetical
> order? Because in terms of precedence, MT7986 has been there first, and
> hence I'd list 7986 first, followed by 7981, ie. the opposite of the
> order you were suggesting.
>
I have no clue which came first. Choose whatever is reasonable.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] dt-bindings: thermal: mediatek: add compatible string for MT7986 SoC
2022-11-02 20:43 ` Krzysztof Kozlowski
@ 2022-11-30 12:09 ` Daniel Golle
2022-11-30 12:27 ` Krzysztof Kozlowski
0 siblings, 1 reply; 7+ messages in thread
From: Daniel Golle @ 2022-11-30 12:09 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: devicetree, linux-pm, linux-arm-kernel, linux-mediatek,
linux-kernel, Rafael J. Wysocki, Daniel Lezcano, Amit Kucheria,
Zhang Rui, Matthias Brugger, Krzysztof Kozlowski
On Wed, Nov 02, 2022 at 04:43:35PM -0400, Krzysztof Kozlowski wrote:
> On 31/10/2022 18:16, Daniel Golle wrote:
> > Add compatible string 'mediatek,mt7986-thermal' for V3 thermal unit
> > found in MT7981 and MT7986 SoCs.
> >
> > Signed-off-by: Daniel Golle <daniel@makrotopia.org>
> > ---
> > Documentation/devicetree/bindings/thermal/mediatek-thermal.txt | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
> > index 5c7e7bdd029abf..efc16ab5b22b5d 100644
> > --- a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
> > +++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
> > @@ -13,6 +13,7 @@ Required properties:
> > - "mediatek,mt2701-thermal" : For MT2701 family of SoCs
> > - "mediatek,mt2712-thermal" : For MT2712 family of SoCs
> > - "mediatek,mt7622-thermal" : For MT7622 SoC
> > + - "mediatek,mt7986-thermal" : For MT7981 and MT7986 SoC
>
> Then recommended is to have specific compatible followed by fallback (so
> 7986 followed by 7981)
I'm a bit confused about the order you are suggesting. It may seem
counter-intuitive, but MT7986 was released before MT7981, the thermal
units found in both SoCs seems to be exactly identical.
Or are you suggesting to list MT7981 first to maintain alphabetical
order? Because in terms of precedence, MT7986 has been there first, and
hence I'd list 7986 first, followed by 7981, ie. the opposite of the
order you were suggesting.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] dt-bindings: thermal: mediatek: add compatible string for MT7986 SoC
2022-10-31 22:16 ` [PATCH 2/2] dt-bindings: thermal: mediatek: add compatible string for MT7986 SoC Daniel Golle
2022-10-31 23:08 ` Daniel Golle
2022-11-02 18:26 ` Rob Herring
@ 2022-11-02 20:43 ` Krzysztof Kozlowski
2022-11-30 12:09 ` Daniel Golle
2 siblings, 1 reply; 7+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-02 20:43 UTC (permalink / raw)
To: Daniel Golle, devicetree, linux-pm, linux-arm-kernel,
linux-mediatek, linux-kernel, Rafael J. Wysocki, Daniel Lezcano,
Amit Kucheria, Zhang Rui, Matthias Brugger, Krzysztof Kozlowski
On 31/10/2022 18:16, Daniel Golle wrote:
> Add compatible string 'mediatek,mt7986-thermal' for V3 thermal unit
> found in MT7981 and MT7986 SoCs.
>
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>
> ---
> Documentation/devicetree/bindings/thermal/mediatek-thermal.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
> index 5c7e7bdd029abf..efc16ab5b22b5d 100644
> --- a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
> +++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
> @@ -13,6 +13,7 @@ Required properties:
> - "mediatek,mt2701-thermal" : For MT2701 family of SoCs
> - "mediatek,mt2712-thermal" : For MT2712 family of SoCs
> - "mediatek,mt7622-thermal" : For MT7622 SoC
> + - "mediatek,mt7986-thermal" : For MT7981 and MT7986 SoC
Then recommended is to have specific compatible followed by fallback (so
7986 followed by 7981)
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] dt-bindings: thermal: mediatek: add compatible string for MT7986 SoC
2022-10-31 22:16 ` [PATCH 2/2] dt-bindings: thermal: mediatek: add compatible string for MT7986 SoC Daniel Golle
2022-10-31 23:08 ` Daniel Golle
@ 2022-11-02 18:26 ` Rob Herring
2022-11-02 20:43 ` Krzysztof Kozlowski
2 siblings, 0 replies; 7+ messages in thread
From: Rob Herring @ 2022-11-02 18:26 UTC (permalink / raw)
To: Daniel Golle
Cc: linux-pm, linux-arm-kernel, linux-mediatek, linux-kernel,
Rafael J. Wysocki, Daniel Lezcano, Amit Kucheria, Zhang Rui,
Matthias Brugger
On Mon, Oct 31, 2022 at 6:08 PM Daniel Golle <daniel@makrotopia.org> wrote:
>
> Add compatible string 'mediatek,mt7986-thermal' for V3 thermal unit
> found in MT7981 and MT7986 SoCs.
>
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>
> ---
> Documentation/devicetree/bindings/thermal/mediatek-thermal.txt | 1 +
> 1 file changed, 1 insertion(+)
Resending as the reply headers got lost...
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 2/2] dt-bindings: thermal: mediatek: add compatible string for MT7986 SoC
2022-10-31 22:16 ` [PATCH 2/2] dt-bindings: thermal: mediatek: add compatible string for MT7986 SoC Daniel Golle
@ 2022-10-31 23:08 ` Daniel Golle
2022-11-02 18:26 ` Rob Herring
2022-11-02 20:43 ` Krzysztof Kozlowski
2 siblings, 0 replies; 7+ messages in thread
From: Daniel Golle @ 2022-10-31 23:08 UTC (permalink / raw)
To: linux-pm, linux-arm-kernel, linux-mediatek, linux-kernel,
Rafael J. Wysocki, Daniel Lezcano, Amit Kucheria, Zhang Rui,
Matthias Brugger
Add compatible string 'mediatek,mt7986-thermal' for V3 thermal unit
found in MT7981 and MT7986 SoCs.
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
---
Documentation/devicetree/bindings/thermal/mediatek-thermal.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
index 5c7e7bdd029abf..efc16ab5b22b5d 100644
--- a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
+++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
@@ -13,6 +13,7 @@ Required properties:
- "mediatek,mt2701-thermal" : For MT2701 family of SoCs
- "mediatek,mt2712-thermal" : For MT2712 family of SoCs
- "mediatek,mt7622-thermal" : For MT7622 SoC
+ - "mediatek,mt7986-thermal" : For MT7981 and MT7986 SoC
- "mediatek,mt8183-thermal" : For MT8183 family of SoCs
- "mediatek,mt8516-thermal", "mediatek,mt2701-thermal : For MT8516 family of SoCs
- reg: Address range of the thermal controller
--
2.38.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/2] dt-bindings: thermal: mediatek: add compatible string for MT7986 SoC
2022-10-31 22:15 [PATCH 1/2] thermal: mediatek: add support for MT7986 and MT7981 Daniel Golle
@ 2022-10-31 22:16 ` Daniel Golle
2022-10-31 23:08 ` Daniel Golle
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Daniel Golle @ 2022-10-31 22:16 UTC (permalink / raw)
To: devicetree, linux-pm, linux-arm-kernel, linux-mediatek,
linux-kernel, Rafael J. Wysocki, Daniel Lezcano, Amit Kucheria,
Zhang Rui, Matthias Brugger, Krzysztof Kozlowski
Add compatible string 'mediatek,mt7986-thermal' for V3 thermal unit
found in MT7981 and MT7986 SoCs.
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
---
Documentation/devicetree/bindings/thermal/mediatek-thermal.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
index 5c7e7bdd029abf..efc16ab5b22b5d 100644
--- a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
+++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
@@ -13,6 +13,7 @@ Required properties:
- "mediatek,mt2701-thermal" : For MT2701 family of SoCs
- "mediatek,mt2712-thermal" : For MT2712 family of SoCs
- "mediatek,mt7622-thermal" : For MT7622 SoC
+ - "mediatek,mt7986-thermal" : For MT7981 and MT7986 SoC
- "mediatek,mt8183-thermal" : For MT8183 family of SoCs
- "mediatek,mt8516-thermal", "mediatek,mt2701-thermal : For MT8516 family of SoCs
- reg: Address range of the thermal controller
--
2.38.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-11-30 12:27 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-02 16:37 [PATCH 2/2] dt-bindings: thermal: mediatek: add compatible string for MT7986 SoC Rob Herring
-- strict thread matches above, loose matches on Subject: below --
2022-10-31 22:15 [PATCH 1/2] thermal: mediatek: add support for MT7986 and MT7981 Daniel Golle
2022-10-31 22:16 ` [PATCH 2/2] dt-bindings: thermal: mediatek: add compatible string for MT7986 SoC Daniel Golle
2022-10-31 23:08 ` Daniel Golle
2022-11-02 18:26 ` Rob Herring
2022-11-02 20:43 ` Krzysztof Kozlowski
2022-11-30 12:09 ` Daniel Golle
2022-11-30 12:27 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).