* [PATCH net-next] devlink: remove redundant health state set to error
@ 2022-11-20 8:36 Moshe Shemesh
2022-11-22 12:48 ` Leon Romanovsky
2022-11-23 4:52 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Moshe Shemesh @ 2022-11-20 8:36 UTC (permalink / raw)
To: David S. Miller, Jakub Kicinski
Cc: Jiri Pirko, netdev, linux-kernel, Moshe Shemesh
Reporter health_state is set twice to error in devlink_health_report().
Remove second time as it is redundant.
Signed-off-by: Moshe Shemesh <moshe@nvidia.com>
Reviewed-by: Eran Ben Elisha <eranbe@nvidia.com>
---
net/core/devlink.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/net/core/devlink.c b/net/core/devlink.c
index d93bc95cd7cb..cea154ddce7a 100644
--- a/net/core/devlink.c
+++ b/net/core/devlink.c
@@ -7846,8 +7846,6 @@ int devlink_health_report(struct devlink_health_reporter *reporter,
return -ECANCELED;
}
- reporter->health_state = DEVLINK_HEALTH_REPORTER_STATE_ERROR;
-
if (reporter->auto_dump) {
mutex_lock(&reporter->dump_lock);
/* store current dump of current error, for later analysis */
--
2.26.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] devlink: remove redundant health state set to error
2022-11-20 8:36 [PATCH net-next] devlink: remove redundant health state set to error Moshe Shemesh
@ 2022-11-22 12:48 ` Leon Romanovsky
2022-11-23 4:52 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Leon Romanovsky @ 2022-11-22 12:48 UTC (permalink / raw)
To: Moshe Shemesh
Cc: David S. Miller, Jakub Kicinski, Jiri Pirko, netdev, linux-kernel
On Sun, Nov 20, 2022 at 10:36:52AM +0200, Moshe Shemesh wrote:
> Reporter health_state is set twice to error in devlink_health_report().
> Remove second time as it is redundant.
>
> Signed-off-by: Moshe Shemesh <moshe@nvidia.com>
> Reviewed-by: Eran Ben Elisha <eranbe@nvidia.com>
> ---
> net/core/devlink.c | 2 --
> 1 file changed, 2 deletions(-)
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] devlink: remove redundant health state set to error
2022-11-20 8:36 [PATCH net-next] devlink: remove redundant health state set to error Moshe Shemesh
2022-11-22 12:48 ` Leon Romanovsky
@ 2022-11-23 4:52 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-11-23 4:52 UTC (permalink / raw)
To: Moshe Shemesh; +Cc: davem, kuba, jiri, netdev, linux-kernel
Hello:
This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Sun, 20 Nov 2022 10:36:52 +0200 you wrote:
> Reporter health_state is set twice to error in devlink_health_report().
> Remove second time as it is redundant.
>
> Signed-off-by: Moshe Shemesh <moshe@nvidia.com>
> Reviewed-by: Eran Ben Elisha <eranbe@nvidia.com>
> ---
> net/core/devlink.c | 2 --
> 1 file changed, 2 deletions(-)
Here is the summary with links:
- [net-next] devlink: remove redundant health state set to error
https://git.kernel.org/netdev/net-next/c/815bc3ac75e9
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-23 4:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-20 8:36 [PATCH net-next] devlink: remove redundant health state set to error Moshe Shemesh
2022-11-22 12:48 ` Leon Romanovsky
2022-11-23 4:52 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).