* [PATCH] staging: gdm724x: fix potential memleak in register_lte_device()
@ 2022-11-20 9:08 Zhang Changzhong
0 siblings, 0 replies; only message in thread
From: Zhang Changzhong @ 2022-11-20 9:08 UTC (permalink / raw)
To: Greg Kroah-Hartman, Won Kang
Cc: Zhang Changzhong, linux-staging, linux-kernel
The register_lte_device() forgets to free the current netdev in case of
register_netdev() fails, add free_netdev() to fix it.
Compile tested only.
Fixes: 61e121047645 ("staging: gdm7240: adding LTE USB driver")
Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
---
drivers/staging/gdm724x/gdm_lte.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/gdm724x/gdm_lte.c b/drivers/staging/gdm724x/gdm_lte.c
index 671ee88..34ac9e0 100644
--- a/drivers/staging/gdm724x/gdm_lte.c
+++ b/drivers/staging/gdm724x/gdm_lte.c
@@ -905,8 +905,10 @@ int register_lte_device(struct phy_dev *phy_dev,
SET_NETDEV_DEVTYPE(net, &wwan_type);
ret = register_netdev(net);
- if (ret)
+ if (ret) {
+ free_netdev(net);
goto err;
+ }
netif_carrier_on(net);
--
2.9.5
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2022-11-20 8:49 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-20 9:08 [PATCH] staging: gdm724x: fix potential memleak in register_lte_device() Zhang Changzhong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).