* [PATCH v3] ethtool: avoiding integer overflow in ethtool_phys_id()
@ 2022-11-22 12:29 Maxim Korotkov
2022-11-22 13:39 ` Alexander Lobakin
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Maxim Korotkov @ 2022-11-22 12:29 UTC (permalink / raw)
To: David S. Miller
Cc: Maxim Korotkov, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Guangbin Huang, Andrew Lunn, Alexander Lobakin, Keller, Jacob E,
Tom Rix, Marco Bonelli, Edward Cree, netdev, linux-kernel,
lvc-project
The value of an arithmetic expression "n * id.data" is subject
to possible overflow due to a failure to cast operands to a larger data
type before performing arithmetic. Used macro for multiplication instead
operator for avoiding overflow.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Signed-off-by: Maxim Korotkov <korotkov.maxim.s@gmail.com>
---
net/ethtool/ioctl.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/ethtool/ioctl.c b/net/ethtool/ioctl.c
index 6a7308de192d..6b59e7a1c906 100644
--- a/net/ethtool/ioctl.c
+++ b/net/ethtool/ioctl.c
@@ -2007,7 +2007,8 @@ static int ethtool_phys_id(struct net_device *dev, void __user *useraddr)
} else {
/* Driver expects to be called at twice the frequency in rc */
int n = rc * 2, interval = HZ / n;
- u64 count = n * id.data, i = 0;
+ u64 count = mul_u32_u32(n, id.data);
+ u64 i = 0;
do {
rtnl_lock();
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v3] ethtool: avoiding integer overflow in ethtool_phys_id()
2022-11-22 12:29 [PATCH v3] ethtool: avoiding integer overflow in ethtool_phys_id() Maxim Korotkov
@ 2022-11-22 13:39 ` Alexander Lobakin
2022-11-22 14:49 ` Andrew Lunn
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Alexander Lobakin @ 2022-11-22 13:39 UTC (permalink / raw)
To: Maxim Korotkov
Cc: Alexander Lobakin, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Guangbin Huang, Andrew Lunn, Keller, Jacob E,
Tom Rix, Marco Bonelli, Edward Cree, netdev, linux-kernel,
lvc-project
From: Maxim Korotkov <korotkov.maxim.s@gmail.com>
Date: Tue, 22 Nov 2022 15:29:01 +0300
> The value of an arithmetic expression "n * id.data" is subject
> to possible overflow due to a failure to cast operands to a larger data
> type before performing arithmetic. Used macro for multiplication instead
> operator for avoiding overflow.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Signed-off-by: Maxim Korotkov <korotkov.maxim.s@gmail.com>
Reviewed-by: Alexander Lobakin <alexandr.lobakin@intel.com>
> ---
> net/ethtool/ioctl.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/net/ethtool/ioctl.c b/net/ethtool/ioctl.c
> index 6a7308de192d..6b59e7a1c906 100644
> --- a/net/ethtool/ioctl.c
> +++ b/net/ethtool/ioctl.c
> @@ -2007,7 +2007,8 @@ static int ethtool_phys_id(struct net_device *dev, void __user *useraddr)
> } else {
> /* Driver expects to be called at twice the frequency in rc */
> int n = rc * 2, interval = HZ / n;
> - u64 count = n * id.data, i = 0;
> + u64 count = mul_u32_u32(n, id.data);
> + u64 i = 0;
>
> do {
> rtnl_lock();
> --
> 2.17.1
Some notes to the process, not the code:
1) I asked to add my Reviewed-by to v3 in the previous thread, it's
mandatory for authors to pick-up all the tags before publishing
a new revision;
2) when sending v2, v3, ... vN, please have a changelog in the
commit message or right below those '---' after your SoB, that
makes it easier to review.
Thanks,
Olek
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3] ethtool: avoiding integer overflow in ethtool_phys_id()
2022-11-22 12:29 [PATCH v3] ethtool: avoiding integer overflow in ethtool_phys_id() Maxim Korotkov
2022-11-22 13:39 ` Alexander Lobakin
@ 2022-11-22 14:49 ` Andrew Lunn
2022-11-24 4:11 ` Jakub Kicinski
2022-11-24 4:20 ` patchwork-bot+netdevbpf
3 siblings, 0 replies; 5+ messages in thread
From: Andrew Lunn @ 2022-11-22 14:49 UTC (permalink / raw)
To: Maxim Korotkov
Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Guangbin Huang, Alexander Lobakin, Keller, Jacob E, Tom Rix,
Marco Bonelli, Edward Cree, netdev, linux-kernel, lvc-project
On Tue, Nov 22, 2022 at 03:29:01PM +0300, Maxim Korotkov wrote:
> The value of an arithmetic expression "n * id.data" is subject
> to possible overflow due to a failure to cast operands to a larger data
> type before performing arithmetic. Used macro for multiplication instead
> operator for avoiding overflow.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Signed-off-by: Maxim Korotkov <korotkov.maxim.s@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3] ethtool: avoiding integer overflow in ethtool_phys_id()
2022-11-22 12:29 [PATCH v3] ethtool: avoiding integer overflow in ethtool_phys_id() Maxim Korotkov
2022-11-22 13:39 ` Alexander Lobakin
2022-11-22 14:49 ` Andrew Lunn
@ 2022-11-24 4:11 ` Jakub Kicinski
2022-11-24 4:20 ` patchwork-bot+netdevbpf
3 siblings, 0 replies; 5+ messages in thread
From: Jakub Kicinski @ 2022-11-24 4:11 UTC (permalink / raw)
To: Maxim Korotkov
Cc: David S. Miller, Eric Dumazet, Paolo Abeni, Guangbin Huang,
Andrew Lunn, Alexander Lobakin, Keller, Jacob E, Tom Rix,
Marco Bonelli, Edward Cree, netdev, linux-kernel, lvc-project
On Tue, 22 Nov 2022 15:29:01 +0300 Maxim Korotkov wrote:
> The value of an arithmetic expression "n * id.data" is subject
> to possible overflow due to a failure to cast operands to a larger data
> type before performing arithmetic. Used macro for multiplication instead
> operator for avoiding overflow.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Signed-off-by: Maxim Korotkov <korotkov.maxim.s@gmail.com>
Applying to net-next, pretty sure nobody expects us to support blinking
an LED 4 billion times, at a rate low enough for a human eye to see...
But let's watch the stable bots pick it up anyway.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3] ethtool: avoiding integer overflow in ethtool_phys_id()
2022-11-22 12:29 [PATCH v3] ethtool: avoiding integer overflow in ethtool_phys_id() Maxim Korotkov
` (2 preceding siblings ...)
2022-11-24 4:11 ` Jakub Kicinski
@ 2022-11-24 4:20 ` patchwork-bot+netdevbpf
3 siblings, 0 replies; 5+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-11-24 4:20 UTC (permalink / raw)
To: Maxim Korotkov
Cc: davem, edumazet, kuba, pabeni, huangguangbin2, andrew,
alexandr.lobakin, jacob.e.keller, trix, marco, ecree, netdev,
linux-kernel, lvc-project
Hello:
This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 22 Nov 2022 15:29:01 +0300 you wrote:
> The value of an arithmetic expression "n * id.data" is subject
> to possible overflow due to a failure to cast operands to a larger data
> type before performing arithmetic. Used macro for multiplication instead
> operator for avoiding overflow.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> [...]
Here is the summary with links:
- [v3] ethtool: avoiding integer overflow in ethtool_phys_id()
https://git.kernel.org/netdev/net-next/c/64a8f8f7127d
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-11-24 4:20 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-22 12:29 [PATCH v3] ethtool: avoiding integer overflow in ethtool_phys_id() Maxim Korotkov
2022-11-22 13:39 ` Alexander Lobakin
2022-11-22 14:49 ` Andrew Lunn
2022-11-24 4:11 ` Jakub Kicinski
2022-11-24 4:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).