* [PATCH 0/1] drm/vkms: check plane_composer->map[0] before using it
@ 2022-04-11 23:38 Tales Lelo da Aparecida
2022-04-11 23:38 ` [PATCH 1/1] " Tales Lelo da Aparecida
0 siblings, 1 reply; 4+ messages in thread
From: Tales Lelo da Aparecida @ 2022-04-11 23:38 UTC (permalink / raw)
To: Rodrigo Siqueira, Melissa Wen, Haneen Mohammed, Daniel Vetter,
David Airlie, dri-devel, linux-kernel, andrealmeid
Cc: Tales Lelo da Aparecida
Hello, I'm interested in collaborating with VKMS, please let me know if there's
anything that I could better.
Tales Lelo da Aparecida (1):
drm/vkms: check plane_composer->map[0] before using it
drivers/gpu/drm/vkms/vkms_composer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.35.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/1] drm/vkms: check plane_composer->map[0] before using it
2022-04-11 23:38 [PATCH 0/1] drm/vkms: check plane_composer->map[0] before using it Tales Lelo da Aparecida
@ 2022-04-11 23:38 ` Tales Lelo da Aparecida
2022-04-12 16:52 ` André Almeida
2022-04-14 20:58 ` Melissa Wen
0 siblings, 2 replies; 4+ messages in thread
From: Tales Lelo da Aparecida @ 2022-04-11 23:38 UTC (permalink / raw)
To: Rodrigo Siqueira, Melissa Wen, Haneen Mohammed, Daniel Vetter,
David Airlie, dri-devel, linux-kernel, andrealmeid
Cc: Tales Lelo da Aparecida
Fix a copypasta error, which resulted in checking repeatedly if the
primary_composer->map[0] was null, instead of checking each
plane_composer while composing planes.
Signed-off-by: Tales Lelo da Aparecida <tales.aparecida@gmail.com>
---
drivers/gpu/drm/vkms/vkms_composer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/vkms/vkms_composer.c b/drivers/gpu/drm/vkms/vkms_composer.c
index c6a1036bf2ea..b47ac170108c 100644
--- a/drivers/gpu/drm/vkms/vkms_composer.c
+++ b/drivers/gpu/drm/vkms/vkms_composer.c
@@ -157,7 +157,7 @@ static void compose_plane(struct vkms_composer *primary_composer,
void *vaddr;
void (*pixel_blend)(const u8 *p_src, u8 *p_dst);
- if (WARN_ON(iosys_map_is_null(&primary_composer->map[0])))
+ if (WARN_ON(iosys_map_is_null(&plane_composer->map[0])))
return;
vaddr = plane_composer->map[0].vaddr;
--
2.35.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] drm/vkms: check plane_composer->map[0] before using it
2022-04-11 23:38 ` [PATCH 1/1] " Tales Lelo da Aparecida
@ 2022-04-12 16:52 ` André Almeida
2022-04-14 20:58 ` Melissa Wen
1 sibling, 0 replies; 4+ messages in thread
From: André Almeida @ 2022-04-12 16:52 UTC (permalink / raw)
To: Tales Lelo da Aparecida, Rodrigo Siqueira, Melissa Wen,
Haneen Mohammed, Daniel Vetter, David Airlie, dri-devel,
linux-kernel
Hi Tales,
Às 20:38 de 11/04/22, Tales Lelo da Aparecida escreveu:
> Fix a copypasta error, which resulted in checking repeatedly if the
> primary_composer->map[0] was null, instead of checking each
> plane_composer while composing planes.
>
> Signed-off-by: Tales Lelo da Aparecida <tales.aparecida@gmail.com>
Reviewed-by: André Almeida <andrealmeid@riseup.net>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] drm/vkms: check plane_composer->map[0] before using it
2022-04-11 23:38 ` [PATCH 1/1] " Tales Lelo da Aparecida
2022-04-12 16:52 ` André Almeida
@ 2022-04-14 20:58 ` Melissa Wen
1 sibling, 0 replies; 4+ messages in thread
From: Melissa Wen @ 2022-04-14 20:58 UTC (permalink / raw)
To: Tales Lelo da Aparecida
Cc: Rodrigo Siqueira, Melissa Wen, Haneen Mohammed, Daniel Vetter,
David Airlie, dri-devel, linux-kernel, andrealmeid
[-- Attachment #1: Type: text/plain, Size: 1456 bytes --]
On 04/11, Tales Lelo da Aparecida wrote:
> Fix a copypasta error, which resulted in checking repeatedly if the
> primary_composer->map[0] was null, instead of checking each
> plane_composer while composing planes.
>
> Signed-off-by: Tales Lelo da Aparecida <tales.aparecida@gmail.com>
Hi Tales,
Nice catch!
I suggest you detail this issue with more information. The caller of
compose_plane() already checks primary_composer->map. In constrast,
plane_composer->map is never verified here before handling.
Also, add the 'Fixes' tag pointing to the commit that introduced this
issue.
Can you send a next version addressing these suggestions and already
adding Andre's reviewed-by tag?
Thanks for your patch.
Melissa
> ---
> drivers/gpu/drm/vkms/vkms_composer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/vkms/vkms_composer.c b/drivers/gpu/drm/vkms/vkms_composer.c
> index c6a1036bf2ea..b47ac170108c 100644
> --- a/drivers/gpu/drm/vkms/vkms_composer.c
> +++ b/drivers/gpu/drm/vkms/vkms_composer.c
> @@ -157,7 +157,7 @@ static void compose_plane(struct vkms_composer *primary_composer,
> void *vaddr;
> void (*pixel_blend)(const u8 *p_src, u8 *p_dst);
>
> - if (WARN_ON(iosys_map_is_null(&primary_composer->map[0])))
> + if (WARN_ON(iosys_map_is_null(&plane_composer->map[0])))
> return;
>
> vaddr = plane_composer->map[0].vaddr;
> --
> 2.35.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-04-14 20:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-11 23:38 [PATCH 0/1] drm/vkms: check plane_composer->map[0] before using it Tales Lelo da Aparecida
2022-04-11 23:38 ` [PATCH 1/1] " Tales Lelo da Aparecida
2022-04-12 16:52 ` André Almeida
2022-04-14 20:58 ` Melissa Wen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).