* [tip:x86/vdso 3/4] arch/x86/entry/vdso/vdso32/../vgetcpu.c:13:1: warning: no previous prototype for '__vdso_getcpu'
@ 2023-02-06 23:41 kernel test robot
2023-02-07 17:07 ` Borislav Petkov
2023-02-07 18:31 ` [tip: x86/vdso] x86/vdso: Fix -Wmissing-prototypes warnings tip-bot2 for Borislav Petkov (AMD)
0 siblings, 2 replies; 5+ messages in thread
From: kernel test robot @ 2023-02-06 23:41 UTC (permalink / raw)
To: Sebastian Andrzej Siewior
Cc: oe-kbuild-all, linux-kernel, x86, Thomas Gleixner
tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/vdso
head: 5646bbd6684acf5c9b9dedb863b7d2f6f5a330fb
commit: 92d33063c081a82d25dd08a9cce03947c8ed9164 [3/4] x86/vdso: Provide getcpu for x86-32.
config: x86_64-rhel-8.3-kselftests (https://download.01.org/0day-ci/archive/20230207/202302070742.iYcnoJwk-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
# https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?id=92d33063c081a82d25dd08a9cce03947c8ed9164
git remote add tip https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
git fetch --no-tags tip x86/vdso
git checkout 92d33063c081a82d25dd08a9cce03947c8ed9164
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 O=build_dir ARCH=x86_64 olddefconfig
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash arch/x86/entry/vdso/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
In file included from arch/x86/entry/vdso/vdso32/vgetcpu.c:2:
>> arch/x86/entry/vdso/vdso32/../vgetcpu.c:13:1: warning: no previous prototype for '__vdso_getcpu' [-Wmissing-prototypes]
13 | __vdso_getcpu(unsigned *cpu, unsigned *node, struct getcpu_cache *unused)
| ^~~~~~~~~~~~~
vim +/__vdso_getcpu +13 arch/x86/entry/vdso/vdso32/../vgetcpu.c
2aae950b21e4bc arch/x86_64/vdso/vgetcpu.c Andi Kleen 2007-07-21 11
23adec554a7648 arch/x86/vdso/vgetcpu.c Steven Rostedt 2008-05-12 12 notrace long
23adec554a7648 arch/x86/vdso/vgetcpu.c Steven Rostedt 2008-05-12 @13 __vdso_getcpu(unsigned *cpu, unsigned *node, struct getcpu_cache *unused)
2aae950b21e4bc arch/x86_64/vdso/vgetcpu.c Andi Kleen 2007-07-21 14 {
22245bdf0ad805 arch/x86/entry/vdso/vgetcpu.c Ingo Molnar 2018-10-08 15 vdso_read_cpunode(cpu, node);
ec3a94188df7d2 arch/x86/entry/vdso/vgetcpu.c Ingo Molnar 2018-10-08 16
2aae950b21e4bc arch/x86_64/vdso/vgetcpu.c Andi Kleen 2007-07-21 17 return 0;
2aae950b21e4bc arch/x86_64/vdso/vgetcpu.c Andi Kleen 2007-07-21 18 }
2aae950b21e4bc arch/x86_64/vdso/vgetcpu.c Andi Kleen 2007-07-21 19
:::::: The code at line 13 was first introduced by commit
:::::: 23adec554a7648f99c8acc0caf49c66320cd2b84 x86: add notrace annotations to vsyscall.
:::::: TO: Steven Rostedt <srostedt@redhat.com>
:::::: CC: Thomas Gleixner <tglx@linutronix.de>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [tip:x86/vdso 3/4] arch/x86/entry/vdso/vdso32/../vgetcpu.c:13:1: warning: no previous prototype for '__vdso_getcpu'
2023-02-06 23:41 [tip:x86/vdso 3/4] arch/x86/entry/vdso/vdso32/../vgetcpu.c:13:1: warning: no previous prototype for '__vdso_getcpu' kernel test robot
@ 2023-02-07 17:07 ` Borislav Petkov
2023-02-15 15:44 ` Sebastian Andrzej Siewior
2023-02-07 18:31 ` [tip: x86/vdso] x86/vdso: Fix -Wmissing-prototypes warnings tip-bot2 for Borislav Petkov (AMD)
1 sibling, 1 reply; 5+ messages in thread
From: Borislav Petkov @ 2023-02-07 17:07 UTC (permalink / raw)
To: kernel test robot
Cc: Sebastian Andrzej Siewior, oe-kbuild-all, linux-kernel, x86,
Thomas Gleixner
On Tue, Feb 07, 2023 at 07:41:54AM +0800, kernel test robot wrote:
> All warnings (new ones prefixed by >>):
>
> In file included from arch/x86/entry/vdso/vdso32/vgetcpu.c:2:
> >> arch/x86/entry/vdso/vdso32/../vgetcpu.c:13:1: warning: no previous prototype for '__vdso_getcpu' [-Wmissing-prototypes]
> 13 | __vdso_getcpu(unsigned *cpu, unsigned *node, struct getcpu_cache *unused)
> | ^~~~~~~~~~~~~
---
From: "Borislav Petkov (AMD)" <bp@alien8.de>
Date: Tue, 7 Feb 2023 16:13:24 +0100
Subject: [PATCH] x86/vdso: Fix -Wmissing-prototypes warnings
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Fix those:
In file included from arch/x86/entry/vdso/vdso32/vclock_gettime.c:4:
arch/x86/entry/vdso/vdso32/../vclock_gettime.c:70:5: warning: no previous prototype for ‘__vdso_clock_gettime64’ [-Wmissing-prototypes]
70 | int __vdso_clock_gettime64(clockid_t clock, struct __kernel_timespec *ts)
|
In file included from arch/x86/entry/vdso/vdso32/vgetcpu.c:3:
arch/x86/entry/vdso/vdso32/../vgetcpu.c:13:1: warning: no previous prototype for ‘__vdso_getcpu’ [-Wmissing-prototypes]
13 | __vdso_getcpu(unsigned *cpu, unsigned *node, struct getcpu_cache *unused)
| ^~~~~~~~~~~~~
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Link: https://lore.kernel.org/r/202302070742.iYcnoJwk-lkp@intel.com
---
arch/x86/include/asm/vdso/gettimeofday.h | 2 ++
arch/x86/include/asm/vdso/processor.h | 4 ++++
2 files changed, 6 insertions(+)
diff --git a/arch/x86/include/asm/vdso/gettimeofday.h b/arch/x86/include/asm/vdso/gettimeofday.h
index 1936f21ed8cd..4cf6794f9d68 100644
--- a/arch/x86/include/asm/vdso/gettimeofday.h
+++ b/arch/x86/include/asm/vdso/gettimeofday.h
@@ -318,6 +318,8 @@ u64 vdso_calc_delta(u64 cycles, u64 last, u64 mask, u32 mult)
}
#define vdso_calc_delta vdso_calc_delta
+int __vdso_clock_gettime64(clockid_t clock, struct __kernel_timespec *ts);
+
#endif /* !__ASSEMBLY__ */
#endif /* __ASM_VDSO_GETTIMEOFDAY_H */
diff --git a/arch/x86/include/asm/vdso/processor.h b/arch/x86/include/asm/vdso/processor.h
index 57b1a7034c64..2cbce97d29ea 100644
--- a/arch/x86/include/asm/vdso/processor.h
+++ b/arch/x86/include/asm/vdso/processor.h
@@ -18,6 +18,10 @@ static __always_inline void cpu_relax(void)
rep_nop();
}
+struct getcpu_cache;
+
+notrace long __vdso_getcpu(unsigned *cpu, unsigned *node, struct getcpu_cache *unused);
+
#endif /* __ASSEMBLY__ */
#endif /* __ASM_VDSO_PROCESSOR_H */
--
2.35.1
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [tip: x86/vdso] x86/vdso: Fix -Wmissing-prototypes warnings
2023-02-06 23:41 [tip:x86/vdso 3/4] arch/x86/entry/vdso/vdso32/../vgetcpu.c:13:1: warning: no previous prototype for '__vdso_getcpu' kernel test robot
2023-02-07 17:07 ` Borislav Petkov
@ 2023-02-07 18:31 ` tip-bot2 for Borislav Petkov (AMD)
1 sibling, 0 replies; 5+ messages in thread
From: tip-bot2 for Borislav Petkov (AMD) @ 2023-02-07 18:31 UTC (permalink / raw)
To: linux-tip-commits
Cc: kernel test robot, Borislav Petkov (AMD), x86, linux-kernel
The following commit has been merged into the x86/vdso branch of tip:
Commit-ID: dac0da428f8dfb23666ab4ea54a7768c152b857a
Gitweb: https://git.kernel.org/tip/dac0da428f8dfb23666ab4ea54a7768c152b857a
Author: Borislav Petkov (AMD) <bp@alien8.de>
AuthorDate: Tue, 07 Feb 2023 16:13:24 +01:00
Committer: Borislav Petkov (AMD) <bp@alien8.de>
CommitterDate: Tue, 07 Feb 2023 18:23:17 +01:00
x86/vdso: Fix -Wmissing-prototypes warnings
Fix those:
In file included from arch/x86/entry/vdso/vdso32/vclock_gettime.c:4:
arch/x86/entry/vdso/vdso32/../vclock_gettime.c:70:5: warning: no previous prototype for ‘__vdso_clock_gettime64’ [-Wmissing-prototypes]
70 | int __vdso_clock_gettime64(clockid_t clock, struct __kernel_timespec *ts)
|
In file included from arch/x86/entry/vdso/vdso32/vgetcpu.c:3:
arch/x86/entry/vdso/vdso32/../vgetcpu.c:13:1: warning: no previous prototype for ‘__vdso_getcpu’ [-Wmissing-prototypes]
13 | __vdso_getcpu(unsigned *cpu, unsigned *node, struct getcpu_cache *unused)
| ^~~~~~~~~~~~~
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Link: https://lore.kernel.org/r/202302070742.iYcnoJwk-lkp@intel.com
---
arch/x86/include/asm/vdso/gettimeofday.h | 2 ++
arch/x86/include/asm/vdso/processor.h | 4 ++++
2 files changed, 6 insertions(+)
diff --git a/arch/x86/include/asm/vdso/gettimeofday.h b/arch/x86/include/asm/vdso/gettimeofday.h
index 1936f21..4cf6794 100644
--- a/arch/x86/include/asm/vdso/gettimeofday.h
+++ b/arch/x86/include/asm/vdso/gettimeofday.h
@@ -318,6 +318,8 @@ u64 vdso_calc_delta(u64 cycles, u64 last, u64 mask, u32 mult)
}
#define vdso_calc_delta vdso_calc_delta
+int __vdso_clock_gettime64(clockid_t clock, struct __kernel_timespec *ts);
+
#endif /* !__ASSEMBLY__ */
#endif /* __ASM_VDSO_GETTIMEOFDAY_H */
diff --git a/arch/x86/include/asm/vdso/processor.h b/arch/x86/include/asm/vdso/processor.h
index 57b1a70..2cbce97 100644
--- a/arch/x86/include/asm/vdso/processor.h
+++ b/arch/x86/include/asm/vdso/processor.h
@@ -18,6 +18,10 @@ static __always_inline void cpu_relax(void)
rep_nop();
}
+struct getcpu_cache;
+
+notrace long __vdso_getcpu(unsigned *cpu, unsigned *node, struct getcpu_cache *unused);
+
#endif /* __ASSEMBLY__ */
#endif /* __ASM_VDSO_PROCESSOR_H */
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [tip:x86/vdso 3/4] arch/x86/entry/vdso/vdso32/../vgetcpu.c:13:1: warning: no previous prototype for '__vdso_getcpu'
2023-02-07 17:07 ` Borislav Petkov
@ 2023-02-15 15:44 ` Sebastian Andrzej Siewior
2023-02-15 16:35 ` Borislav Petkov
0 siblings, 1 reply; 5+ messages in thread
From: Sebastian Andrzej Siewior @ 2023-02-15 15:44 UTC (permalink / raw)
To: Borislav Petkov
Cc: kernel test robot, oe-kbuild-all, linux-kernel, x86, Thomas Gleixner
On 2023-02-07 18:07:45 [+0100], Borislav Petkov wrote:
> From: "Borislav Petkov (AMD)" <bp@alien8.de>
> Date: Tue, 7 Feb 2023 16:13:24 +0100
> Subject: [PATCH] x86/vdso: Fix -Wmissing-prototypes warnings
terribly sorry to have missed this. I wrongly parsed it as another
instance of the other thing.
Thank you for dealing with it.
Sebastian
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [tip:x86/vdso 3/4] arch/x86/entry/vdso/vdso32/../vgetcpu.c:13:1: warning: no previous prototype for '__vdso_getcpu'
2023-02-15 15:44 ` Sebastian Andrzej Siewior
@ 2023-02-15 16:35 ` Borislav Petkov
0 siblings, 0 replies; 5+ messages in thread
From: Borislav Petkov @ 2023-02-15 16:35 UTC (permalink / raw)
To: Sebastian Andrzej Siewior
Cc: kernel test robot, oe-kbuild-all, linux-kernel, x86, Thomas Gleixner
On Wed, Feb 15, 2023 at 04:44:42PM +0100, Sebastian Andrzej Siewior wrote:
> terribly sorry to have missed this. I wrongly parsed it as another
> instance of the other thing.
> Thank you for dealing with it.
No worries - I'll do the easy stuff only. :-P
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-02-15 16:35 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-06 23:41 [tip:x86/vdso 3/4] arch/x86/entry/vdso/vdso32/../vgetcpu.c:13:1: warning: no previous prototype for '__vdso_getcpu' kernel test robot
2023-02-07 17:07 ` Borislav Petkov
2023-02-15 15:44 ` Sebastian Andrzej Siewior
2023-02-15 16:35 ` Borislav Petkov
2023-02-07 18:31 ` [tip: x86/vdso] x86/vdso: Fix -Wmissing-prototypes warnings tip-bot2 for Borislav Petkov (AMD)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).