From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Gleb Natapov <gleb@kernel.org>,
Dirk Brandewie <dirk.brandewie@gmail.com>,
Kashyap Chamarthy <kchamart@redhat.com>,
Josh Boyer <jwboyer@fedoraproject.org>,
One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
Viresh Kumar <viresh.kumar@linaro.org>,
"cpufreq@vger.kernel.org" <cpufreq@vger.kernel.org>,
Linux PM list <linux-pm@vger.kernel.org>,
"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
"Richard W.M. Jones" <rjones@redhat.com>
Subject: Re: intel_pstate divide error with v3.13-rc4-256-gb7000ad
Date: Sat, 04 Jan 2014 15:38:31 +0100 [thread overview]
Message-ID: <1676077.d8A9e8eo7M@vostro.rjw.lan> (raw)
In-Reply-To: <52C7C7EE.1070407@redhat.com>
On Saturday, January 04, 2014 09:35:58 AM Paolo Bonzini wrote:
> Il 03/01/2014 23:46, Rafael J. Wysocki ha scritto:
> > Well, fixing the KVM bug is surely welcome.
> >
> > That said, adding checks to ensure that your assumptions are valid is rarely
> > wrong, especially if they are done once per kernel boot. And the kernel only
> > should panic if it cannot continue to run, which isn't the case here.
>
> I agree, but I suspect even your check is already late.
Well, it's just a sanity check and it makes the problem go away for the reporter.
> Your patch is welcome but perhaps it should have a WARN_ON too.
It has been pulled in already, so the WARN_ON() can only be added via a separate
patch now. Would you like to prepare that patch?
Rafael
next prev parent reply other threads:[~2014-01-04 14:24 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-24 14:36 intel_pstate divide error with v3.13-rc4-256-gb7000ad Josh Boyer
2013-12-24 16:06 ` Viresh Kumar
2013-12-27 12:24 ` One Thousand Gnomes
2013-12-27 12:47 ` Gleb Natapov
2013-12-27 13:46 ` Josh Boyer
2013-12-27 14:15 ` Kashyap Chamarthy
2013-12-27 14:34 ` Richard W.M. Jones
2013-12-27 16:52 ` Gleb Natapov
2013-12-27 17:01 ` Gleb Natapov
2013-12-27 17:17 ` Richard W.M. Jones
2013-12-27 17:17 ` Kashyap Chamarthy
2013-12-27 21:51 ` Rafael J. Wysocki
2013-12-29 12:12 ` Kashyap Chamarthy
2013-12-29 15:04 ` Rafael J. Wysocki
2013-12-30 14:58 ` Kashyap Chamarthy
2013-12-31 2:07 ` Rafael J. Wysocki
2014-01-03 17:30 ` Dirk Brandewie
2014-01-03 18:04 ` Gleb Natapov
2014-01-03 20:00 ` Dirk Brandewie
2014-01-03 22:06 ` Paolo Bonzini
2014-01-06 17:18 ` Dirk Brandewie
2014-01-07 16:11 ` Gleb Natapov
2014-01-03 22:46 ` Rafael J. Wysocki
2014-01-04 8:35 ` Paolo Bonzini
2014-01-04 14:38 ` Rafael J. Wysocki [this message]
2014-01-04 17:38 ` Paolo Bonzini
2014-01-04 17:48 ` Gleb Natapov
2014-01-04 21:38 ` Rafael J. Wysocki
2014-01-06 11:20 ` Paolo Bonzini
2014-01-06 11:37 ` Rafael J. Wysocki
2014-01-06 18:40 ` Dirk Brandewie
2013-12-27 14:35 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1676077.d8A9e8eo7M@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=cpufreq@vger.kernel.org \
--cc=dirk.brandewie@gmail.com \
--cc=gleb@kernel.org \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=jwboyer@fedoraproject.org \
--cc=kchamart@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rjones@redhat.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).