linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [GIT PULL] hotfixes for 6.2
@ 2023-02-17 23:18 Andrew Morton
  2023-02-18  3:04 ` pr-tracker-bot
  0 siblings, 1 reply; 6+ messages in thread
From: Andrew Morton @ 2023-02-17 23:18 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-mm, linux-kernel, mm-commits


Linus, please merge this final set of hotfixes, thanks.


The following changes since commit ce4d9a1ea35ac5429e822c4106cb2859d5c71f3e:

  of: reserved_mem: Have kmemleak ignore dynamically allocated reserved mem (2023-02-09 15:56:51 -0800)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm tags/mm-hotfixes-stable-2023-02-17-15-16-2

for you to fetch changes up to 99b9402a36f0799f25feee4465bfa4b8dfa74b4d:

  nilfs2: fix underflow in second superblock position calculations (2023-02-17 15:07:05 -0800)

----------------------------------------------------------------
Six hotfixes.  Five are cc:stable: four for MM, one for nilfs2.  Also a
MAINTAINERS update.

----------------------------------------------------------------
Mike Kravetz (1):
      hugetlb: check for undefined shift on 32 bit architectures

Peter Xu (1):
      mm/migrate: fix wrongly apply write bit after mkdirty on sparc64

Qian Yingjin (1):
      mm/filemap: fix page end in filemap_get_read_batch

Randy Dunlap (1):
      MAINTAINERS: update FPU EMULATOR web page

Ryusuke Konishi (1):
      nilfs2: fix underflow in second superblock position calculations

Zach O'Keefe (1):
      mm/MADV_COLLAPSE: set EAGAIN on unexpected page refcount

 MAINTAINERS             | 2 +-
 fs/nilfs2/ioctl.c       | 7 +++++++
 fs/nilfs2/super.c       | 9 +++++++++
 fs/nilfs2/the_nilfs.c   | 8 +++++++-
 include/linux/hugetlb.h | 5 ++++-
 mm/filemap.c            | 5 +++--
 mm/huge_memory.c        | 6 ++++--
 mm/khugepaged.c         | 1 +
 mm/migrate.c            | 2 ++
 9 files changed, 38 insertions(+), 7 deletions(-)


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [GIT PULL] hotfixes for 6.2
  2023-02-17 23:18 [GIT PULL] hotfixes for 6.2 Andrew Morton
@ 2023-02-18  3:04 ` pr-tracker-bot
  0 siblings, 0 replies; 6+ messages in thread
From: pr-tracker-bot @ 2023-02-18  3:04 UTC (permalink / raw)
  To: Andrew Morton; +Cc: Linus Torvalds, linux-mm, linux-kernel, mm-commits

The pull request you sent on Fri, 17 Feb 2023 15:18:20 -0800:

> git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm tags/mm-hotfixes-stable-2023-02-17-15-16-2

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/38f8ccde04a3fa317b51b05e63c3cb57e1641931

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [GIT PULL] hotfixes for 6.2
  2023-02-13 22:19 ` Linus Torvalds
@ 2023-02-14  1:26   ` Baolin Wang
  0 siblings, 0 replies; 6+ messages in thread
From: Baolin Wang @ 2023-02-14  1:26 UTC (permalink / raw)
  To: Linus Torvalds, Andrew Morton; +Cc: linux-mm, mm-commits, linux-kernel



On 2/14/2023 6:19 AM, Linus Torvalds wrote:
> On Mon, Feb 13, 2023 at 2:08 PM Andrew Morton <akpm@linux-foundation.org> wrote:
>>
>> Kuan-Ying Lee (1):
>>        mm/gup: add folio to list when folio_isolate_lru() succeed
> 
> Ugh. I really hate fixes like this.
> 
> The problem came from mis-understanding the return value of
> folio_isolate_lru(), and thinking that it was a boolean
> success/failure thing.
> 
> It wasn't, it was an integer "success/errno" thing, and the sense of
> the test was wrong. So the patch is
> 
> -       if (!folio_isolate_lru(folio))
> +       if (folio_isolate_lru(folio))
>                  continue;
> 
> but at no point was the code *clarified*.
> 
> Wouldn't it have been much better to write the new code to be
> 
>          if (folio_isolate_lru(folio) < 0)
>                  continue;
> 
> to actually make it clear that this is a "negative error return check".
> 
> I've pulled this, but I really think that when somebody notices that
> we had a silly bug because of a misunderstanding like this, it's not
> just that the bug should be fixed, the code should also be *clarified*
> at the same time.

Yes, agree, I need to check the return value of folio_isolate_lru() 
every time when looking at the code. I can help to create a patch to 
make it clear for all users.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [GIT PULL] hotfixes for 6.2
  2023-02-13 22:08 Andrew Morton
  2023-02-13 22:19 ` Linus Torvalds
@ 2023-02-13 22:20 ` pr-tracker-bot
  1 sibling, 0 replies; 6+ messages in thread
From: pr-tracker-bot @ 2023-02-13 22:20 UTC (permalink / raw)
  To: Andrew Morton; +Cc: Linus Torvalds, linux-mm, mm-commits, linux-kernel

The pull request you sent on Mon, 13 Feb 2023 14:08:12 -0800:

> git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm tags/mm-hotfixes-stable-2023-02-13-13-50

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/f6feea56f66d34259c4222fa02e8171c4f2673d1

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [GIT PULL] hotfixes for 6.2
  2023-02-13 22:08 Andrew Morton
@ 2023-02-13 22:19 ` Linus Torvalds
  2023-02-14  1:26   ` Baolin Wang
  2023-02-13 22:20 ` pr-tracker-bot
  1 sibling, 1 reply; 6+ messages in thread
From: Linus Torvalds @ 2023-02-13 22:19 UTC (permalink / raw)
  To: Andrew Morton; +Cc: linux-mm, mm-commits, linux-kernel

On Mon, Feb 13, 2023 at 2:08 PM Andrew Morton <akpm@linux-foundation.org> wrote:
>
> Kuan-Ying Lee (1):
>       mm/gup: add folio to list when folio_isolate_lru() succeed

Ugh. I really hate fixes like this.

The problem came from mis-understanding the return value of
folio_isolate_lru(), and thinking that it was a boolean
success/failure thing.

It wasn't, it was an integer "success/errno" thing, and the sense of
the test was wrong. So the patch is

-       if (!folio_isolate_lru(folio))
+       if (folio_isolate_lru(folio))
                continue;

but at no point was the code *clarified*.

Wouldn't it have been much better to write the new code to be

        if (folio_isolate_lru(folio) < 0)
                continue;

to actually make it clear that this is a "negative error return check".

I've pulled this, but I really think that when somebody notices that
we had a silly bug because of a misunderstanding like this, it's not
just that the bug should be fixed, the code should also be *clarified*
at the same time.

                 Linus

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [GIT PULL] hotfixes for 6.2
@ 2023-02-13 22:08 Andrew Morton
  2023-02-13 22:19 ` Linus Torvalds
  2023-02-13 22:20 ` pr-tracker-bot
  0 siblings, 2 replies; 6+ messages in thread
From: Andrew Morton @ 2023-02-13 22:08 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-mm, mm-commits, linux-kernel


Linus, please merge this batch of fixes, thanks.


The following changes since commit ac86f547ca1002aec2ef66b9e64d03f45bbbfbb9:

  mm: memcg: fix NULL pointer in mem_cgroup_track_foreign_dirty_slowpath() (2023-01-31 16:44:10 -0800)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm tags/mm-hotfixes-stable-2023-02-13-13-50

for you to fetch changes up to ce4d9a1ea35ac5429e822c4106cb2859d5c71f3e:

  of: reserved_mem: Have kmemleak ignore dynamically allocated reserved mem (2023-02-09 15:56:51 -0800)

----------------------------------------------------------------
12 hotfixes, mostly against mm/.  Five of these fixes are cc:stable.

----------------------------------------------------------------
Alexander Mikhalitsyn (1):
      mailmap: add entry for Alexander Mikhalitsyn

Andrew Morton (1):
      revert "squashfs: harden sanity check in squashfs_read_xattr_id_table"

Arnd Bergmann (1):
      mm: extend max struct page size for kmsan

Christophe Leroy (1):
      kasan: fix Oops due to missing calls to kasan_arch_is_ready()

Isaac J. Manjarres (1):
      of: reserved_mem: Have kmemleak ignore dynamically allocated reserved mem

Jeff Xie (1):
      scripts/gdb: fix 'lx-current' for x86

Kefeng Wang (1):
      mm: hwpoison: support recovery from ksm_might_need_to_copy()

Kuan-Ying Lee (1):
      mm/gup: add folio to list when folio_isolate_lru() succeed

Li Lingfeng (1):
      lib: parser: optimize match_NUMBER apis to use local array

Qi Zheng (1):
      mm: shrinkers: fix deadlock in shrinker debugfs

Seth Jenkins (1):
      aio: fix mremap after fork null-deref

Shiyang Ruan (1):
      fsdax: dax_unshare_iter() should return a valid length

 .mailmap                     |  2 ++
 drivers/of/of_reserved_mem.c |  3 ++-
 fs/aio.c                     |  4 ++++
 fs/dax.c                     |  5 +++--
 fs/squashfs/xattr_id.c       |  2 +-
 include/linux/mm.h           | 12 +++++++++---
 include/linux/shrinker.h     |  5 +++--
 lib/parser.c                 | 39 ++++++++++++++++++++-------------------
 mm/gup.c                     |  2 +-
 mm/kasan/common.c            |  3 +++
 mm/kasan/generic.c           |  7 ++++++-
 mm/kasan/shadow.c            | 12 ++++++++++++
 mm/ksm.c                     |  7 +++++--
 mm/memory.c                  |  3 +++
 mm/shrinker_debug.c          | 13 ++++++++-----
 mm/swapfile.c                | 20 ++++++++++++++------
 mm/vmscan.c                  |  6 +++++-
 scripts/gdb/linux/cpus.py    |  2 +-
 18 files changed, 102 insertions(+), 45 deletions(-)


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2023-02-18  3:04 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-17 23:18 [GIT PULL] hotfixes for 6.2 Andrew Morton
2023-02-18  3:04 ` pr-tracker-bot
  -- strict thread matches above, loose matches on Subject: below --
2023-02-13 22:08 Andrew Morton
2023-02-13 22:19 ` Linus Torvalds
2023-02-14  1:26   ` Baolin Wang
2023-02-13 22:20 ` pr-tracker-bot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).