* [PATCH] qed: remove unused num_ooo_add_to_peninsula variable
@ 2023-03-26 0:17 Tom Rix
2023-03-26 7:53 ` Simon Horman
2023-03-28 2:50 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Tom Rix @ 2023-03-26 0:17 UTC (permalink / raw)
To: aelior, manishc, davem, edumazet, kuba, pabeni, nathan, ndesaulniers
Cc: netdev, linux-kernel, llvm, Tom Rix
clang with W=1 reports
drivers/net/ethernet/qlogic/qed/qed_ll2.c:649:6: error: variable
'num_ooo_add_to_peninsula' set but not used [-Werror,-Wunused-but-set-variable]
u32 num_ooo_add_to_peninsula = 0, cid;
^
This variable is not used so remove it.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/net/ethernet/qlogic/qed/qed_ll2.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/qlogic/qed/qed_ll2.c b/drivers/net/ethernet/qlogic/qed/qed_ll2.c
index e5116a86cfbc..717a0b3f89bd 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_ll2.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_ll2.c
@@ -646,13 +646,13 @@ static int qed_ll2_lb_rxq_handler(struct qed_hwfn *p_hwfn,
struct qed_ll2_rx_queue *p_rx = &p_ll2_conn->rx_queue;
u16 packet_length = 0, parse_flags = 0, vlan = 0;
struct qed_ll2_rx_packet *p_pkt = NULL;
- u32 num_ooo_add_to_peninsula = 0, cid;
union core_rx_cqe_union *cqe = NULL;
u16 cq_new_idx = 0, cq_old_idx = 0;
struct qed_ooo_buffer *p_buffer;
struct ooo_opaque *ooo_opq;
u8 placement_offset = 0;
u8 cqe_type;
+ u32 cid;
cq_new_idx = le16_to_cpu(*p_rx->p_fw_cons);
cq_old_idx = qed_chain_get_cons_idx(&p_rx->rcq_chain);
@@ -762,7 +762,6 @@ static int qed_ll2_lb_rxq_handler(struct qed_hwfn *p_hwfn,
cid, ooo_opq->ooo_isle);
break;
case TCP_EVENT_ADD_PEN:
- num_ooo_add_to_peninsula++;
qed_ooo_put_ready_buffer(p_hwfn,
p_hwfn->p_ooo_info,
p_buffer, true);
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] qed: remove unused num_ooo_add_to_peninsula variable
2023-03-26 0:17 [PATCH] qed: remove unused num_ooo_add_to_peninsula variable Tom Rix
@ 2023-03-26 7:53 ` Simon Horman
2023-03-28 2:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2023-03-26 7:53 UTC (permalink / raw)
To: Tom Rix
Cc: aelior, manishc, davem, edumazet, kuba, pabeni, nathan,
ndesaulniers, netdev, linux-kernel, llvm
On Sat, Mar 25, 2023 at 08:17:33PM -0400, Tom Rix wrote:
> clang with W=1 reports
> drivers/net/ethernet/qlogic/qed/qed_ll2.c:649:6: error: variable
> 'num_ooo_add_to_peninsula' set but not used [-Werror,-Wunused-but-set-variable]
> u32 num_ooo_add_to_peninsula = 0, cid;
> ^
> This variable is not used so remove it.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] qed: remove unused num_ooo_add_to_peninsula variable
2023-03-26 0:17 [PATCH] qed: remove unused num_ooo_add_to_peninsula variable Tom Rix
2023-03-26 7:53 ` Simon Horman
@ 2023-03-28 2:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-03-28 2:50 UTC (permalink / raw)
To: Tom Rix
Cc: aelior, manishc, davem, edumazet, kuba, pabeni, nathan,
ndesaulniers, netdev, linux-kernel, llvm
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Sat, 25 Mar 2023 20:17:33 -0400 you wrote:
> clang with W=1 reports
> drivers/net/ethernet/qlogic/qed/qed_ll2.c:649:6: error: variable
> 'num_ooo_add_to_peninsula' set but not used [-Werror,-Wunused-but-set-variable]
> u32 num_ooo_add_to_peninsula = 0, cid;
> ^
> This variable is not used so remove it.
>
> [...]
Here is the summary with links:
- qed: remove unused num_ooo_add_to_peninsula variable
https://git.kernel.org/netdev/net-next/c/2bcc74ffd21a
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-28 2:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-26 0:17 [PATCH] qed: remove unused num_ooo_add_to_peninsula variable Tom Rix
2023-03-26 7:53 ` Simon Horman
2023-03-28 2:50 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).