* [PATCH] RDMA/usnic: Remove redundant pci_clear_master
@ 2023-03-23 11:57 Cai Huoqing
2023-03-29 11:04 ` Leon Romanovsky
0 siblings, 1 reply; 2+ messages in thread
From: Cai Huoqing @ 2023-03-23 11:57 UTC (permalink / raw)
To: cai.huoqing
Cc: Christian Benvenuti, Nelson Escobar, Jason Gunthorpe,
Leon Romanovsky, linux-rdma, linux-kernel
Remove pci_clear_master to simplify the code,
the bus-mastering is also cleared in do_pci_disable_device,
like this:
./drivers/pci/pci.c:2197
static void do_pci_disable_device(struct pci_dev *dev)
{
u16 pci_command;
pci_read_config_word(dev, PCI_COMMAND, &pci_command);
if (pci_command & PCI_COMMAND_MASTER) {
pci_command &= ~PCI_COMMAND_MASTER;
pci_write_config_word(dev, PCI_COMMAND, pci_command);
}
pcibios_disable_device(dev);
}.
And dev->is_busmaster is set to 0 in pci_disable_device.
Signed-off-by: Cai Huoqing <cai.huoqing@linux.dev>
---
drivers/infiniband/hw/usnic/usnic_ib_main.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/infiniband/hw/usnic/usnic_ib_main.c b/drivers/infiniband/hw/usnic/usnic_ib_main.c
index 46653ad56f5a..13b654ddd3cc 100644
--- a/drivers/infiniband/hw/usnic/usnic_ib_main.c
+++ b/drivers/infiniband/hw/usnic/usnic_ib_main.c
@@ -602,7 +602,6 @@ static int usnic_ib_pci_probe(struct pci_dev *pdev,
usnic_vnic_free(vf->vnic);
out_release_regions:
pci_set_drvdata(pdev, NULL);
- pci_clear_master(pdev);
pci_release_regions(pdev);
out_disable_device:
pci_disable_device(pdev);
@@ -623,7 +622,6 @@ static void usnic_ib_pci_remove(struct pci_dev *pdev)
kref_put(&pf->vf_cnt, usnic_ib_undiscover_pf);
usnic_vnic_free(vf->vnic);
pci_set_drvdata(pdev, NULL);
- pci_clear_master(pdev);
pci_release_regions(pdev);
pci_disable_device(pdev);
kfree(vf);
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] RDMA/usnic: Remove redundant pci_clear_master
2023-03-23 11:57 [PATCH] RDMA/usnic: Remove redundant pci_clear_master Cai Huoqing
@ 2023-03-29 11:04 ` Leon Romanovsky
0 siblings, 0 replies; 2+ messages in thread
From: Leon Romanovsky @ 2023-03-29 11:04 UTC (permalink / raw)
To: Cai Huoqing
Cc: Christian Benvenuti, Nelson Escobar, Jason Gunthorpe, linux-rdma,
linux-kernel
On Thu, 23 Mar 2023 19:57:42 +0800, Cai Huoqing wrote:
> Remove pci_clear_master to simplify the code,
> the bus-mastering is also cleared in do_pci_disable_device,
> like this:
> ./drivers/pci/pci.c:2197
> static void do_pci_disable_device(struct pci_dev *dev)
> {
> u16 pci_command;
>
> [...]
Applied, thanks!
[1/1] RDMA/usnic: Remove redundant pci_clear_master
https://git.kernel.org/rdma/rdma/c/fc36ce35e94585
Best regards,
--
Leon Romanovsky <leon@kernel.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-29 11:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-23 11:57 [PATCH] RDMA/usnic: Remove redundant pci_clear_master Cai Huoqing
2023-03-29 11:04 ` Leon Romanovsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).