linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH -next 0/2] arm64: dts: ti: Fixes for Beagleplay SD
@ 2023-03-30 10:59 Vignesh Raghavendra
  2023-03-30 10:59 ` [PATCH 1/2] arm64: configs: defconfig: Make TPS65219 regulator built-in Vignesh Raghavendra
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Vignesh Raghavendra @ 2023-03-30 10:59 UTC (permalink / raw)
  To: Nishanth Menon, Vignesh Raghavendra, Tero Kristo, Rob Herring,
	Krzysztof Kozlowski
  Cc: Catalin Marinas, Will Deacon, Bjorn Andersson, Arnd Bergmann,
	linux-arm-kernel, devicetree, linux-kernel

Couple of fixups on top of ti-next branch:

The SD supply on Beagle is really coming from PMIC LDO1 even though its
controllable via GPIO, hence fix the DT accordingly, this also means
PMIC regulator drivers need to be built-in to allow SD card rootfs

Nishanth,
Better to squash into respetive commits if possible

Vignesh Raghavendra (2):
  arm64: configs: defconfig: Make TPS65219 regulator built-in
  arm64: dts: ti: k3-am625-beagleplay: Fixup SD card supply regulator

 arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts | 2 +-
 arch/arm64/configs/defconfig                   | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

-- 
2.40.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 1/2] arm64: configs: defconfig: Make TPS65219 regulator built-in
  2023-03-30 10:59 [PATCH -next 0/2] arm64: dts: ti: Fixes for Beagleplay SD Vignesh Raghavendra
@ 2023-03-30 10:59 ` Vignesh Raghavendra
  2023-03-30 10:59 ` [PATCH 2/2] arm64: dts: ti: k3-am625-beagleplay: Fixup SD card supply regulator Vignesh Raghavendra
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Vignesh Raghavendra @ 2023-03-30 10:59 UTC (permalink / raw)
  To: Nishanth Menon, Vignesh Raghavendra, Tero Kristo, Rob Herring,
	Krzysztof Kozlowski
  Cc: Catalin Marinas, Will Deacon, Bjorn Andersson, Arnd Bergmann,
	linux-arm-kernel, devicetree, linux-kernel

These regulators control SD card power supply and thus need to be
built-in to support SD card rootfs, which is common for embedded
devkits and EVMs.

bloat-o-meter:
add/remove: 13/0 grow/shrink: 0/0 up/down: 1724/0 (1724)
Total: Before=17068776, After=17070500, chg +0.01%

Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
---
 arch/arm64/configs/defconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index d206a9120ee4..a502d9dc4b57 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -691,7 +691,7 @@ CONFIG_MFD_SPMI_PMIC=y
 CONFIG_MFD_RK808=y
 CONFIG_MFD_SEC_CORE=y
 CONFIG_MFD_SL28CPLD=y
-CONFIG_MFD_TPS65219=m
+CONFIG_MFD_TPS65219=y
 CONFIG_MFD_ROHM_BD718XX=y
 CONFIG_MFD_WCD934X=m
 CONFIG_REGULATOR_FIXED_VOLTAGE=y
@@ -721,7 +721,7 @@ CONFIG_REGULATOR_QCOM_SPMI=y
 CONFIG_REGULATOR_RK808=y
 CONFIG_REGULATOR_S2MPS11=y
 CONFIG_REGULATOR_TPS65132=m
-CONFIG_REGULATOR_TPS65219=m
+CONFIG_REGULATOR_TPS65219=y
 CONFIG_REGULATOR_VCTRL=m
 CONFIG_RC_CORE=m
 CONFIG_RC_DECODERS=y
-- 
2.40.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 2/2] arm64: dts: ti: k3-am625-beagleplay: Fixup SD card supply regulator
  2023-03-30 10:59 [PATCH -next 0/2] arm64: dts: ti: Fixes for Beagleplay SD Vignesh Raghavendra
  2023-03-30 10:59 ` [PATCH 1/2] arm64: configs: defconfig: Make TPS65219 regulator built-in Vignesh Raghavendra
@ 2023-03-30 10:59 ` Vignesh Raghavendra
  2023-03-30 14:59 ` [PATCH -next 0/2] arm64: dts: ti: Fixes for Beagleplay SD Nishanth Menon
  2023-03-30 22:05 ` Nishanth Menon
  3 siblings, 0 replies; 5+ messages in thread
From: Vignesh Raghavendra @ 2023-03-30 10:59 UTC (permalink / raw)
  To: Nishanth Menon, Vignesh Raghavendra, Tero Kristo, Rob Herring,
	Krzysztof Kozlowski
  Cc: Catalin Marinas, Will Deacon, Bjorn Andersson, Arnd Bergmann,
	linux-arm-kernel, devicetree, linux-kernel

The SD card supply is really coming from PMIC LDO1 even though its
controllable via GPIO.

Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
---
 arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts b/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts
index f75e79e54dfc..abf997de4279 100644
--- a/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts
+++ b/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts
@@ -139,7 +139,7 @@ vdd_sd_dv: regulator-5 {
 		regulator-min-microvolt = <1800000>;
 		regulator-max-microvolt = <3300000>;
 		regulator-boot-on;
-		vin-supply = <&vdd_3v3>;
+		vin-supply = <&ldo1_reg>;
 		gpios = <&main_gpio1 49 GPIO_ACTIVE_HIGH>;
 		states = <1800000 0x0>,
 			 <3300000 0x1>;
-- 
2.40.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH -next 0/2] arm64: dts: ti: Fixes for Beagleplay SD
  2023-03-30 10:59 [PATCH -next 0/2] arm64: dts: ti: Fixes for Beagleplay SD Vignesh Raghavendra
  2023-03-30 10:59 ` [PATCH 1/2] arm64: configs: defconfig: Make TPS65219 regulator built-in Vignesh Raghavendra
  2023-03-30 10:59 ` [PATCH 2/2] arm64: dts: ti: k3-am625-beagleplay: Fixup SD card supply regulator Vignesh Raghavendra
@ 2023-03-30 14:59 ` Nishanth Menon
  2023-03-30 22:05 ` Nishanth Menon
  3 siblings, 0 replies; 5+ messages in thread
From: Nishanth Menon @ 2023-03-30 14:59 UTC (permalink / raw)
  To: Vignesh Raghavendra
  Cc: Tero Kristo, Rob Herring, Krzysztof Kozlowski, Catalin Marinas,
	Will Deacon, Bjorn Andersson, Arnd Bergmann, linux-arm-kernel,
	devicetree, linux-kernel

On 16:29-20230330, Vignesh Raghavendra wrote:
> Couple of fixups on top of ti-next branch:
> 
> The SD supply on Beagle is really coming from PMIC LDO1 even though its
> controllable via GPIO, hence fix the DT accordingly, this also means
> PMIC regulator drivers need to be built-in to allow SD card rootfs
> 
> Nishanth,
> Better to squash into respetive commits if possible
> 
> Vignesh Raghavendra (2):
>   arm64: configs: defconfig: Make TPS65219 regulator built-in
>   arm64: dts: ti: k3-am625-beagleplay: Fixup SD card supply regulator
> 
>  arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts | 2 +-
>  arch/arm64/configs/defconfig                   | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> -- 
> 2.40.0
> 
Thanks Vignesh, I will do the fixup.

Chatting with Roger offline, also realized that the board circuitry will
need the following change as it is using a 1/3 voltage divider on SoC's
USB1 as well: I will add this fixup while at it.

diff --git a/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts b/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts
index f75e79e54dfc..a4eb54722743 100644
--- a/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts
+++ b/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts
@@ -484,6 +484,7 @@ &usb0 {
 };
 
 &usbss1 {
+	ti,vbus-divider;
 	status = "okay";
 };
 

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH -next 0/2] arm64: dts: ti: Fixes for Beagleplay SD
  2023-03-30 10:59 [PATCH -next 0/2] arm64: dts: ti: Fixes for Beagleplay SD Vignesh Raghavendra
                   ` (2 preceding siblings ...)
  2023-03-30 14:59 ` [PATCH -next 0/2] arm64: dts: ti: Fixes for Beagleplay SD Nishanth Menon
@ 2023-03-30 22:05 ` Nishanth Menon
  3 siblings, 0 replies; 5+ messages in thread
From: Nishanth Menon @ 2023-03-30 22:05 UTC (permalink / raw)
  To: Tero Kristo, Rob Herring, Krzysztof Kozlowski, Vignesh Raghavendra
  Cc: Nishanth Menon, Catalin Marinas, Will Deacon, Bjorn Andersson,
	Arnd Bergmann, linux-arm-kernel, devicetree, linux-kernel

Hi Vignesh Raghavendra,

On Thu, 30 Mar 2023 16:29:19 +0530, Vignesh Raghavendra wrote:
> Couple of fixups on top of ti-next branch:
> 
> The SD supply on Beagle is really coming from PMIC LDO1 even though its
> controllable via GPIO, hence fix the DT accordingly, this also means
> PMIC regulator drivers need to be built-in to allow SD card rootfs
> 
> Nishanth,
> Better to squash into respetive commits if possible
> 
> [...]

I have fixed the following to branch ti-k3-dts-next and ti-k3-config-next on [1].
I had to rewrite history a bit here, but anyways..

Thank you!

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

[1] git://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2023-03-30 22:07 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-30 10:59 [PATCH -next 0/2] arm64: dts: ti: Fixes for Beagleplay SD Vignesh Raghavendra
2023-03-30 10:59 ` [PATCH 1/2] arm64: configs: defconfig: Make TPS65219 regulator built-in Vignesh Raghavendra
2023-03-30 10:59 ` [PATCH 2/2] arm64: dts: ti: k3-am625-beagleplay: Fixup SD card supply regulator Vignesh Raghavendra
2023-03-30 14:59 ` [PATCH -next 0/2] arm64: dts: ti: Fixes for Beagleplay SD Nishanth Menon
2023-03-30 22:05 ` Nishanth Menon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).