* [irqchip: irq/irqchip-fixes] irqchip/gic: Correctly validate OF quirk descriptors
@ 2023-05-30 10:11 irqchip-bot for Marc Zyngier
0 siblings, 0 replies; only message in thread
From: irqchip-bot for Marc Zyngier @ 2023-05-30 10:11 UTC (permalink / raw)
To: linux-kernel; +Cc: Douglas Anderson, Geert Uytterhoeven, Marc Zyngier, tglx
The following commit has been merged into the irq/irqchip-fixes branch of irqchip:
Commit-ID: 91539341a3b6e9c868024a4292455dae36e6f58c
Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/91539341a3b6e9c868024a4292455dae36e6f58c
Author: Marc Zyngier <maz@kernel.org>
AuthorDate: Tue, 30 May 2023 11:01:22 +01:00
Committer: Marc Zyngier <maz@kernel.org>
CommitterDate: Tue, 30 May 2023 11:01:22 +01:00
irqchip/gic: Correctly validate OF quirk descriptors
When checking for OF quirks, make sure either 'compatible' or 'property'
is set, and give up otherwise.
This avoids non-OF quirks being randomly applied as they don't have any
of the OF data that need checking.
Cc: Douglas Anderson <dianders@chromium.org>
Reported-by: Geert Uytterhoeven <geert+renesas@glider.be>
Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>
Fixes: 44bd78dd2b88 ("irqchip/gic-v3: Disable pseudo NMIs on Mediatek devices w/ firmware issues")
Signed-off-by: Marc Zyngier <maz@kernel.org>
---
drivers/irqchip/irq-gic-common.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/irqchip/irq-gic-common.c b/drivers/irqchip/irq-gic-common.c
index de47b51..afd6a18 100644
--- a/drivers/irqchip/irq-gic-common.c
+++ b/drivers/irqchip/irq-gic-common.c
@@ -16,6 +16,8 @@ void gic_enable_of_quirks(const struct device_node *np,
const struct gic_quirk *quirks, void *data)
{
for (; quirks->desc; quirks++) {
+ if (!quirks->compatible && !quirks->property)
+ continue;
if (quirks->compatible &&
!of_device_is_compatible(np, quirks->compatible))
continue;
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2023-05-30 10:12 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-30 10:11 [irqchip: irq/irqchip-fixes] irqchip/gic: Correctly validate OF quirk descriptors irqchip-bot for Marc Zyngier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).