* [PATCH] arm64: dts: qcom: sc8180x: Move DisplayPort for MMCX
@ 2023-06-12 22:07 Bjorn Andersson
2023-06-12 22:34 ` Dmitry Baryshkov
2023-06-13 22:30 ` Bjorn Andersson
0 siblings, 2 replies; 3+ messages in thread
From: Bjorn Andersson @ 2023-06-12 22:07 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Vinod Koul
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm,
devicetree, linux-kernel
The DisplayPort blocks are powered by MMCX and should be described as
such to ensure that power votes are done on the right resource.
This also solves the problem that sync_state is unaware of the DP
controllers needing MMCX to be kept alive during boot. As such this
change also fixes occasionally seen crashes during boot due to
undervoltage of MMCX.
Fixes: 494dec9b6f54 ("arm64: dts: qcom: sc8180x: Add display and gpu nodes")
Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com>
---
arch/arm64/boot/dts/qcom/sc8180x.dtsi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sc8180x.dtsi b/arch/arm64/boot/dts/qcom/sc8180x.dtsi
index 3de62e26d56a..a7668f9e68d6 100644
--- a/arch/arm64/boot/dts/qcom/sc8180x.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc8180x.dtsi
@@ -2969,7 +2969,7 @@ mdss_dp0: displayport-controller@ae90000 {
#sound-dai-cells = <0>;
operating-points-v2 = <&dp0_opp_table>;
- power-domains = <&rpmhpd SC8180X_CX>;
+ power-domains = <&rpmhpd SC8180X_MMCX>;
status = "disabled";
@@ -3043,7 +3043,7 @@ mdss_dp1: displayport-controller@ae98000 {
#sound-dai-cells = <0>;
operating-points-v2 = <&dp0_opp_table>;
- power-domains = <&rpmhpd SC8180X_CX>;
+ power-domains = <&rpmhpd SC8180X_MMCX>;
status = "disabled";
@@ -3117,7 +3117,7 @@ mdss_edp: displayport-controller@ae9a000 {
#sound-dai-cells = <0>;
operating-points-v2 = <&edp_opp_table>;
- power-domains = <&rpmhpd SC8180X_CX>;
+ power-domains = <&rpmhpd SC8180X_MMCX>;
status = "disabled";
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sc8180x: Move DisplayPort for MMCX
2023-06-12 22:07 [PATCH] arm64: dts: qcom: sc8180x: Move DisplayPort for MMCX Bjorn Andersson
@ 2023-06-12 22:34 ` Dmitry Baryshkov
2023-06-13 22:30 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Baryshkov @ 2023-06-12 22:34 UTC (permalink / raw)
To: Bjorn Andersson, Bjorn Andersson, Konrad Dybcio, Vinod Koul
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm,
devicetree, linux-kernel
On 13/06/2023 01:07, Bjorn Andersson wrote:
> The DisplayPort blocks are powered by MMCX and should be described as
> such to ensure that power votes are done on the right resource.
>
> This also solves the problem that sync_state is unaware of the DP
> controllers needing MMCX to be kept alive during boot. As such this
> change also fixes occasionally seen crashes during boot due to
> undervoltage of MMCX.
>
> Fixes: 494dec9b6f54 ("arm64: dts: qcom: sc8180x: Add display and gpu nodes")
> Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com>
> ---
> arch/arm64/boot/dts/qcom/sc8180x.dtsi | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sc8180x: Move DisplayPort for MMCX
2023-06-12 22:07 [PATCH] arm64: dts: qcom: sc8180x: Move DisplayPort for MMCX Bjorn Andersson
2023-06-12 22:34 ` Dmitry Baryshkov
@ 2023-06-13 22:30 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2023-06-13 22:30 UTC (permalink / raw)
To: Vinod Koul, Konrad Dybcio, Bjorn Andersson
Cc: Rob Herring, linux-arm-msm, Conor Dooley, Krzysztof Kozlowski,
devicetree, linux-kernel
On Mon, 12 Jun 2023 15:07:39 -0700, Bjorn Andersson wrote:
> The DisplayPort blocks are powered by MMCX and should be described as
> such to ensure that power votes are done on the right resource.
>
> This also solves the problem that sync_state is unaware of the DP
> controllers needing MMCX to be kept alive during boot. As such this
> change also fixes occasionally seen crashes during boot due to
> undervoltage of MMCX.
>
> [...]
Applied, thanks!
[1/1] arm64: dts: qcom: sc8180x: Move DisplayPort for MMCX
commit: 2d7b1a31ffb865d1f8e95e985cdbd0df72f671cf
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-06-13 22:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-12 22:07 [PATCH] arm64: dts: qcom: sc8180x: Move DisplayPort for MMCX Bjorn Andersson
2023-06-12 22:34 ` Dmitry Baryshkov
2023-06-13 22:30 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).