linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH V3 0/3] Minor updates in the IPQ5332 DTS files
@ 2023-05-19 13:38 Kathiravan T
  2023-05-19 13:38 ` [PATCH V3 1/3] arm64: dts: qcom: ipq5332: rename mi01.2 dts to rdp441 Kathiravan T
                   ` (4 more replies)
  0 siblings, 5 replies; 7+ messages in thread
From: Kathiravan T @ 2023-05-19 13:38 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree,
	linux-kernel
  Cc: Kathiravan T

Rename the MI01.2 DTS after Reference Design Platform(RDP) number to align
with ipq5332-rdp468.dts, add UART1 node and reserve memory for U-boot
and SBL to avoid losing the RAM contents which will be used in post
morterm analysis.

Kathiravan T (3):
  arm64: dts: qcom: ipq5332: rename mi01.2 dts to rdp441
  arm64: dts: qcom: ipq5332: define UART1
  arm64: dts: qcom: ipq5332: add few more reserved memory region

 arch/arm64/boot/dts/qcom/Makefile             |  2 +-
 ...{ipq5332-mi01.2.dts => ipq5332-rdp441.dts} |  0
 arch/arm64/boot/dts/qcom/ipq5332.dtsi         | 24 ++++++++++++++++++-
 3 files changed, 24 insertions(+), 2 deletions(-)
 rename arch/arm64/boot/dts/qcom/{ipq5332-mi01.2.dts => ipq5332-rdp441.dts} (100%)

-- 
2.17.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH V3 1/3] arm64: dts: qcom: ipq5332: rename mi01.2 dts to rdp441
  2023-05-19 13:38 [PATCH V3 0/3] Minor updates in the IPQ5332 DTS files Kathiravan T
@ 2023-05-19 13:38 ` Kathiravan T
  2023-05-19 13:38 ` [PATCH V3 2/3] arm64: dts: qcom: ipq5332: define UART1 Kathiravan T
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 7+ messages in thread
From: Kathiravan T @ 2023-05-19 13:38 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree,
	linux-kernel
  Cc: Kathiravan T

To align with ipq5332-rdp468.dts, lets rename the mi01.2 dts as well to
ipq5332-rdp441.dts.

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com>
---
Changes in V3:
	- No changes
Changes in V2:
	- Pick up R-b tag

 arch/arm64/boot/dts/qcom/Makefile                               | 2 +-
 .../boot/dts/qcom/{ipq5332-mi01.2.dts => ipq5332-rdp441.dts}    | 0
 2 files changed, 1 insertion(+), 1 deletion(-)
 rename arch/arm64/boot/dts/qcom/{ipq5332-mi01.2.dts => ipq5332-rdp441.dts} (100%)

diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
index e311ba675f35..bd09e2029df7 100644
--- a/arch/arm64/boot/dts/qcom/Makefile
+++ b/arch/arm64/boot/dts/qcom/Makefile
@@ -3,7 +3,7 @@ dtb-$(CONFIG_ARCH_QCOM)	+= apq8016-sbc.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= apq8094-sony-xperia-kitakami-karin_windy.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= apq8096-db820c.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= apq8096-ifc6640.dtb
-dtb-$(CONFIG_ARCH_QCOM)	+= ipq5332-mi01.2.dtb
+dtb-$(CONFIG_ARCH_QCOM)	+= ipq5332-rdp441.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= ipq5332-rdp468.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= ipq6018-cp01-c1.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= ipq8074-hk01.dtb
diff --git a/arch/arm64/boot/dts/qcom/ipq5332-mi01.2.dts b/arch/arm64/boot/dts/qcom/ipq5332-rdp441.dts
similarity index 100%
rename from arch/arm64/boot/dts/qcom/ipq5332-mi01.2.dts
rename to arch/arm64/boot/dts/qcom/ipq5332-rdp441.dts
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH V3 2/3] arm64: dts: qcom: ipq5332: define UART1
  2023-05-19 13:38 [PATCH V3 0/3] Minor updates in the IPQ5332 DTS files Kathiravan T
  2023-05-19 13:38 ` [PATCH V3 1/3] arm64: dts: qcom: ipq5332: rename mi01.2 dts to rdp441 Kathiravan T
@ 2023-05-19 13:38 ` Kathiravan T
  2023-05-19 13:38 ` [PATCH V3 3/3] arm64: dts: qcom: ipq5332: add few more reserved memory region Kathiravan T
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 7+ messages in thread
From: Kathiravan T @ 2023-05-19 13:38 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree,
	linux-kernel
  Cc: Kathiravan T

Add the definition for the UART1 found on IPQ5332 SoC.

Reviewed-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com>
---
Changes in V3:
	- Pick up R-b tag
Changes in V2:
	- Added the dma and dma-names property
	- Didn't pick up the R-b tag due to above change

 arch/arm64/boot/dts/qcom/ipq5332.dtsi | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
index 12e0e179e139..753581e60604 100644
--- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
@@ -218,6 +218,18 @@
 			status = "disabled";
 		};
 
+		blsp1_uart1: serial@78b0000 {
+			compatible = "qcom,msm-uartdm-v1.4", "qcom,msm-uartdm";
+			reg = <0x078b0000 0x200>;
+			interrupts = <GIC_SPI 291 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&gcc GCC_BLSP1_UART2_APPS_CLK>,
+				 <&gcc GCC_BLSP1_AHB_CLK>;
+			clock-names = "core", "iface";
+			dmas = <&blsp_dma 2>, <&blsp_dma 3>;
+			dma-names = "tx", "rx";
+			status = "disabled";
+		};
+
 		blsp1_spi0: spi@78b5000 {
 			compatible = "qcom,spi-qup-v2.2.1";
 			reg = <0x078b5000 0x600>;
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH V3 3/3] arm64: dts: qcom: ipq5332: add few more reserved memory region
  2023-05-19 13:38 [PATCH V3 0/3] Minor updates in the IPQ5332 DTS files Kathiravan T
  2023-05-19 13:38 ` [PATCH V3 1/3] arm64: dts: qcom: ipq5332: rename mi01.2 dts to rdp441 Kathiravan T
  2023-05-19 13:38 ` [PATCH V3 2/3] arm64: dts: qcom: ipq5332: define UART1 Kathiravan T
@ 2023-05-19 13:38 ` Kathiravan T
  2023-05-30  2:08 ` [PATCH V3 0/3] Minor updates in the IPQ5332 DTS files Kathiravan T
  2023-06-13 22:30 ` (subset) " Bjorn Andersson
  4 siblings, 0 replies; 7+ messages in thread
From: Kathiravan T @ 2023-05-19 13:38 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree,
	linux-kernel
  Cc: Kathiravan T

In IPQ SoCs, bootloader will collect the system RAM contents upon crash for
the post morterm analysis. If we don't reserve the memory region used by
bootloader, obviously linux will consume it and upon next boot on crash,
bootloader will be loaded in the same region, which will lead to loose some
of the data, sometimes we may miss out critical information. So lets
reserve the region used by the bootloader.

Similarly SBL copies some data into the reserved region and it will be
used in the crash scenario. So reserve 1MB for SBL as well.

While at it, drop the size padding in the smem memory region.

Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com>
---
Changes in V3:
	- s/u-boot/bootloader/ in commit msg and in the code as
	  suggested by Bhupesh
Changes in V2:
	- Dropped the size padding in smem memory region
 arch/arm64/boot/dts/qcom/ipq5332.dtsi | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
index 753581e60604..ba1d20fd8059 100644
--- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
@@ -114,6 +114,16 @@
 		#size-cells = <2>;
 		ranges;
 
+		bootloader@4a100000 {
+			reg = <0x0 0x4a100000 0x0 0x400000>;
+			no-map;
+		};
+
+		sbl@4a500000 {
+			reg = <0x0 0x4a500000 0x0 0x100000>;
+			no-map;
+		};
+
 		tz_mem: tz@4a600000 {
 			reg = <0x0 0x4a600000 0x0 0x200000>;
 			no-map;
@@ -121,7 +131,7 @@
 
 		smem@4a800000 {
 			compatible = "qcom,smem";
-			reg = <0x0 0x4a800000 0x0 0x00100000>;
+			reg = <0x0 0x4a800000 0x0 0x100000>;
 			no-map;
 
 			hwlocks = <&tcsr_mutex 0>;
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH V3 0/3] Minor updates in the IPQ5332 DTS files
  2023-05-19 13:38 [PATCH V3 0/3] Minor updates in the IPQ5332 DTS files Kathiravan T
                   ` (2 preceding siblings ...)
  2023-05-19 13:38 ` [PATCH V3 3/3] arm64: dts: qcom: ipq5332: add few more reserved memory region Kathiravan T
@ 2023-05-30  2:08 ` Kathiravan T
  2023-06-09 10:34   ` Kathiravan T
  2023-06-13 22:30 ` (subset) " Bjorn Andersson
  4 siblings, 1 reply; 7+ messages in thread
From: Kathiravan T @ 2023-05-30  2:08 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree,
	linux-kernel


On 5/19/2023 7:08 PM, Kathiravan T wrote:
> Rename the MI01.2 DTS after Reference Design Platform(RDP) number to align
> with ipq5332-rdp468.dts, add UART1 node and reserve memory for U-boot
> and SBL to avoid losing the RAM contents which will be used in post
> morterm analysis.


Gentle Reminder...


>
> Kathiravan T (3):
>    arm64: dts: qcom: ipq5332: rename mi01.2 dts to rdp441
>    arm64: dts: qcom: ipq5332: define UART1
>    arm64: dts: qcom: ipq5332: add few more reserved memory region
>
>   arch/arm64/boot/dts/qcom/Makefile             |  2 +-
>   ...{ipq5332-mi01.2.dts => ipq5332-rdp441.dts} |  0
>   arch/arm64/boot/dts/qcom/ipq5332.dtsi         | 24 ++++++++++++++++++-
>   3 files changed, 24 insertions(+), 2 deletions(-)
>   rename arch/arm64/boot/dts/qcom/{ipq5332-mi01.2.dts => ipq5332-rdp441.dts} (100%)
>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH V3 0/3] Minor updates in the IPQ5332 DTS files
  2023-05-30  2:08 ` [PATCH V3 0/3] Minor updates in the IPQ5332 DTS files Kathiravan T
@ 2023-06-09 10:34   ` Kathiravan T
  0 siblings, 0 replies; 7+ messages in thread
From: Kathiravan T @ 2023-06-09 10:34 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree,
	linux-kernel


On 5/30/2023 7:38 AM, Kathiravan T wrote:
>
> On 5/19/2023 7:08 PM, Kathiravan T wrote:
>> Rename the MI01.2 DTS after Reference Design Platform(RDP) number to 
>> align
>> with ipq5332-rdp468.dts, add UART1 node and reserve memory for U-boot
>> and SBL to avoid losing the RAM contents which will be used in post
>> morterm analysis.
>
>
> Gentle Reminder...


Bjorn, can this series picked up for v6.5? Since this is pending for 
long time...


>
>
>>
>> Kathiravan T (3):
>>    arm64: dts: qcom: ipq5332: rename mi01.2 dts to rdp441
>>    arm64: dts: qcom: ipq5332: define UART1
>>    arm64: dts: qcom: ipq5332: add few more reserved memory region
>>
>>   arch/arm64/boot/dts/qcom/Makefile             |  2 +-
>>   ...{ipq5332-mi01.2.dts => ipq5332-rdp441.dts} |  0
>>   arch/arm64/boot/dts/qcom/ipq5332.dtsi         | 24 ++++++++++++++++++-
>>   3 files changed, 24 insertions(+), 2 deletions(-)
>>   rename arch/arm64/boot/dts/qcom/{ipq5332-mi01.2.dts => 
>> ipq5332-rdp441.dts} (100%)
>>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: (subset) [PATCH V3 0/3] Minor updates in the IPQ5332 DTS files
  2023-05-19 13:38 [PATCH V3 0/3] Minor updates in the IPQ5332 DTS files Kathiravan T
                   ` (3 preceding siblings ...)
  2023-05-30  2:08 ` [PATCH V3 0/3] Minor updates in the IPQ5332 DTS files Kathiravan T
@ 2023-06-13 22:30 ` Bjorn Andersson
  4 siblings, 0 replies; 7+ messages in thread
From: Bjorn Andersson @ 2023-06-13 22:30 UTC (permalink / raw)
  To: Kathiravan T, Rob Herring, linux-arm-msm, Andy Gross,
	Conor Dooley, Krzysztof Kozlowski, Konrad Dybcio, devicetree,
	linux-kernel

On Fri, 19 May 2023 19:08:41 +0530, Kathiravan T wrote:
> Rename the MI01.2 DTS after Reference Design Platform(RDP) number to align
> with ipq5332-rdp468.dts, add UART1 node and reserve memory for U-boot
> and SBL to avoid losing the RAM contents which will be used in post
> morterm analysis.
> 
> Kathiravan T (3):
>   arm64: dts: qcom: ipq5332: rename mi01.2 dts to rdp441
>   arm64: dts: qcom: ipq5332: define UART1
>   arm64: dts: qcom: ipq5332: add few more reserved memory region
> 
> [...]

Applied, thanks!

[1/3] arm64: dts: qcom: ipq5332: rename mi01.2 dts to rdp441
      commit: b59cd2902c58969230a8aca67a10ac3fbde0af15
[2/3] arm64: dts: qcom: ipq5332: define UART1
      commit: 66d141a15c19f89e7e259e57a007550a253e03d2
[3/3] arm64: dts: qcom: ipq5332: add few more reserved memory region
      commit: 0196b041aeec788e1bc516b6d24d9c59ea59b1a6

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2023-06-13 22:28 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-19 13:38 [PATCH V3 0/3] Minor updates in the IPQ5332 DTS files Kathiravan T
2023-05-19 13:38 ` [PATCH V3 1/3] arm64: dts: qcom: ipq5332: rename mi01.2 dts to rdp441 Kathiravan T
2023-05-19 13:38 ` [PATCH V3 2/3] arm64: dts: qcom: ipq5332: define UART1 Kathiravan T
2023-05-19 13:38 ` [PATCH V3 3/3] arm64: dts: qcom: ipq5332: add few more reserved memory region Kathiravan T
2023-05-30  2:08 ` [PATCH V3 0/3] Minor updates in the IPQ5332 DTS files Kathiravan T
2023-06-09 10:34   ` Kathiravan T
2023-06-13 22:30 ` (subset) " Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).