* [PATCH V2 0/4] Remove WARN_ON in save_processor_state
@ 2023-06-09 7:50 Song Shuai
2023-06-09 7:50 ` [PATCH V2 1/4] ARM: hibernate: remove " Song Shuai
` (6 more replies)
0 siblings, 7 replies; 11+ messages in thread
From: Song Shuai @ 2023-06-09 7:50 UTC (permalink / raw)
To: catalin.marinas, will, paul.walmsley, palmer, aou, chris,
jcmvbkbc, songshuaishuai, steven.price, vincenzo.frascino,
leyfoon.tan, mason.huo, jeeheng.sia, conor.dooley, ajones
Cc: linux, linux-arm-kernel, linux-kernel, linux-riscv
During hibernation or restoration, freeze_secondary_cpus
checks num_online_cpus via BUG_ON, and the subsequent
save_processor_state also does the checking with WARN_ON.
In the case of CONFIG_PM_SLEEP_SMP=n, freeze_secondary_cpus
is not defined, but the sole possible condition to disable
CONFIG_PM_SLEEP_SMP is !SMP where num_online_cpus is always 1.
We also don't have to check it in save_processor_state.
So remove the unnecessary checking in save_processor_state
for ARM,arm64,riscv,xtensa architechtures.
Changes since V1:
https://lore.kernel.org/linux-riscv/20230525025555.24104-1-songshuaishuai@tinylab.org/
- supplement the case of CONFIG_PM_SLEEP_SMP=n in commit message as Will suggests
Song Shuai (4):
ARM: hibernate: remove WARN_ON in save_processor_state
arm64: hibernate: remove WARN_ON in save_processor_state
riscv: hibernate: remove WARN_ON in save_processor_state
xtensa: hibernate: remove WARN_ON in save_processor_state
arch/arm/kernel/hibernate.c | 1 -
arch/arm64/kernel/hibernate.c | 1 -
arch/riscv/kernel/hibernate.c | 1 -
arch/xtensa/kernel/hibernate.c | 1 -
4 files changed, 4 deletions(-)
--
2.20.1
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH V2 1/4] ARM: hibernate: remove WARN_ON in save_processor_state
2023-06-09 7:50 [PATCH V2 0/4] Remove WARN_ON in save_processor_state Song Shuai
@ 2023-06-09 7:50 ` Song Shuai
2023-06-09 7:50 ` [PATCH V2 2/4] arm64: " Song Shuai
` (5 subsequent siblings)
6 siblings, 0 replies; 11+ messages in thread
From: Song Shuai @ 2023-06-09 7:50 UTC (permalink / raw)
To: catalin.marinas, will, paul.walmsley, palmer, aou, chris,
jcmvbkbc, songshuaishuai, steven.price, vincenzo.frascino,
leyfoon.tan, mason.huo, jeeheng.sia, conor.dooley, ajones
Cc: linux, linux-arm-kernel, linux-kernel, linux-riscv
During hibernation or restoration, freeze_secondary_cpus
checks num_online_cpus via BUG_ON, and the subsequent
save_processor_state also does the checking with WARN_ON.
In the case of CONFIG_PM_SLEEP_SMP=n, freeze_secondary_cpus
is not defined, but the sole possible condition to disable
CONFIG_PM_SLEEP_SMP is !SMP where num_online_cpus is always 1.
We also don't have to check it in save_processor_state.
So remove the unnecessary checking in save_processor_state.
Signed-off-by: Song Shuai <songshuaishuai@tinylab.org>
---
arch/arm/kernel/hibernate.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/kernel/hibernate.c b/arch/arm/kernel/hibernate.c
index 2373020af965..84abccf3221a 100644
--- a/arch/arm/kernel/hibernate.c
+++ b/arch/arm/kernel/hibernate.c
@@ -33,7 +33,6 @@ int pfn_is_nosave(unsigned long pfn)
void notrace save_processor_state(void)
{
- WARN_ON(num_online_cpus() != 1);
local_fiq_disable();
}
--
2.20.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH V2 2/4] arm64: hibernate: remove WARN_ON in save_processor_state
2023-06-09 7:50 [PATCH V2 0/4] Remove WARN_ON in save_processor_state Song Shuai
2023-06-09 7:50 ` [PATCH V2 1/4] ARM: hibernate: remove " Song Shuai
@ 2023-06-09 7:50 ` Song Shuai
2023-06-09 10:23 ` Will Deacon
2023-06-09 7:50 ` [PATCH V2 3/4] riscv: " Song Shuai
` (4 subsequent siblings)
6 siblings, 1 reply; 11+ messages in thread
From: Song Shuai @ 2023-06-09 7:50 UTC (permalink / raw)
To: catalin.marinas, will, paul.walmsley, palmer, aou, chris,
jcmvbkbc, songshuaishuai, steven.price, vincenzo.frascino,
leyfoon.tan, mason.huo, jeeheng.sia, conor.dooley, ajones
Cc: linux, linux-arm-kernel, linux-kernel, linux-riscv
During hibernation or restoration, freeze_secondary_cpus
checks num_online_cpus via BUG_ON, and the subsequent
save_processor_state also does the checking with WARN_ON.
In the case of CONFIG_PM_SLEEP_SMP=n, freeze_secondary_cpus
is not defined, but the sole possible condition to disable
CONFIG_PM_SLEEP_SMP is !SMP where num_online_cpus is always 1.
We also don't have to check it in save_processor_state.
So remove the unnecessary checking in save_processor_state.
Signed-off-by: Song Shuai <songshuaishuai@tinylab.org>
---
arch/arm64/kernel/hibernate.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/kernel/hibernate.c b/arch/arm64/kernel/hibernate.c
index 788597a6b6a2..02870beb271e 100644
--- a/arch/arm64/kernel/hibernate.c
+++ b/arch/arm64/kernel/hibernate.c
@@ -99,7 +99,6 @@ int pfn_is_nosave(unsigned long pfn)
void notrace save_processor_state(void)
{
- WARN_ON(num_online_cpus() != 1);
}
void notrace restore_processor_state(void)
--
2.20.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH V2 3/4] riscv: hibernate: remove WARN_ON in save_processor_state
2023-06-09 7:50 [PATCH V2 0/4] Remove WARN_ON in save_processor_state Song Shuai
2023-06-09 7:50 ` [PATCH V2 1/4] ARM: hibernate: remove " Song Shuai
2023-06-09 7:50 ` [PATCH V2 2/4] arm64: " Song Shuai
@ 2023-06-09 7:50 ` Song Shuai
2023-06-10 15:39 ` Conor Dooley
2023-06-09 7:50 ` [PATCH V2 4/4] xtensa: " Song Shuai
` (3 subsequent siblings)
6 siblings, 1 reply; 11+ messages in thread
From: Song Shuai @ 2023-06-09 7:50 UTC (permalink / raw)
To: catalin.marinas, will, paul.walmsley, palmer, aou, chris,
jcmvbkbc, songshuaishuai, steven.price, vincenzo.frascino,
leyfoon.tan, mason.huo, jeeheng.sia, conor.dooley, ajones
Cc: linux, linux-arm-kernel, linux-kernel, linux-riscv
During hibernation or restoration, freeze_secondary_cpus
checks num_online_cpus via BUG_ON, and the subsequent
save_processor_state also does the checking with WARN_ON.
In the case of CONFIG_PM_SLEEP_SMP=n, freeze_secondary_cpus
is not defined, but the sole possible condition to disable
CONFIG_PM_SLEEP_SMP is !SMP where num_online_cpus is always 1.
We also don't have to check it in save_processor_state.
So remove the unnecessary checking in save_processor_state.
Fixes: c0317210012e ("RISC-V: Add arch functions to support hibernation/suspend-to-disk")
Signed-off-by: Song Shuai <songshuaishuai@tinylab.org>
---
arch/riscv/kernel/hibernate.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/riscv/kernel/hibernate.c b/arch/riscv/kernel/hibernate.c
index 395f835f067c..86f1c9ab6b0b 100644
--- a/arch/riscv/kernel/hibernate.c
+++ b/arch/riscv/kernel/hibernate.c
@@ -119,7 +119,6 @@ int pfn_is_nosave(unsigned long pfn)
void notrace save_processor_state(void)
{
- WARN_ON(num_online_cpus() != 1);
}
void notrace restore_processor_state(void)
--
2.20.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH V2 4/4] xtensa: hibernate: remove WARN_ON in save_processor_state
2023-06-09 7:50 [PATCH V2 0/4] Remove WARN_ON in save_processor_state Song Shuai
` (2 preceding siblings ...)
2023-06-09 7:50 ` [PATCH V2 3/4] riscv: " Song Shuai
@ 2023-06-09 7:50 ` Song Shuai
2023-06-21 15:51 ` (subset) [PATCH V2 0/4] Remove " Catalin Marinas
` (2 subsequent siblings)
6 siblings, 0 replies; 11+ messages in thread
From: Song Shuai @ 2023-06-09 7:50 UTC (permalink / raw)
To: catalin.marinas, will, paul.walmsley, palmer, aou, chris,
jcmvbkbc, songshuaishuai, steven.price, vincenzo.frascino,
leyfoon.tan, mason.huo, jeeheng.sia, conor.dooley, ajones
Cc: linux, linux-arm-kernel, linux-kernel, linux-riscv
During hibernation or restoration, freeze_secondary_cpus
checks num_online_cpus via BUG_ON, and the subsequent
save_processor_state also does the checking with WARN_ON.
In the case of CONFIG_PM_SLEEP_SMP=n, freeze_secondary_cpus
is not defined, but the sole possible condition to disable
CONFIG_PM_SLEEP_SMP is !SMP where num_online_cpus is always 1.
We also don't have to check it in save_processor_state.
So remove the unnecessary checking in save_processor_state.
Signed-off-by: Song Shuai <songshuaishuai@tinylab.org>
---
arch/xtensa/kernel/hibernate.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/xtensa/kernel/hibernate.c b/arch/xtensa/kernel/hibernate.c
index 06984327d6e2..314602bbf431 100644
--- a/arch/xtensa/kernel/hibernate.c
+++ b/arch/xtensa/kernel/hibernate.c
@@ -14,7 +14,6 @@ int pfn_is_nosave(unsigned long pfn)
void notrace save_processor_state(void)
{
- WARN_ON(num_online_cpus() != 1);
#if XTENSA_HAVE_COPROCESSORS
local_coprocessors_flush_release_all();
#endif
--
2.20.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH V2 2/4] arm64: hibernate: remove WARN_ON in save_processor_state
2023-06-09 7:50 ` [PATCH V2 2/4] arm64: " Song Shuai
@ 2023-06-09 10:23 ` Will Deacon
0 siblings, 0 replies; 11+ messages in thread
From: Will Deacon @ 2023-06-09 10:23 UTC (permalink / raw)
To: Song Shuai
Cc: catalin.marinas, paul.walmsley, palmer, aou, chris, jcmvbkbc,
steven.price, vincenzo.frascino, leyfoon.tan, mason.huo,
jeeheng.sia, conor.dooley, ajones, linux, linux-arm-kernel,
linux-kernel, linux-riscv
On Fri, Jun 09, 2023 at 03:50:47PM +0800, Song Shuai wrote:
> During hibernation or restoration, freeze_secondary_cpus
> checks num_online_cpus via BUG_ON, and the subsequent
> save_processor_state also does the checking with WARN_ON.
>
> In the case of CONFIG_PM_SLEEP_SMP=n, freeze_secondary_cpus
> is not defined, but the sole possible condition to disable
> CONFIG_PM_SLEEP_SMP is !SMP where num_online_cpus is always 1.
> We also don't have to check it in save_processor_state.
>
> So remove the unnecessary checking in save_processor_state.
>
> Signed-off-by: Song Shuai <songshuaishuai@tinylab.org>
> ---
> arch/arm64/kernel/hibernate.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/kernel/hibernate.c b/arch/arm64/kernel/hibernate.c
> index 788597a6b6a2..02870beb271e 100644
> --- a/arch/arm64/kernel/hibernate.c
> +++ b/arch/arm64/kernel/hibernate.c
> @@ -99,7 +99,6 @@ int pfn_is_nosave(unsigned long pfn)
>
> void notrace save_processor_state(void)
> {
> - WARN_ON(num_online_cpus() != 1);
> }
>
> void notrace restore_processor_state(void)
Acked-by: Will Deacon <will@kernel.org>
Thanks!
Will
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH V2 3/4] riscv: hibernate: remove WARN_ON in save_processor_state
2023-06-09 7:50 ` [PATCH V2 3/4] riscv: " Song Shuai
@ 2023-06-10 15:39 ` Conor Dooley
0 siblings, 0 replies; 11+ messages in thread
From: Conor Dooley @ 2023-06-10 15:39 UTC (permalink / raw)
To: Song Shuai
Cc: catalin.marinas, will, paul.walmsley, palmer, aou, chris,
jcmvbkbc, steven.price, vincenzo.frascino, leyfoon.tan,
mason.huo, jeeheng.sia, conor.dooley, ajones, linux,
linux-arm-kernel, linux-kernel, linux-riscv
[-- Attachment #1: Type: text/plain, Size: 1600 bytes --]
On Fri, Jun 09, 2023 at 03:50:48PM +0800, Song Shuai wrote:
> During hibernation or restoration, freeze_secondary_cpus
> checks num_online_cpus via BUG_ON, and the subsequent
> save_processor_state also does the checking with WARN_ON.
>
> In the case of CONFIG_PM_SLEEP_SMP=n, freeze_secondary_cpus
> is not defined, but the sole possible condition to disable
> CONFIG_PM_SLEEP_SMP is !SMP where num_online_cpus is always 1.
> We also don't have to check it in save_processor_state.
>
> So remove the unnecessary checking in save_processor_state.
In the future, please write function with a () in commit
messages, so freeze_secondary_cpus() etc.
Otherwise,
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Thanks,
Conor.
>
> Fixes: c0317210012e ("RISC-V: Add arch functions to support hibernation/suspend-to-disk")
> Signed-off-by: Song Shuai <songshuaishuai@tinylab.org>
> ---
> arch/riscv/kernel/hibernate.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/riscv/kernel/hibernate.c b/arch/riscv/kernel/hibernate.c
> index 395f835f067c..86f1c9ab6b0b 100644
> --- a/arch/riscv/kernel/hibernate.c
> +++ b/arch/riscv/kernel/hibernate.c
> @@ -119,7 +119,6 @@ int pfn_is_nosave(unsigned long pfn)
>
> void notrace save_processor_state(void)
> {
> - WARN_ON(num_online_cpus() != 1);
> }
>
> void notrace restore_processor_state(void)
> --
> 2.20.1
>
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: (subset) [PATCH V2 0/4] Remove WARN_ON in save_processor_state
2023-06-09 7:50 [PATCH V2 0/4] Remove WARN_ON in save_processor_state Song Shuai
` (3 preceding siblings ...)
2023-06-09 7:50 ` [PATCH V2 4/4] xtensa: " Song Shuai
@ 2023-06-21 15:51 ` Catalin Marinas
2023-06-22 18:28 ` Palmer Dabbelt
2023-06-25 23:17 ` Palmer Dabbelt
2023-06-25 23:20 ` patchwork-bot+linux-riscv
6 siblings, 1 reply; 11+ messages in thread
From: Catalin Marinas @ 2023-06-21 15:51 UTC (permalink / raw)
To: will, paul.walmsley, palmer, aou, chris, jcmvbkbc, steven.price,
vincenzo.frascino, leyfoon.tan, mason.huo, jeeheng.sia,
conor.dooley, ajones, Song Shuai
Cc: linux, linux-arm-kernel, linux-kernel, linux-riscv
On Fri, 09 Jun 2023 15:50:45 +0800, Song Shuai wrote:
> During hibernation or restoration, freeze_secondary_cpus
> checks num_online_cpus via BUG_ON, and the subsequent
> save_processor_state also does the checking with WARN_ON.
>
> In the case of CONFIG_PM_SLEEP_SMP=n, freeze_secondary_cpus
> is not defined, but the sole possible condition to disable
> CONFIG_PM_SLEEP_SMP is !SMP where num_online_cpus is always 1.
> We also don't have to check it in save_processor_state.
>
> [...]
Applied to arm64 (for-next/misc), thanks!
I couldn't tell whether this series would go in as a whole but given
that the patches are independent, I picked up the arm64 one.
[2/4] arm64: hibernate: remove WARN_ON in save_processor_state
https://git.kernel.org/arm64/c/615af0021a61
--
Catalin
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: (subset) [PATCH V2 0/4] Remove WARN_ON in save_processor_state
2023-06-21 15:51 ` (subset) [PATCH V2 0/4] Remove " Catalin Marinas
@ 2023-06-22 18:28 ` Palmer Dabbelt
0 siblings, 0 replies; 11+ messages in thread
From: Palmer Dabbelt @ 2023-06-22 18:28 UTC (permalink / raw)
To: Catalin Marinas
Cc: Will Deacon, Paul Walmsley, aou, chris, jcmvbkbc, steven.price,
vincenzo.frascino, leyfoon.tan, mason.huo, jeeheng.sia,
Conor Dooley, ajones, songshuaishuai, linux, linux-arm-kernel,
linux-kernel, linux-riscv
On Wed, 21 Jun 2023 08:51:43 PDT (-0700), Catalin Marinas wrote:
> On Fri, 09 Jun 2023 15:50:45 +0800, Song Shuai wrote:
>> During hibernation or restoration, freeze_secondary_cpus
>> checks num_online_cpus via BUG_ON, and the subsequent
>> save_processor_state also does the checking with WARN_ON.
>>
>> In the case of CONFIG_PM_SLEEP_SMP=n, freeze_secondary_cpus
>> is not defined, but the sole possible condition to disable
>> CONFIG_PM_SLEEP_SMP is !SMP where num_online_cpus is always 1.
>> We also don't have to check it in save_processor_state.
>>
>> [...]
>
> Applied to arm64 (for-next/misc), thanks!
>
> I couldn't tell whether this series would go in as a whole but given
> that the patches are independent, I picked up the arm64 one.
>
> [2/4] arm64: hibernate: remove WARN_ON in save_processor_state
> https://git.kernel.org/arm64/c/615af0021a61
I was pretty much in the same spot until I saw this, so I'm picking the
RISC-V bit and just ignoring the rest. It's testing so it might take a bit to
land in linux-next, but seems pretty safe.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: (subset) [PATCH V2 0/4] Remove WARN_ON in save_processor_state
2023-06-09 7:50 [PATCH V2 0/4] Remove WARN_ON in save_processor_state Song Shuai
` (4 preceding siblings ...)
2023-06-21 15:51 ` (subset) [PATCH V2 0/4] Remove " Catalin Marinas
@ 2023-06-25 23:17 ` Palmer Dabbelt
2023-06-25 23:20 ` patchwork-bot+linux-riscv
6 siblings, 0 replies; 11+ messages in thread
From: Palmer Dabbelt @ 2023-06-25 23:17 UTC (permalink / raw)
To: Catalin Marinas, Will Deacon, Paul Walmsley, Palmer Dabbelt, aou,
chris, jcmvbkbc, steven.price, vincenzo.frascino, leyfoon.tan,
mason.huo, jeeheng.sia, Conor Dooley, ajones, Song Shuai
Cc: linux, linux-arm-kernel, linux-kernel, linux-riscv
On Fri, 09 Jun 2023 15:50:45 +0800, Song Shuai wrote:
> During hibernation or restoration, freeze_secondary_cpus
> checks num_online_cpus via BUG_ON, and the subsequent
> save_processor_state also does the checking with WARN_ON.
>
> In the case of CONFIG_PM_SLEEP_SMP=n, freeze_secondary_cpus
> is not defined, but the sole possible condition to disable
> CONFIG_PM_SLEEP_SMP is !SMP where num_online_cpus is always 1.
> We also don't have to check it in save_processor_state.
>
> [...]
Applied, thanks!
[3/4] riscv: hibernate: remove WARN_ON in save_processor_state
https://git.kernel.org/palmer/c/91afbaafd6b1
Best regards,
--
Palmer Dabbelt <palmer@rivosinc.com>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH V2 0/4] Remove WARN_ON in save_processor_state
2023-06-09 7:50 [PATCH V2 0/4] Remove WARN_ON in save_processor_state Song Shuai
` (5 preceding siblings ...)
2023-06-25 23:17 ` Palmer Dabbelt
@ 2023-06-25 23:20 ` patchwork-bot+linux-riscv
6 siblings, 0 replies; 11+ messages in thread
From: patchwork-bot+linux-riscv @ 2023-06-25 23:20 UTC (permalink / raw)
To: Song Shuai
Cc: linux-riscv, catalin.marinas, will, paul.walmsley, palmer, aou,
chris, jcmvbkbc, steven.price, vincenzo.frascino, leyfoon.tan,
mason.huo, jeeheng.sia, conor.dooley, ajones, linux,
linux-arm-kernel, linux-kernel
Hello:
This series was applied to riscv/linux.git (for-next)
by Palmer Dabbelt <palmer@rivosinc.com>:
On Fri, 9 Jun 2023 15:50:45 +0800 you wrote:
> During hibernation or restoration, freeze_secondary_cpus
> checks num_online_cpus via BUG_ON, and the subsequent
> save_processor_state also does the checking with WARN_ON.
>
> In the case of CONFIG_PM_SLEEP_SMP=n, freeze_secondary_cpus
> is not defined, but the sole possible condition to disable
> CONFIG_PM_SLEEP_SMP is !SMP where num_online_cpus is always 1.
> We also don't have to check it in save_processor_state.
>
> [...]
Here is the summary with links:
- [V2,1/4] ARM: hibernate: remove WARN_ON in save_processor_state
(no matching commit)
- [V2,2/4] arm64: hibernate: remove WARN_ON in save_processor_state
(no matching commit)
- [V2,3/4] riscv: hibernate: remove WARN_ON in save_processor_state
https://git.kernel.org/riscv/c/91afbaafd6b1
- [V2,4/4] xtensa: hibernate: remove WARN_ON in save_processor_state
(no matching commit)
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2023-06-25 23:20 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-09 7:50 [PATCH V2 0/4] Remove WARN_ON in save_processor_state Song Shuai
2023-06-09 7:50 ` [PATCH V2 1/4] ARM: hibernate: remove " Song Shuai
2023-06-09 7:50 ` [PATCH V2 2/4] arm64: " Song Shuai
2023-06-09 10:23 ` Will Deacon
2023-06-09 7:50 ` [PATCH V2 3/4] riscv: " Song Shuai
2023-06-10 15:39 ` Conor Dooley
2023-06-09 7:50 ` [PATCH V2 4/4] xtensa: " Song Shuai
2023-06-21 15:51 ` (subset) [PATCH V2 0/4] Remove " Catalin Marinas
2023-06-22 18:28 ` Palmer Dabbelt
2023-06-25 23:17 ` Palmer Dabbelt
2023-06-25 23:20 ` patchwork-bot+linux-riscv
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).