From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Nick Alcock <nick.alcock@oracle.com>
Cc: mcgrof@kernel.org, linux-modules@vger.kernel.org,
linux-kernel@vger.kernel.org,
Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH 15/27] memory: tegra: remove MODULE_LICENSE in non-modules
Date: Mon, 6 Mar 2023 19:25:26 +0100 [thread overview]
Message-ID: <16bee433-0088-d651-9592-96a2bb827b7f@linaro.org> (raw)
In-Reply-To: <87h6ux7qhp.fsf@esperi.org.uk>
On 06/03/2023 18:13, Nick Alcock wrote:
> On 6 Mar 2023, Krzysztof Kozlowski told this:
>
>> On 06/03/2023 15:30, Krzysztof Kozlowski wrote:
>>> On 24/02/2023 16:07, Nick Alcock wrote:
>>>> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
>>>> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
>>>> are used to identify modules. As a consequence, uses of the macro
>>>> in non-modules will cause modprobe to misidentify their containing
>>>> object file as a module when it is not (false positives), and modprobe
>>>> might succeed rather than failing with a suitable error message.
>>>>
>>>> So remove it in the files in this commit, none of which can be built as
>>>> modules.
>>>
>>> Applied as well. Squashed with next one. Same subject messes with b4, so
>>> prefix should be corrected if these were to stay as separate patches.
>>
>> And all dropped. Run checkpatch before sending patches.
>
> So... which of the 27 patches n this series is being dropped? It would
> also be nice to know what the checkpatch problems were, because all I
> can see from checkpatch is one error per patch, an apparent false
The ones I responded that I applied - so the memory controller ones.
> positive:
>
> ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 8b41fc4454e3 ("kbuild: create modules.builtin without Makefile.modbuiltin or tristate.conf")'
>
> The commit message says:
>
>> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
>> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
>
> ... which unless I am seeing things is precisely what checkpatch.pl is
> asking for. Perhaps it can't handle wrapped lines, but not wrapping a
> git commit log line *also* (correctly) elicits a checkpatch error...
It's not a false positive, but an error I am asking fix (assuming there
are no more ones) There is no problem with wrapping lines - checkpatch
handles it.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-03-06 18:26 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230224150811.80316-1-nick.alcock@oracle.com>
2023-02-24 15:07 ` [PATCH 01/27] gpio: remove MODULE_LICENSE in non-modules Nick Alcock
2023-03-06 9:47 ` Bartosz Golaszewski
2023-02-24 15:07 ` [PATCH 02/27] hwspinlock: " Nick Alcock
2023-02-24 15:07 ` [PATCH 03/27] fbdev: " Nick Alcock
2023-02-24 15:07 ` [PATCH 04/27] mfd: intel_soc_pmic_crc: " Nick Alcock
2023-02-24 16:39 ` Andy Shevchenko
2023-03-03 11:01 ` Lee Jones
2023-03-06 17:04 ` Nick Alcock
2023-03-06 17:25 ` Andy Shevchenko
2023-03-03 11:02 ` Lee Jones
2023-02-24 15:07 ` [PATCH 05/27] cpufreq: intel_pstate: " Nick Alcock
2023-02-28 20:30 ` Rafael J. Wysocki
2023-02-24 15:07 ` [PATCH 06/27] interconnect: " Nick Alcock
2023-03-15 15:23 ` Georgi Djakov
2023-02-24 15:07 ` [PATCH 07/27] iommu/sun50i: " Nick Alcock
2023-03-14 20:15 ` Jernej Škrabec
2023-03-22 13:27 ` Joerg Roedel
2023-02-24 15:07 ` [PATCH 08/27] irqchip: " Nick Alcock
2023-02-24 15:07 ` [PATCH 09/27] " Nick Alcock
2023-02-24 15:32 ` Marc Zyngier
2023-02-24 17:21 ` Luis Chamberlain
2023-02-24 17:35 ` Marc Zyngier
2023-02-24 19:59 ` Luis Chamberlain
2023-02-27 13:24 ` Nick Alcock
2023-02-27 19:35 ` Luis Chamberlain
2023-02-27 19:37 ` Nick Alcock
2023-03-21 8:27 ` Masahiro Yamada
2023-02-24 15:07 ` [PATCH 10/27] leds: " Nick Alcock
2023-03-03 10:53 ` Lee Jones
2023-03-20 10:40 ` Nick Alcock
2023-02-24 15:07 ` [PATCH 11/27] mailbox: rockchip: " Nick Alcock
2023-02-24 15:07 ` [PATCH 12/27] mailbox: zynqmp-ipi: " Nick Alcock
2023-02-27 11:52 ` Michal Simek
2023-02-24 15:07 ` [PATCH 13/27] mctp: " Nick Alcock
2023-02-24 15:07 ` [PATCH 14/27] power: reset: mt6397: " Nick Alcock
2023-02-24 15:07 ` [PATCH 15/27] memory: tegra: " Nick Alcock
2023-03-06 14:30 ` Krzysztof Kozlowski
2023-03-06 15:45 ` Krzysztof Kozlowski
2023-03-06 17:13 ` Nick Alcock
2023-03-06 18:25 ` Krzysztof Kozlowski [this message]
2023-03-08 20:25 ` Nick Alcock
2023-03-09 6:19 ` Krzysztof Kozlowski
2023-02-24 15:08 ` [PATCH 16/27] " Nick Alcock
2023-03-06 14:28 ` (subset) " Krzysztof Kozlowski
2023-02-24 15:08 ` [PATCH 17/27] memory: " Nick Alcock
2023-03-06 14:28 ` (subset) " Krzysztof Kozlowski
2023-02-24 15:08 ` [PATCH 18/27] mtd: bcm63xxpart: " Nick Alcock
2023-03-07 19:23 ` Miquel Raynal
2023-02-24 15:08 ` [PATCH 19/27] irqchip/mchp-eic: " Nick Alcock
2023-03-03 11:23 ` Claudiu.Beznea
2023-02-24 15:08 ` [PATCH 20/27] mfd: " Nick Alcock
2023-02-24 15:08 ` [PATCH 21/27] mfd: bcm2835-pm: " Nick Alcock
2023-02-24 18:38 ` Florian Fainelli
2023-03-03 10:53 ` Lee Jones
2023-02-24 15:08 ` [PATCH 22/27] mfd: " Nick Alcock
2023-02-24 15:08 ` [PATCH 23/27] NFSv4_2: " Nick Alcock
2023-02-24 15:08 ` [PATCH 24/27] firmware: xilinx: " Nick Alcock
2023-02-27 11:51 ` Michal Simek
2023-02-24 15:08 ` [PATCH 25/27] nvmem: core: " Nick Alcock
2023-02-24 15:08 ` [PATCH 26/27] mfd: " Nick Alcock
2023-03-03 10:52 ` Lee Jones
2023-03-08 12:32 ` Nick Alcock
2023-03-08 13:04 ` Lee Jones
2023-03-08 13:07 ` Nick Alcock
2023-03-08 14:31 ` Lee Jones
2023-03-08 12:35 ` Nick Alcock
2023-02-24 15:08 ` [PATCH 27/27] lib: packing: " Nick Alcock
2023-02-24 15:22 ` Vladimir Oltean
2023-02-27 19:39 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16bee433-0088-d651-9592-96a2bb827b7f@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=hasegawa-hitomi@fujitsu.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=nick.alcock@oracle.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).