From: Lee Jones <lee@kernel.org>
To: Nick Alcock <nick.alcock@oracle.com>
Cc: mcgrof@kernel.org, linux-modules@vger.kernel.org,
linux-kernel@vger.kernel.org,
Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>,
Tony Lindgren <tony@atomide.com>,
linux-omap@vger.kernel.org
Subject: Re: [PATCH 26/27] mfd: remove MODULE_LICENSE in non-modules
Date: Fri, 3 Mar 2023 10:52:03 +0000 [thread overview]
Message-ID: <20230303105203.GA2420672@google.com> (raw)
In-Reply-To: <20230224150811.80316-27-nick.alcock@oracle.com>
On Fri, 24 Feb 2023, Nick Alcock wrote:
> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> are used to identify modules. As a consequence, uses of the macro
> in non-modules will cause modprobe to misidentify their containing
> object file as a module when it is not (false positives), and modprobe
> might succeed rather than failing with a suitable error message.
>
> So remove it in the files in this commit, none of which can be built as
> modules.
>
> Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
> Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
> Cc: Luis Chamberlain <mcgrof@kernel.org>
> Cc: linux-modules@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Lee Jones <lee@kernel.org>
> Cc: linux-omap@vger.kernel.org
> ---
> drivers/mfd/omap-usb-host.c | 1 -
> drivers/mfd/omap-usb-tll.c | 1 -
> drivers/mfd/twl4030-audio.c | 1 -
> drivers/mfd/twl6040.c | 1 -
> 4 files changed, 4 deletions(-)
Please adapt the subject line(s) to include the drivers changed. It might
also make sense to separate out changes to cover one driver per patch.
mfd: <device>: Succinct subject-line describing changes
> diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c
> index 787d2ae86375..7f5775109593 100644
> --- a/drivers/mfd/omap-usb-host.c
> +++ b/drivers/mfd/omap-usb-host.c
> @@ -853,7 +853,6 @@ static struct platform_driver usbhs_omap_driver = {
> MODULE_AUTHOR("Keshava Munegowda <keshava_mgowda@ti.com>");
> MODULE_AUTHOR("Roger Quadros <rogerq@ti.com>");
> MODULE_ALIAS("platform:" USBHS_DRIVER_NAME);
> -MODULE_LICENSE("GPL v2");
> MODULE_DESCRIPTION("usb host common core driver for omap EHCI and OHCI");
>
> static int omap_usbhs_drvinit(void)
> diff --git a/drivers/mfd/omap-usb-tll.c b/drivers/mfd/omap-usb-tll.c
> index 080d7970a377..8ca4067da6cd 100644
> --- a/drivers/mfd/omap-usb-tll.c
> +++ b/drivers/mfd/omap-usb-tll.c
> @@ -450,7 +450,6 @@ EXPORT_SYMBOL_GPL(omap_tll_disable);
>
> MODULE_AUTHOR("Keshava Munegowda <keshava_mgowda@ti.com>");
> MODULE_AUTHOR("Roger Quadros <rogerq@ti.com>");
> -MODULE_LICENSE("GPL v2");
> MODULE_DESCRIPTION("usb tll driver for TI OMAP EHCI and OHCI controllers");
>
> static int __init omap_usbtll_drvinit(void)
> diff --git a/drivers/mfd/twl4030-audio.c b/drivers/mfd/twl4030-audio.c
> index 4536d829b43e..88002f8941e5 100644
> --- a/drivers/mfd/twl4030-audio.c
> +++ b/drivers/mfd/twl4030-audio.c
> @@ -285,5 +285,4 @@ module_platform_driver(twl4030_audio_driver);
>
> MODULE_AUTHOR("Peter Ujfalusi <peter.ujfalusi@ti.com>");
> MODULE_DESCRIPTION("TWL4030 audio block MFD driver");
> -MODULE_LICENSE("GPL");
> MODULE_ALIAS("platform:twl4030-audio");
> diff --git a/drivers/mfd/twl6040.c b/drivers/mfd/twl6040.c
> index fc97fa5a2d0c..e982119bbefa 100644
> --- a/drivers/mfd/twl6040.c
> +++ b/drivers/mfd/twl6040.c
> @@ -839,4 +839,3 @@ module_i2c_driver(twl6040_driver);
> MODULE_DESCRIPTION("TWL6040 MFD");
> MODULE_AUTHOR("Misael Lopez Cruz <misael.lopez@ti.com>");
> MODULE_AUTHOR("Jorge Eduardo Candelaria <jorge.candelaria@ti.com>");
> -MODULE_LICENSE("GPL");
> --
> 2.39.1.268.g9de2f9a303
>
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2023-03-03 10:52 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230224150811.80316-1-nick.alcock@oracle.com>
2023-02-24 15:07 ` [PATCH 01/27] gpio: remove MODULE_LICENSE in non-modules Nick Alcock
2023-03-06 9:47 ` Bartosz Golaszewski
2023-02-24 15:07 ` [PATCH 02/27] hwspinlock: " Nick Alcock
2023-02-24 15:07 ` [PATCH 03/27] fbdev: " Nick Alcock
2023-02-24 15:07 ` [PATCH 04/27] mfd: intel_soc_pmic_crc: " Nick Alcock
2023-02-24 16:39 ` Andy Shevchenko
2023-03-03 11:01 ` Lee Jones
2023-03-06 17:04 ` Nick Alcock
2023-03-06 17:25 ` Andy Shevchenko
2023-03-03 11:02 ` Lee Jones
2023-02-24 15:07 ` [PATCH 05/27] cpufreq: intel_pstate: " Nick Alcock
2023-02-28 20:30 ` Rafael J. Wysocki
2023-02-24 15:07 ` [PATCH 06/27] interconnect: " Nick Alcock
2023-03-15 15:23 ` Georgi Djakov
2023-02-24 15:07 ` [PATCH 07/27] iommu/sun50i: " Nick Alcock
2023-03-14 20:15 ` Jernej Škrabec
2023-03-22 13:27 ` Joerg Roedel
2023-02-24 15:07 ` [PATCH 08/27] irqchip: " Nick Alcock
2023-02-24 15:07 ` [PATCH 09/27] " Nick Alcock
2023-02-24 15:32 ` Marc Zyngier
2023-02-24 17:21 ` Luis Chamberlain
2023-02-24 17:35 ` Marc Zyngier
2023-02-24 19:59 ` Luis Chamberlain
2023-02-27 13:24 ` Nick Alcock
2023-02-27 19:35 ` Luis Chamberlain
2023-02-27 19:37 ` Nick Alcock
2023-03-21 8:27 ` Masahiro Yamada
2023-02-24 15:07 ` [PATCH 10/27] leds: " Nick Alcock
2023-03-03 10:53 ` Lee Jones
2023-03-20 10:40 ` Nick Alcock
2023-02-24 15:07 ` [PATCH 11/27] mailbox: rockchip: " Nick Alcock
2023-02-24 15:07 ` [PATCH 12/27] mailbox: zynqmp-ipi: " Nick Alcock
2023-02-27 11:52 ` Michal Simek
2023-02-24 15:07 ` [PATCH 13/27] mctp: " Nick Alcock
2023-02-24 15:07 ` [PATCH 14/27] power: reset: mt6397: " Nick Alcock
2023-02-24 15:07 ` [PATCH 15/27] memory: tegra: " Nick Alcock
2023-03-06 14:30 ` Krzysztof Kozlowski
2023-03-06 15:45 ` Krzysztof Kozlowski
2023-03-06 17:13 ` Nick Alcock
2023-03-06 18:25 ` Krzysztof Kozlowski
2023-03-08 20:25 ` Nick Alcock
2023-03-09 6:19 ` Krzysztof Kozlowski
2023-02-24 15:08 ` [PATCH 16/27] " Nick Alcock
2023-03-06 14:28 ` (subset) " Krzysztof Kozlowski
2023-02-24 15:08 ` [PATCH 17/27] memory: " Nick Alcock
2023-03-06 14:28 ` (subset) " Krzysztof Kozlowski
2023-02-24 15:08 ` [PATCH 18/27] mtd: bcm63xxpart: " Nick Alcock
2023-03-07 19:23 ` Miquel Raynal
2023-02-24 15:08 ` [PATCH 19/27] irqchip/mchp-eic: " Nick Alcock
2023-03-03 11:23 ` Claudiu.Beznea
2023-02-24 15:08 ` [PATCH 20/27] mfd: " Nick Alcock
2023-02-24 15:08 ` [PATCH 21/27] mfd: bcm2835-pm: " Nick Alcock
2023-02-24 18:38 ` Florian Fainelli
2023-03-03 10:53 ` Lee Jones
2023-02-24 15:08 ` [PATCH 22/27] mfd: " Nick Alcock
2023-02-24 15:08 ` [PATCH 23/27] NFSv4_2: " Nick Alcock
2023-02-24 15:08 ` [PATCH 24/27] firmware: xilinx: " Nick Alcock
2023-02-27 11:51 ` Michal Simek
2023-02-24 15:08 ` [PATCH 25/27] nvmem: core: " Nick Alcock
2023-02-24 15:08 ` [PATCH 26/27] mfd: " Nick Alcock
2023-03-03 10:52 ` Lee Jones [this message]
2023-03-08 12:32 ` Nick Alcock
2023-03-08 13:04 ` Lee Jones
2023-03-08 13:07 ` Nick Alcock
2023-03-08 14:31 ` Lee Jones
2023-03-08 12:35 ` Nick Alcock
2023-02-24 15:08 ` [PATCH 27/27] lib: packing: " Nick Alcock
2023-02-24 15:22 ` Vladimir Oltean
2023-02-27 19:39 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230303105203.GA2420672@google.com \
--to=lee@kernel.org \
--cc=hasegawa-hitomi@fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=nick.alcock@oracle.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).