* [PATCH] net/mlx5: improve some comments
@ 2020-04-01 12:57 Hu Haowen
2020-04-01 13:14 ` Hu Haowen
0 siblings, 1 reply; 3+ messages in thread
From: Hu Haowen @ 2020-04-01 12:57 UTC (permalink / raw)
To: saeedm, leon, davem
Cc: guoren, xiubli, jeyu, cai, wqu, stfrench, yamada.masahiro, chris,
xianfengting221, netdev, linux-rdma, linux-kernel
Added a missing space character and replaced "its" with "it's".
Signed-off-by: Hu Haowen <xianfengting221@163.com>
---
drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c b/drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c
index c9c9b479bda5..0a8adda073c2 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c
@@ -684,7 +684,7 @@ static void mlx5_fw_tracer_handle_traces(struct work_struct *work)
get_block_timestamp(tracer, &tmp_trace_block[TRACES_PER_BLOCK - 1]);
while (block_timestamp > tracer->last_timestamp) {
- /* Check block override if its not the first block */
+ /* Check block override if it's not the first block */
if (!tracer->last_timestamp) {
u64 *ts_event;
/* To avoid block override be the HW in case of buffer
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net/mlx5: improve some comments
2020-04-01 12:57 [PATCH] net/mlx5: improve some comments Hu Haowen
@ 2020-04-01 13:14 ` Hu Haowen
2020-04-03 2:33 ` Saeed Mahameed
0 siblings, 1 reply; 3+ messages in thread
From: Hu Haowen @ 2020-04-01 13:14 UTC (permalink / raw)
To: saeedm, leon, davem
Cc: guoren, xiubli, jeyu, cai, wqu, stfrench, yamada.masahiro, chris,
netdev, linux-rdma, linux-kernel
On 2020/4/1 8:57 PM, Hu Haowen wrote:
> Added a missing space character and replaced "its" with "it's".
Sorry, this patch does not include space character adding. Please
ignore and delete that part of the commit message.
> Signed-off-by: Hu Haowen <xianfengting221@163.com>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c b/drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c
> index c9c9b479bda5..0a8adda073c2 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c
> @@ -684,7 +684,7 @@ static void mlx5_fw_tracer_handle_traces(struct work_struct *work)
> get_block_timestamp(tracer, &tmp_trace_block[TRACES_PER_BLOCK - 1]);
>
> while (block_timestamp > tracer->last_timestamp) {
> - /* Check block override if its not the first block */
> + /* Check block override if it's not the first block */
> if (!tracer->last_timestamp) {
> u64 *ts_event;
> /* To avoid block override be the HW in case of buffer
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net/mlx5: improve some comments
2020-04-01 13:14 ` Hu Haowen
@ 2020-04-03 2:33 ` Saeed Mahameed
0 siblings, 0 replies; 3+ messages in thread
From: Saeed Mahameed @ 2020-04-03 2:33 UTC (permalink / raw)
To: davem, xianfengting221, leon
Cc: cai, linux-rdma, stfrench, xiubli, guoren, jeyu, linux-kernel,
wqu, chris, yamada.masahiro, netdev
On Wed, 2020-04-01 at 21:14 +0800, Hu Haowen wrote:
> On 2020/4/1 8:57 PM, Hu Haowen wrote:
> > Added a missing space character and replaced "its" with "it's".
>
> Sorry, this patch does not include space character adding. Please
> ignore and delete that part of the commit message.
>
Hi,
Thanks for the patch I will apply and fix the commit message. BUT..
net-next is closed and the rules apply to everyone, even mlx5 branch,
so please for next time, let's wait for net-next to open.
Thanks,
Saeed.
>
> > Signed-off-by: Hu Haowen <xianfengting221@163.com>
> > ---
> > drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git
> > a/drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c
> > b/drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c
> > index c9c9b479bda5..0a8adda073c2 100644
> > --- a/drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c
> > +++ b/drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c
> > @@ -684,7 +684,7 @@ static void mlx5_fw_tracer_handle_traces(struct
> > work_struct *work)
> > get_block_timestamp(tracer,
> > &tmp_trace_block[TRACES_PER_BLOCK - 1]);
> >
> > while (block_timestamp > tracer->last_timestamp) {
> > - /* Check block override if its not the first block */
> > + /* Check block override if it's not the first block */
> > if (!tracer->last_timestamp) {
> > u64 *ts_event;
> > /* To avoid block override be the HW in case of
> > buffer
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-03 2:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-01 12:57 [PATCH] net/mlx5: improve some comments Hu Haowen
2020-04-01 13:14 ` Hu Haowen
2020-04-03 2:33 ` Saeed Mahameed
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).