* [PATCH 1/2] dt-bindings: crypto: qcom-qce: constrain clocks for IPQ9574 QCE
@ 2023-12-12 10:00 Krzysztof Kozlowski
2023-12-12 10:00 ` [PATCH 2/2] dt-bindings: crypto: qcom-qce: constrain clocks for SM8150-compatible QCE Krzysztof Kozlowski
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2023-12-12 10:00 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Thara Gopinath, Herbert Xu,
David S. Miller, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Bhupesh Sharma, Anusha Rao, linux-arm-msm, linux-crypto,
devicetree, linux-kernel
Cc: Krzysztof Kozlowski
Binding marks several devices as compatible with IPQ4019 QCE. They have
different number of clocks, thus the fallback does not define the
clock constraints per variant and each specific compatible should have
its clocks in if:then: section.
Add missing clocks description for IPQ9574 QCE.
Fixes: 1f5ce01d5d71 ("dt-bindings: crypto: qcom-qce: add SoC compatible string for ipq9574")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Documentation/devicetree/bindings/crypto/qcom-qce.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml
index eeb8a956d7cb..6435708da202 100644
--- a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml
+++ b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml
@@ -97,6 +97,7 @@ allOf:
- qcom,crypto-v5.4
- qcom,ipq6018-qce
- qcom,ipq8074-qce
+ - qcom,ipq9574-qce
- qcom,msm8996-qce
- qcom,sdm845-qce
then:
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] dt-bindings: crypto: qcom-qce: constrain clocks for SM8150-compatible QCE
2023-12-12 10:00 [PATCH 1/2] dt-bindings: crypto: qcom-qce: constrain clocks for IPQ9574 QCE Krzysztof Kozlowski
@ 2023-12-12 10:00 ` Krzysztof Kozlowski
2023-12-14 21:40 ` Rob Herring
2023-12-14 21:40 ` [PATCH 1/2] dt-bindings: crypto: qcom-qce: constrain clocks for IPQ9574 QCE Rob Herring
2023-12-22 4:36 ` Herbert Xu
2 siblings, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2023-12-12 10:00 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Thara Gopinath, Herbert Xu,
David S. Miller, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Bhupesh Sharma, Anusha Rao, linux-arm-msm, linux-crypto,
devicetree, linux-kernel
Cc: Krzysztof Kozlowski
All devices compatible with SM8150 QCE (so SM8250 and newer) do not have
clock inputs (clocks are handled by secure firmware), so explicitly
disallow the clocks in the bindings.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../devicetree/bindings/crypto/qcom-qce.yaml | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml
index 6435708da202..e8c418b614dc 100644
--- a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml
+++ b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml
@@ -131,6 +131,17 @@ allOf:
- clocks
- clock-names
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - qcom,sm8150-qce
+ then:
+ properties:
+ clocks: false
+ clock-names: false
+
required:
- compatible
- reg
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] dt-bindings: crypto: qcom-qce: constrain clocks for IPQ9574 QCE
2023-12-12 10:00 [PATCH 1/2] dt-bindings: crypto: qcom-qce: constrain clocks for IPQ9574 QCE Krzysztof Kozlowski
2023-12-12 10:00 ` [PATCH 2/2] dt-bindings: crypto: qcom-qce: constrain clocks for SM8150-compatible QCE Krzysztof Kozlowski
@ 2023-12-14 21:40 ` Rob Herring
2023-12-22 4:36 ` Herbert Xu
2 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2023-12-14 21:40 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Herbert Xu, Konrad Dybcio, Krzysztof Kozlowski, David S. Miller,
Thara Gopinath, Conor Dooley, linux-kernel, linux-arm-msm,
Anusha Rao, Bhupesh Sharma, linux-crypto, Rob Herring,
devicetree, Bjorn Andersson
On Tue, 12 Dec 2023 11:00:43 +0100, Krzysztof Kozlowski wrote:
> Binding marks several devices as compatible with IPQ4019 QCE. They have
> different number of clocks, thus the fallback does not define the
> clock constraints per variant and each specific compatible should have
> its clocks in if:then: section.
>
> Add missing clocks description for IPQ9574 QCE.
>
> Fixes: 1f5ce01d5d71 ("dt-bindings: crypto: qcom-qce: add SoC compatible string for ipq9574")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> Documentation/devicetree/bindings/crypto/qcom-qce.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] dt-bindings: crypto: qcom-qce: constrain clocks for SM8150-compatible QCE
2023-12-12 10:00 ` [PATCH 2/2] dt-bindings: crypto: qcom-qce: constrain clocks for SM8150-compatible QCE Krzysztof Kozlowski
@ 2023-12-14 21:40 ` Rob Herring
0 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2023-12-14 21:40 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: linux-arm-msm, Thara Gopinath, devicetree, linux-crypto,
Conor Dooley, Bhupesh Sharma, Krzysztof Kozlowski, linux-kernel,
Rob Herring, Herbert Xu, Anusha Rao, Konrad Dybcio,
Bjorn Andersson, David S. Miller
On Tue, 12 Dec 2023 11:00:44 +0100, Krzysztof Kozlowski wrote:
> All devices compatible with SM8150 QCE (so SM8250 and newer) do not have
> clock inputs (clocks are handled by secure firmware), so explicitly
> disallow the clocks in the bindings.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../devicetree/bindings/crypto/qcom-qce.yaml | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] dt-bindings: crypto: qcom-qce: constrain clocks for IPQ9574 QCE
2023-12-12 10:00 [PATCH 1/2] dt-bindings: crypto: qcom-qce: constrain clocks for IPQ9574 QCE Krzysztof Kozlowski
2023-12-12 10:00 ` [PATCH 2/2] dt-bindings: crypto: qcom-qce: constrain clocks for SM8150-compatible QCE Krzysztof Kozlowski
2023-12-14 21:40 ` [PATCH 1/2] dt-bindings: crypto: qcom-qce: constrain clocks for IPQ9574 QCE Rob Herring
@ 2023-12-22 4:36 ` Herbert Xu
2 siblings, 0 replies; 5+ messages in thread
From: Herbert Xu @ 2023-12-22 4:36 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Bjorn Andersson, Konrad Dybcio, Thara Gopinath, David S. Miller,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bhupesh Sharma,
Anusha Rao, linux-arm-msm, linux-crypto, devicetree,
linux-kernel
On Tue, Dec 12, 2023 at 11:00:43AM +0100, Krzysztof Kozlowski wrote:
> Binding marks several devices as compatible with IPQ4019 QCE. They have
> different number of clocks, thus the fallback does not define the
> clock constraints per variant and each specific compatible should have
> its clocks in if:then: section.
>
> Add missing clocks description for IPQ9574 QCE.
>
> Fixes: 1f5ce01d5d71 ("dt-bindings: crypto: qcom-qce: add SoC compatible string for ipq9574")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> Documentation/devicetree/bindings/crypto/qcom-qce.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml
> index eeb8a956d7cb..6435708da202 100644
> --- a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml
> +++ b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml
> @@ -97,6 +97,7 @@ allOf:
> - qcom,crypto-v5.4
> - qcom,ipq6018-qce
> - qcom,ipq8074-qce
> + - qcom,ipq9574-qce
> - qcom,msm8996-qce
> - qcom,sdm845-qce
> then:
> --
> 2.34.1
All applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-12-22 4:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-12 10:00 [PATCH 1/2] dt-bindings: crypto: qcom-qce: constrain clocks for IPQ9574 QCE Krzysztof Kozlowski
2023-12-12 10:00 ` [PATCH 2/2] dt-bindings: crypto: qcom-qce: constrain clocks for SM8150-compatible QCE Krzysztof Kozlowski
2023-12-14 21:40 ` Rob Herring
2023-12-14 21:40 ` [PATCH 1/2] dt-bindings: crypto: qcom-qce: constrain clocks for IPQ9574 QCE Rob Herring
2023-12-22 4:36 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).