* [PATCH v3] acpi: handle the acpi hotplug schedule error
@ 2017-07-07 6:22 Lee, Chun-Yi
2017-07-07 13:16 ` Rafael J. Wysocki
0 siblings, 1 reply; 4+ messages in thread
From: Lee, Chun-Yi @ 2017-07-07 6:22 UTC (permalink / raw)
To: Rafael J . Wysocki
Cc: linux-acpi, linux-kernel, Lee, Chun-Yi, Len Brown, Michal Hocko
Kernel should decrements the reference count of acpi device
when the scheduling of acpi hotplug work failed, and evaluates
_OST to notify BIOS the failure.
v3:
More simplify the code. (Rafael J. Wysocki)
v2:
To simplify the code. (Andy Shevchenko)
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Len Brown <lenb@kernel.org>
Cc: Michal Hocko <mhocko@suse.cz>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: "Lee, Chun-Yi" <jlee@suse.com>
---
drivers/acpi/bus.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
index 784bda6..9d4fea6 100644
--- a/drivers/acpi/bus.c
+++ b/drivers/acpi/bus.c
@@ -432,11 +432,15 @@ static void acpi_bus_notify(acpi_handle handle, u32 type, void *data)
(driver->flags & ACPI_DRIVER_ALL_NOTIFY_EVENTS))
driver->ops.notify(adev, type);
- if (hotplug_event && ACPI_SUCCESS(acpi_hotplug_schedule(adev, type)))
+ if (!hotplug_event) {
+ acpi_bus_put_acpi_device(adev);
+ return;
+ }
+
+ if (ACPI_SUCCESS(acpi_hotplug_schedule(adev, type)))
return;
acpi_bus_put_acpi_device(adev);
- return;
err:
acpi_evaluate_ost(handle, type, ost_code, NULL);
--
2.10.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v3] acpi: handle the acpi hotplug schedule error
2017-07-07 6:22 [PATCH v3] acpi: handle the acpi hotplug schedule error Lee, Chun-Yi
@ 2017-07-07 13:16 ` Rafael J. Wysocki
2017-07-08 3:25 ` jlee
0 siblings, 1 reply; 4+ messages in thread
From: Rafael J. Wysocki @ 2017-07-07 13:16 UTC (permalink / raw)
To: Lee, Chun-Yi
Cc: linux-acpi, linux-kernel, Lee, Chun-Yi, Len Brown, Michal Hocko
On Friday, July 07, 2017 02:22:42 PM Lee, Chun-Yi wrote:
> Kernel should decrements the reference count of acpi device
> when the scheduling of acpi hotplug work failed, and evaluates
> _OST to notify BIOS the failure.
>
> v3:
> More simplify the code. (Rafael J. Wysocki)
>
> v2:
> To simplify the code. (Andy Shevchenko)
>
> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> Cc: Len Brown <lenb@kernel.org>
> Cc: Michal Hocko <mhocko@suse.cz>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Signed-off-by: "Lee, Chun-Yi" <jlee@suse.com>
This has been applied too AFAICS.
> ---
> drivers/acpi/bus.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
> index 784bda6..9d4fea6 100644
> --- a/drivers/acpi/bus.c
> +++ b/drivers/acpi/bus.c
> @@ -432,11 +432,15 @@ static void acpi_bus_notify(acpi_handle handle, u32 type, void *data)
> (driver->flags & ACPI_DRIVER_ALL_NOTIFY_EVENTS))
> driver->ops.notify(adev, type);
>
> - if (hotplug_event && ACPI_SUCCESS(acpi_hotplug_schedule(adev, type)))
> + if (!hotplug_event) {
> + acpi_bus_put_acpi_device(adev);
> + return;
> + }
> +
> + if (ACPI_SUCCESS(acpi_hotplug_schedule(adev, type)))
> return;
>
> acpi_bus_put_acpi_device(adev);
> - return;
>
> err:
> acpi_evaluate_ost(handle, type, ost_code, NULL);
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3] acpi: handle the acpi hotplug schedule error
2017-07-07 13:16 ` Rafael J. Wysocki
@ 2017-07-08 3:25 ` jlee
0 siblings, 0 replies; 4+ messages in thread
From: jlee @ 2017-07-08 3:25 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Lee, Chun-Yi, linux-acpi, linux-kernel, Len Brown, Michal Hocko
Hi Rafael,
On Fri, Jul 07, 2017 at 03:16:40PM +0200, Rafael J. Wysocki wrote:
> On Friday, July 07, 2017 02:22:42 PM Lee, Chun-Yi wrote:
> > Kernel should decrements the reference count of acpi device
> > when the scheduling of acpi hotplug work failed, and evaluates
> > _OST to notify BIOS the failure.
> >
> > v3:
> > More simplify the code. (Rafael J. Wysocki)
> >
> > v2:
> > To simplify the code. (Andy Shevchenko)
> >
> > Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> > Cc: Len Brown <lenb@kernel.org>
> > Cc: Michal Hocko <mhocko@suse.cz>
> > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> > Signed-off-by: "Lee, Chun-Yi" <jlee@suse.com>
>
> This has been applied too AFAICS.
>
I saw patches in linux-next.
Thanks for your review.
Joey Lee
> > ---
> > drivers/acpi/bus.c | 8 ++++++--
> > 1 file changed, 6 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
> > index 784bda6..9d4fea6 100644
> > --- a/drivers/acpi/bus.c
> > +++ b/drivers/acpi/bus.c
> > @@ -432,11 +432,15 @@ static void acpi_bus_notify(acpi_handle handle, u32 type, void *data)
> > (driver->flags & ACPI_DRIVER_ALL_NOTIFY_EVENTS))
> > driver->ops.notify(adev, type);
> >
> > - if (hotplug_event && ACPI_SUCCESS(acpi_hotplug_schedule(adev, type)))
> > + if (!hotplug_event) {
> > + acpi_bus_put_acpi_device(adev);
> > + return;
> > + }
> > +
> > + if (ACPI_SUCCESS(acpi_hotplug_schedule(adev, type)))
> > return;
> >
> > acpi_bus_put_acpi_device(adev);
> > - return;
> >
> > err:
> > acpi_evaluate_ost(handle, type, ost_code, NULL);
> >
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v3] acpi: handle the acpi hotplug schedule error
@ 2017-06-30 7:25 Lee, Chun-Yi
0 siblings, 0 replies; 4+ messages in thread
From: Lee, Chun-Yi @ 2017-06-30 7:25 UTC (permalink / raw)
To: Rafael J . Wysocki
Cc: linux-acpi, linux-kernel, Lee, Chun-Yi, Len Brown, Michal Hocko
Kernel should decrements the reference count of acpi device
when the scheduling of acpi hotplug work failed, and evaluates
_OST to notify BIOS the failure.
v3:
More simplify the code. (Rafael J. Wysocki)
v2:
To simplify the code. (Andy Shevchenko)
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Len Brown <lenb@kernel.org>
Cc: Michal Hocko <mhocko@suse.cz>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: "Lee, Chun-Yi" <jlee@suse.com>
---
drivers/acpi/bus.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
index 784bda6..9d4fea6 100644
--- a/drivers/acpi/bus.c
+++ b/drivers/acpi/bus.c
@@ -432,11 +432,15 @@ static void acpi_bus_notify(acpi_handle handle, u32 type, void *data)
(driver->flags & ACPI_DRIVER_ALL_NOTIFY_EVENTS))
driver->ops.notify(adev, type);
- if (hotplug_event && ACPI_SUCCESS(acpi_hotplug_schedule(adev, type)))
+ if (!hotplug_event) {
+ acpi_bus_put_acpi_device(adev);
+ return;
+ }
+
+ if (ACPI_SUCCESS(acpi_hotplug_schedule(adev, type)))
return;
acpi_bus_put_acpi_device(adev);
- return;
err:
acpi_evaluate_ost(handle, type, ost_code, NULL);
--
2.10.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-07-08 3:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-07 6:22 [PATCH v3] acpi: handle the acpi hotplug schedule error Lee, Chun-Yi
2017-07-07 13:16 ` Rafael J. Wysocki
2017-07-08 3:25 ` jlee
-- strict thread matches above, loose matches on Subject: below --
2017-06-30 7:25 Lee, Chun-Yi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).