From: David Howells <dhowells@redhat.com>
To: Miklos Szeredi <mszeredi@redhat.com>
Cc: dhowells@redhat.com, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
Michael Kerrisk <mtk.manpages@gmail.com>,
Andreas Dilger <adilger@dilger.ca>,
Florian Weimer <fw@deneb.enyo.de>,
Amir Goldstein <amir73il@gmail.com>,
Trond Myklebust <trond.myklebust@primarydata.com>
Subject: Re: [PATCH v2 5/5] nfs: don't clear STATX_ATIME from result_mask
Date: Fri, 19 Oct 2018 16:44:44 +0100 [thread overview]
Message-ID: <17057.1539963884@warthog.procyon.org.uk> (raw)
In-Reply-To: <20181019122049.27121-5-mszeredi@redhat.com>
Miklos Szeredi <mszeredi@redhat.com> wrote:
> As per statx(2) man page only clear out flags that are unsupported by the
> fs or have an unrepresentable value. Atime is supported by NFS as long as
> it's supported on the server.
>
> So the STATX_ATIME flag should not be cleared in the result_mask if the
> operation was requested on a MNT_NOATIME or MNT_NODIRATIME mount.
>
> This patch doesn't change the revalidation algorithm in any way, just the
> clearing of flags in stat->result_mask.
>
> Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
> Fixes: 9ccee940bd5b ("Support statx() mask and query flags parameters")
> Cc: Trond Myklebust <trond.myklebust@primarydata.com>
Reviewed-by: David Howells <dhowells@redhat.com>
prev parent reply other threads:[~2018-10-19 15:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-19 12:20 [PATCH v2 1/5] orangefs: fix request_mask misuse Miklos Szeredi
2018-10-19 12:20 ` [PATCH v2 2/5] uapi: deprecate STATX_ALL Miklos Szeredi
2018-10-19 12:20 ` [PATCH v2 3/5] statx: add STATX_ATTRIBUTES flag Miklos Szeredi
2018-10-19 12:20 ` [PATCH v2 4/5] statx: don't clear STATX_ATIME on SB_RDONLY Miklos Szeredi
2018-10-19 12:20 ` [PATCH v2 5/5] nfs: don't clear STATX_ATIME from result_mask Miklos Szeredi
2018-10-19 15:52 ` Trond Myklebust
2018-10-19 17:46 ` Miklos Szeredi
2018-10-19 18:14 ` Trond Myklebust
2018-10-19 20:48 ` Miklos Szeredi
2018-10-20 17:46 ` Trond Myklebust
2018-11-05 22:29 ` Andreas Dilger
2018-10-19 14:27 ` [PATCH v2 1/5] orangefs: fix request_mask misuse Andreas Dilger
2018-10-19 15:35 ` [PATCH v2 2/5] uapi: deprecate STATX_ALL David Howells
2018-10-19 15:40 ` Miklos Szeredi
2018-10-19 15:47 ` David Howells
2018-10-19 17:30 ` Miklos Szeredi
2018-10-19 15:36 ` [PATCH v2 3/5] statx: add STATX_ATTRIBUTES flag David Howells
2018-10-19 15:40 ` [PATCH v2 4/5] statx: don't clear STATX_ATIME on SB_RDONLY David Howells
2018-10-19 15:44 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17057.1539963884@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=adilger@dilger.ca \
--cc=amir73il@gmail.com \
--cc=fw@deneb.enyo.de \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mszeredi@redhat.com \
--cc=mtk.manpages@gmail.com \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).