* [PATCH] dt-bindings: memory-controllers: narrow regex for unit address to hex numbers
@ 2024-01-23 8:35 Krzysztof Kozlowski
2024-01-23 9:20 ` Jon Hunter
2024-01-25 11:04 ` Krzysztof Kozlowski
0 siblings, 2 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2024-01-23 8:35 UTC (permalink / raw)
To: Krzysztof Kozlowski, Rob Herring, Conor Dooley, Thierry Reding,
Jonathan Hunter, Dmitry Osipenko, linux-kernel, devicetree,
linux-tegra
Regular expression used to match the unit address part should not allow
non-hex numbers.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../bindings/memory-controllers/nvidia,tegra20-emc.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.yaml b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.yaml
index f54e553e6c0e..71896cb10692 100644
--- a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.yaml
+++ b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.yaml
@@ -145,7 +145,7 @@ patternProperties:
"^emc-table@[0-9]+$":
$ref: "#/$defs/emc-table"
- "^emc-tables@[a-z0-9-]+$":
+ "^emc-tables@[a-f0-9-]+$":
type: object
properties:
reg:
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: memory-controllers: narrow regex for unit address to hex numbers
2024-01-23 8:35 [PATCH] dt-bindings: memory-controllers: narrow regex for unit address to hex numbers Krzysztof Kozlowski
@ 2024-01-23 9:20 ` Jon Hunter
2024-01-23 9:45 ` Krzysztof Kozlowski
2024-01-25 11:04 ` Krzysztof Kozlowski
1 sibling, 1 reply; 4+ messages in thread
From: Jon Hunter @ 2024-01-23 9:20 UTC (permalink / raw)
To: Krzysztof Kozlowski, Rob Herring, Conor Dooley, Thierry Reding,
Dmitry Osipenko, linux-kernel, devicetree, linux-tegra
On 23/01/2024 08:35, Krzysztof Kozlowski wrote:
> Regular expression used to match the unit address part should not allow
> non-hex numbers.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../bindings/memory-controllers/nvidia,tegra20-emc.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.yaml b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.yaml
> index f54e553e6c0e..71896cb10692 100644
> --- a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.yaml
> +++ b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.yaml
> @@ -145,7 +145,7 @@ patternProperties:
> "^emc-table@[0-9]+$":
> $ref: "#/$defs/emc-table"
>
> - "^emc-tables@[a-z0-9-]+$":
> + "^emc-tables@[a-f0-9-]+$":
> type: object
> properties:
> reg:
Thanks! We could add the fixes tag ...
Fixes: de3d7018372c dt-bindings: memory: tegra20: emc: Convert to schema
Otherwise ...
Reviewed-by: Jon Hunter <jonathanh@nvidia.com>
Jon
--
nvpublic
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: memory-controllers: narrow regex for unit address to hex numbers
2024-01-23 9:20 ` Jon Hunter
@ 2024-01-23 9:45 ` Krzysztof Kozlowski
0 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2024-01-23 9:45 UTC (permalink / raw)
To: Jon Hunter, Rob Herring, Conor Dooley, Thierry Reding,
Dmitry Osipenko, linux-kernel, devicetree, linux-tegra
On 23/01/2024 10:20, Jon Hunter wrote:
>
> On 23/01/2024 08:35, Krzysztof Kozlowski wrote:
>> Regular expression used to match the unit address part should not allow
>> non-hex numbers.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>> .../bindings/memory-controllers/nvidia,tegra20-emc.yaml | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.yaml b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.yaml
>> index f54e553e6c0e..71896cb10692 100644
>> --- a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.yaml
>> +++ b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.yaml
>> @@ -145,7 +145,7 @@ patternProperties:
>> "^emc-table@[0-9]+$":
>> $ref: "#/$defs/emc-table"
>>
>> - "^emc-tables@[a-z0-9-]+$":
>> + "^emc-tables@[a-f0-9-]+$":
>> type: object
>> properties:
>> reg:
>
>
> Thanks! We could add the fixes tag ...
>
> Fixes: de3d7018372c dt-bindings: memory: tegra20: emc: Convert to schema
There is no bug here, really. At least no bug with impact, because dtc
won't allow DTS with non-hex numbers.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: memory-controllers: narrow regex for unit address to hex numbers
2024-01-23 8:35 [PATCH] dt-bindings: memory-controllers: narrow regex for unit address to hex numbers Krzysztof Kozlowski
2024-01-23 9:20 ` Jon Hunter
@ 2024-01-25 11:04 ` Krzysztof Kozlowski
1 sibling, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2024-01-25 11:04 UTC (permalink / raw)
To: Rob Herring, Conor Dooley, Thierry Reding, Jonathan Hunter,
Dmitry Osipenko, linux-kernel, devicetree, linux-tegra,
Krzysztof Kozlowski
On Tue, 23 Jan 2024 09:35:17 +0100, Krzysztof Kozlowski wrote:
> Regular expression used to match the unit address part should not allow
> non-hex numbers.
>
>
Applied, thanks!
[1/1] dt-bindings: memory-controllers: narrow regex for unit address to hex numbers
https://git.kernel.org/krzk/linux-mem-ctrl/c/2f542c937c48c2bd5a8ddf180b417fbe7152559f
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-01-25 11:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-23 8:35 [PATCH] dt-bindings: memory-controllers: narrow regex for unit address to hex numbers Krzysztof Kozlowski
2024-01-23 9:20 ` Jon Hunter
2024-01-23 9:45 ` Krzysztof Kozlowski
2024-01-25 11:04 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).