linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/3] ARM: dts: qcom: ipq8064: drop unused reset-names from DWC3 node
@ 2023-11-12  8:01 Krzysztof Kozlowski
  2023-11-12  8:01 ` [PATCH 2/3] ARM: dts: qcom: sdx65: correct clock order in " Krzysztof Kozlowski
                   ` (3 more replies)
  0 siblings, 4 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2023-11-12  8:01 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree,
	linux-kernel
  Cc: Krzysztof Kozlowski

The Qualcomm DWC3 USB controller bindings do not allow "reset-names" and
Linux driver does no use it.  This fixes dtbs_check warning:

  qcom-ipq8064-ap148.dtb: usb@100f8800: 'reset-names' does not match any of the regexes: '^usb@[0-9a-f]+$', 'pinctrl-[0-9]+'

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm/boot/dts/qcom/qcom-ipq8064.dtsi | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/arm/boot/dts/qcom/qcom-ipq8064.dtsi b/arch/arm/boot/dts/qcom/qcom-ipq8064.dtsi
index 40cfee17265a..d9771e8f9a1d 100644
--- a/arch/arm/boot/dts/qcom/qcom-ipq8064.dtsi
+++ b/arch/arm/boot/dts/qcom/qcom-ipq8064.dtsi
@@ -625,7 +625,6 @@ usb3_0: usb@100f8800 {
 			ranges;
 
 			resets = <&gcc USB30_0_MASTER_RESET>;
-			reset-names = "master";
 
 			status = "disabled";
 
@@ -671,7 +670,6 @@ usb3_1: usb@110f8800 {
 			ranges;
 
 			resets = <&gcc USB30_1_MASTER_RESET>;
-			reset-names = "master";
 
 			status = "disabled";
 
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH 2/3] ARM: dts: qcom: sdx65: correct clock order in DWC3 node
  2023-11-12  8:01 [PATCH 1/3] ARM: dts: qcom: ipq8064: drop unused reset-names from DWC3 node Krzysztof Kozlowski
@ 2023-11-12  8:01 ` Krzysztof Kozlowski
  2023-11-15 16:51   ` Konrad Dybcio
  2023-11-12  8:01 ` [PATCH 3/3] ARM: dts: qcom: ipq4019: " Krzysztof Kozlowski
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 7+ messages in thread
From: Krzysztof Kozlowski @ 2023-11-12  8:01 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree,
	linux-kernel
  Cc: Krzysztof Kozlowski

Align the order of clocks in Qualcomm DWC3 USB controller to match
bindings.  Linux driver does not care about the order.  This fixes
dtbs_check warning:

  qcom-sdx65-mtp.dtb: usb@a6f8800: clock-names:3: 'sleep' was expected
  qcom-sdx65-mtp.dtb: usb@a6f8800: clock-names:4: 'mock_utmi' was expected

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm/boot/dts/qcom/qcom-sdx65.dtsi | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/qcom/qcom-sdx65.dtsi b/arch/arm/boot/dts/qcom/qcom-sdx65.dtsi
index 49c16ee2e169..7a86bcb52cfd 100644
--- a/arch/arm/boot/dts/qcom/qcom-sdx65.dtsi
+++ b/arch/arm/boot/dts/qcom/qcom-sdx65.dtsi
@@ -496,10 +496,10 @@ usb: usb@a6f8800 {
 			clocks = <&gcc GCC_USB30_SLV_AHB_CLK>,
 				 <&gcc GCC_USB30_MASTER_CLK>,
 				 <&gcc GCC_USB30_MSTR_AXI_CLK>,
-				 <&gcc GCC_USB30_MOCK_UTMI_CLK>,
-				 <&gcc GCC_USB30_SLEEP_CLK>;
-			clock-names = "cfg_noc", "core", "iface", "mock_utmi",
-					"sleep";
+				 <&gcc GCC_USB30_SLEEP_CLK>,
+				 <&gcc GCC_USB30_MOCK_UTMI_CLK>;
+			clock-names = "cfg_noc", "core", "iface", "sleep",
+				      "mock_utmi";
 
 			assigned-clocks = <&gcc GCC_USB30_MOCK_UTMI_CLK>,
 					  <&gcc GCC_USB30_MASTER_CLK>;
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH 3/3] ARM: dts: qcom: ipq4019: correct clock order in DWC3 node
  2023-11-12  8:01 [PATCH 1/3] ARM: dts: qcom: ipq8064: drop unused reset-names from DWC3 node Krzysztof Kozlowski
  2023-11-12  8:01 ` [PATCH 2/3] ARM: dts: qcom: sdx65: correct clock order in " Krzysztof Kozlowski
@ 2023-11-12  8:01 ` Krzysztof Kozlowski
  2023-11-15 16:53   ` Konrad Dybcio
  2023-11-15 16:50 ` [PATCH 1/3] ARM: dts: qcom: ipq8064: drop unused reset-names from " Konrad Dybcio
  2024-01-27 22:34 ` (subset) " Bjorn Andersson
  3 siblings, 1 reply; 7+ messages in thread
From: Krzysztof Kozlowski @ 2023-11-12  8:01 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree,
	linux-kernel
  Cc: Krzysztof Kozlowski

Align the order of clocks in Qualcomm DWC3 USB controller to match
bindings.  Linux driver does not care about the order.  This fixes
dtbs_check warning:

  qcom-ipq4018-ap120c-ac.dtb: usb@60f8800: clock-names:0: 'core' was expected

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm/boot/dts/qcom/qcom-ipq4019.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/qcom/qcom-ipq4019.dtsi b/arch/arm/boot/dts/qcom/qcom-ipq4019.dtsi
index b93c7efda827..6357cd342b33 100644
--- a/arch/arm/boot/dts/qcom/qcom-ipq4019.dtsi
+++ b/arch/arm/boot/dts/qcom/qcom-ipq4019.dtsi
@@ -684,7 +684,7 @@ usb2: usb@60f8800 {
 			clocks = <&gcc GCC_USB2_MASTER_CLK>,
 				 <&gcc GCC_USB2_SLEEP_CLK>,
 				 <&gcc GCC_USB2_MOCK_UTMI_CLK>;
-			clock-names = "master", "sleep", "mock_utmi";
+			clock-names = "core", "sleep", "mock_utmi";
 			ranges;
 			status = "disabled";
 
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/3] ARM: dts: qcom: ipq8064: drop unused reset-names from DWC3 node
  2023-11-12  8:01 [PATCH 1/3] ARM: dts: qcom: ipq8064: drop unused reset-names from DWC3 node Krzysztof Kozlowski
  2023-11-12  8:01 ` [PATCH 2/3] ARM: dts: qcom: sdx65: correct clock order in " Krzysztof Kozlowski
  2023-11-12  8:01 ` [PATCH 3/3] ARM: dts: qcom: ipq4019: " Krzysztof Kozlowski
@ 2023-11-15 16:50 ` Konrad Dybcio
  2024-01-27 22:34 ` (subset) " Bjorn Andersson
  3 siblings, 0 replies; 7+ messages in thread
From: Konrad Dybcio @ 2023-11-15 16:50 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree,
	linux-kernel



On 11/12/23 09:01, Krzysztof Kozlowski wrote:
> The Qualcomm DWC3 USB controller bindings do not allow "reset-names" and
> Linux driver does no use it.  This fixes dtbs_check warning:
> 
>    qcom-ipq8064-ap148.dtb: usb@100f8800: 'reset-names' does not match any of the regexes: '^usb@[0-9a-f]+$', 'pinctrl-[0-9]+'
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 2/3] ARM: dts: qcom: sdx65: correct clock order in DWC3 node
  2023-11-12  8:01 ` [PATCH 2/3] ARM: dts: qcom: sdx65: correct clock order in " Krzysztof Kozlowski
@ 2023-11-15 16:51   ` Konrad Dybcio
  0 siblings, 0 replies; 7+ messages in thread
From: Konrad Dybcio @ 2023-11-15 16:51 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree,
	linux-kernel



On 11/12/23 09:01, Krzysztof Kozlowski wrote:
> Align the order of clocks in Qualcomm DWC3 USB controller to match
> bindings.  Linux driver does not care about the order.  This fixes
> dtbs_check warning:
> 
>    qcom-sdx65-mtp.dtb: usb@a6f8800: clock-names:3: 'sleep' was expected
>    qcom-sdx65-mtp.dtb: usb@a6f8800: clock-names:4: 'mock_utmi' was expected
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 3/3] ARM: dts: qcom: ipq4019: correct clock order in DWC3 node
  2023-11-12  8:01 ` [PATCH 3/3] ARM: dts: qcom: ipq4019: " Krzysztof Kozlowski
@ 2023-11-15 16:53   ` Konrad Dybcio
  0 siblings, 0 replies; 7+ messages in thread
From: Konrad Dybcio @ 2023-11-15 16:53 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree,
	linux-kernel



On 11/12/23 09:01, Krzysztof Kozlowski wrote:
> Align the order of clocks in Qualcomm DWC3 USB controller to match
> bindings.  Linux driver does not care about the order.  This fixes
> dtbs_check warning:
> 
>    qcom-ipq4018-ap120c-ac.dtb: usb@60f8800: clock-names:0: 'core' was expected
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: (subset) [PATCH 1/3] ARM: dts: qcom: ipq8064: drop unused reset-names from DWC3 node
  2023-11-12  8:01 [PATCH 1/3] ARM: dts: qcom: ipq8064: drop unused reset-names from DWC3 node Krzysztof Kozlowski
                   ` (2 preceding siblings ...)
  2023-11-15 16:50 ` [PATCH 1/3] ARM: dts: qcom: ipq8064: drop unused reset-names from " Konrad Dybcio
@ 2024-01-27 22:34 ` Bjorn Andersson
  3 siblings, 0 replies; 7+ messages in thread
From: Bjorn Andersson @ 2024-01-27 22:34 UTC (permalink / raw)
  To: Andy Gross, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, linux-arm-msm, devicetree, linux-kernel,
	Krzysztof Kozlowski


On Sun, 12 Nov 2023 09:01:34 +0100, Krzysztof Kozlowski wrote:
> The Qualcomm DWC3 USB controller bindings do not allow "reset-names" and
> Linux driver does no use it.  This fixes dtbs_check warning:
> 
>   qcom-ipq8064-ap148.dtb: usb@100f8800: 'reset-names' does not match any of the regexes: '^usb@[0-9a-f]+$', 'pinctrl-[0-9]+'
> 
> 

Applied, thanks!

[1/3] ARM: dts: qcom: ipq8064: drop unused reset-names from DWC3 node
      commit: a78a95b98dc5b4dda925b2e9981abf815a46b0de
[2/3] ARM: dts: qcom: sdx65: correct clock order in DWC3 node
      commit: 7d912adff5c6484be16b3081aa5ef716b88a682e
[3/3] ARM: dts: qcom: ipq4019: correct clock order in DWC3 node
      commit: 71ae7237cd31948b3414aaa07dc594a9fdb8d654

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2024-01-27 22:34 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-12  8:01 [PATCH 1/3] ARM: dts: qcom: ipq8064: drop unused reset-names from DWC3 node Krzysztof Kozlowski
2023-11-12  8:01 ` [PATCH 2/3] ARM: dts: qcom: sdx65: correct clock order in " Krzysztof Kozlowski
2023-11-15 16:51   ` Konrad Dybcio
2023-11-12  8:01 ` [PATCH 3/3] ARM: dts: qcom: ipq4019: " Krzysztof Kozlowski
2023-11-15 16:53   ` Konrad Dybcio
2023-11-15 16:50 ` [PATCH 1/3] ARM: dts: qcom: ipq8064: drop unused reset-names from " Konrad Dybcio
2024-01-27 22:34 ` (subset) " Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).