linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] clk: qcom: gcc-sdm845: Add soft dependency on rpmhpd
@ 2024-01-23  6:28 Amit Pundir
  2024-01-23  9:45 ` Manivannan Sadhasivam
  2024-01-27 22:34 ` Bjorn Andersson
  0 siblings, 2 replies; 3+ messages in thread
From: Amit Pundir @ 2024-01-23  6:28 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Michael Turquette, Stephen Boyd,
	Krzysztof Kozlowski, Manivannan Sadhasivam
  Cc: linux-arm-msm, linux-clk, linux-kernel, stable

With the addition of RPMh power domain to the GCC node in
device tree, we noticed a significant delay in getting the
UFS driver probed on AOSP which futher led to mount failures
because Android do not support rootwait. So adding a soft
dependency on RPMh power domain which informs modprobe to
load rpmhpd module before gcc-sdm845.

Cc: <stable@vger.kernel.org> # v5.4+
Fixes: 4b6ea15c0a11 ("arm64: dts: qcom: sdm845: Add missing RPMh power domain to GCC")
Suggested-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: Amit Pundir <amit.pundir@linaro.org>
---
 drivers/clk/qcom/gcc-sdm845.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/qcom/gcc-sdm845.c b/drivers/clk/qcom/gcc-sdm845.c
index 725cd52d2398..ea4c3bf4fb9b 100644
--- a/drivers/clk/qcom/gcc-sdm845.c
+++ b/drivers/clk/qcom/gcc-sdm845.c
@@ -4037,3 +4037,4 @@ module_exit(gcc_sdm845_exit);
 MODULE_DESCRIPTION("QTI GCC SDM845 Driver");
 MODULE_LICENSE("GPL v2");
 MODULE_ALIAS("platform:gcc-sdm845");
+MODULE_SOFTDEP("pre: rpmhpd");
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] clk: qcom: gcc-sdm845: Add soft dependency on rpmhpd
  2024-01-23  6:28 [PATCH] clk: qcom: gcc-sdm845: Add soft dependency on rpmhpd Amit Pundir
@ 2024-01-23  9:45 ` Manivannan Sadhasivam
  2024-01-27 22:34 ` Bjorn Andersson
  1 sibling, 0 replies; 3+ messages in thread
From: Manivannan Sadhasivam @ 2024-01-23  9:45 UTC (permalink / raw)
  To: Amit Pundir
  Cc: Bjorn Andersson, Konrad Dybcio, Michael Turquette, Stephen Boyd,
	Krzysztof Kozlowski, linux-arm-msm, linux-clk, linux-kernel,
	stable

On Tue, Jan 23, 2024 at 11:58:14AM +0530, Amit Pundir wrote:
> With the addition of RPMh power domain to the GCC node in
> device tree, we noticed a significant delay in getting the
> UFS driver probed on AOSP which futher led to mount failures
> because Android do not support rootwait. So adding a soft
> dependency on RPMh power domain which informs modprobe to
> load rpmhpd module before gcc-sdm845.
> 
> Cc: <stable@vger.kernel.org> # v5.4+
> Fixes: 4b6ea15c0a11 ("arm64: dts: qcom: sdm845: Add missing RPMh power domain to GCC")
> Suggested-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> Signed-off-by: Amit Pundir <amit.pundir@linaro.org>

Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

- Mani

> ---
>  drivers/clk/qcom/gcc-sdm845.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clk/qcom/gcc-sdm845.c b/drivers/clk/qcom/gcc-sdm845.c
> index 725cd52d2398..ea4c3bf4fb9b 100644
> --- a/drivers/clk/qcom/gcc-sdm845.c
> +++ b/drivers/clk/qcom/gcc-sdm845.c
> @@ -4037,3 +4037,4 @@ module_exit(gcc_sdm845_exit);
>  MODULE_DESCRIPTION("QTI GCC SDM845 Driver");
>  MODULE_LICENSE("GPL v2");
>  MODULE_ALIAS("platform:gcc-sdm845");
> +MODULE_SOFTDEP("pre: rpmhpd");
> -- 
> 2.25.1
> 

-- 
மணிவண்ணன் சதாசிவம்

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] clk: qcom: gcc-sdm845: Add soft dependency on rpmhpd
  2024-01-23  6:28 [PATCH] clk: qcom: gcc-sdm845: Add soft dependency on rpmhpd Amit Pundir
  2024-01-23  9:45 ` Manivannan Sadhasivam
@ 2024-01-27 22:34 ` Bjorn Andersson
  1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2024-01-27 22:34 UTC (permalink / raw)
  To: Konrad Dybcio, Michael Turquette, Stephen Boyd,
	Krzysztof Kozlowski, Manivannan Sadhasivam, Amit Pundir
  Cc: linux-arm-msm, linux-clk, linux-kernel, stable


On Tue, 23 Jan 2024 11:58:14 +0530, Amit Pundir wrote:
> With the addition of RPMh power domain to the GCC node in
> device tree, we noticed a significant delay in getting the
> UFS driver probed on AOSP which futher led to mount failures
> because Android do not support rootwait. So adding a soft
> dependency on RPMh power domain which informs modprobe to
> load rpmhpd module before gcc-sdm845.
> 
> [...]

Applied, thanks!

[1/1] clk: qcom: gcc-sdm845: Add soft dependency on rpmhpd
      commit: 1d9054e3a4fd36e2949e616f7360bdb81bcc1921

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-01-27 22:34 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-23  6:28 [PATCH] clk: qcom: gcc-sdm845: Add soft dependency on rpmhpd Amit Pundir
2024-01-23  9:45 ` Manivannan Sadhasivam
2024-01-27 22:34 ` Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).