* [PATCH] i3c: Make i3c_bus_type const
@ 2024-02-13 14:37 Ricardo B. Marliere
2024-02-13 17:29 ` Greg Kroah-Hartman
2024-02-19 20:23 ` Alexandre Belloni
0 siblings, 2 replies; 3+ messages in thread
From: Ricardo B. Marliere @ 2024-02-13 14:37 UTC (permalink / raw)
To: Alexandre Belloni
Cc: linux-i3c, linux-kernel, Greg Kroah-Hartman, Ricardo B. Marliere
Since commit d492cc2573a0 ("driver core: device.h: make struct
bus_type a const *"), the driver core can properly handle constant
struct bus_type, move the i3c_bus_type variable to be a constant
structure as well, placing it into read-only memory which can not be
modified at runtime.
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
---
drivers/i3c/internals.h | 2 +-
drivers/i3c/master.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/i3c/internals.h b/drivers/i3c/internals.h
index 908a807badaf..4d99a3524171 100644
--- a/drivers/i3c/internals.h
+++ b/drivers/i3c/internals.h
@@ -10,7 +10,7 @@
#include <linux/i3c/master.h>
-extern struct bus_type i3c_bus_type;
+extern const struct bus_type i3c_bus_type;
void i3c_bus_normaluse_lock(struct i3c_bus *bus);
void i3c_bus_normaluse_unlock(struct i3c_bus *bus);
diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c
index 3afa530c5e32..f32c591ae325 100644
--- a/drivers/i3c/master.c
+++ b/drivers/i3c/master.c
@@ -335,7 +335,7 @@ static void i3c_device_remove(struct device *dev)
i3c_device_free_ibi(i3cdev);
}
-struct bus_type i3c_bus_type = {
+const struct bus_type i3c_bus_type = {
.name = "i3c",
.match = i3c_device_match,
.probe = i3c_device_probe,
---
base-commit: 4fa0888f6f3e6a67cac5afafb23e33f8222cfdd0
change-id: 20240213-bus_cleanup-i3c-f15a6a2ee30a
Best regards,
--
Ricardo B. Marliere <ricardo@marliere.net>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] i3c: Make i3c_bus_type const
2024-02-13 14:37 [PATCH] i3c: Make i3c_bus_type const Ricardo B. Marliere
@ 2024-02-13 17:29 ` Greg Kroah-Hartman
2024-02-19 20:23 ` Alexandre Belloni
1 sibling, 0 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2024-02-13 17:29 UTC (permalink / raw)
To: Ricardo B. Marliere; +Cc: Alexandre Belloni, linux-i3c, linux-kernel
On Tue, Feb 13, 2024 at 11:37:31AM -0300, Ricardo B. Marliere wrote:
> Since commit d492cc2573a0 ("driver core: device.h: make struct
> bus_type a const *"), the driver core can properly handle constant
> struct bus_type, move the i3c_bus_type variable to be a constant
> structure as well, placing it into read-only memory which can not be
> modified at runtime.
>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
> ---
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] i3c: Make i3c_bus_type const
2024-02-13 14:37 [PATCH] i3c: Make i3c_bus_type const Ricardo B. Marliere
2024-02-13 17:29 ` Greg Kroah-Hartman
@ 2024-02-19 20:23 ` Alexandre Belloni
1 sibling, 0 replies; 3+ messages in thread
From: Alexandre Belloni @ 2024-02-19 20:23 UTC (permalink / raw)
To: Ricardo B. Marliere; +Cc: linux-i3c, linux-kernel, Greg Kroah-Hartman
On Tue, 13 Feb 2024 11:37:31 -0300, Ricardo B. Marliere wrote:
> Since commit d492cc2573a0 ("driver core: device.h: make struct
> bus_type a const *"), the driver core can properly handle constant
> struct bus_type, move the i3c_bus_type variable to be a constant
> structure as well, placing it into read-only memory which can not be
> modified at runtime.
>
>
> [...]
Applied, thanks!
[1/1] i3c: Make i3c_bus_type const
https://git.kernel.org/abelloni/c/8f06fb458539
Best regards,
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-02-19 20:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-13 14:37 [PATCH] i3c: Make i3c_bus_type const Ricardo B. Marliere
2024-02-13 17:29 ` Greg Kroah-Hartman
2024-02-19 20:23 ` Alexandre Belloni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).