linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH][next] net: chelsio: remove unused function calc_tx_descs
@ 2024-03-07 11:22 Colin Ian King
  2024-03-08 10:30 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: Colin Ian King @ 2024-03-07 11:22 UTC (permalink / raw)
  To: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, netdev
  Cc: kernel-janitors, linux-kernel

The inlined helper function calc_tx_descs is not used and is redundant.
Remove it.

Cleans up clang scan build warning:
drivers/net/ethernet/chelsio/cxgb4/sge.c:814:28: warning: unused
function 'calc_tx_descs' [-Wunused-function]

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 drivers/net/ethernet/chelsio/cxgb4/sge.c | 14 --------------
 1 file changed, 14 deletions(-)

diff --git a/drivers/net/ethernet/chelsio/cxgb4/sge.c b/drivers/net/ethernet/chelsio/cxgb4/sge.c
index b5ff2e1a9975..49d5808b7d11 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/sge.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/sge.c
@@ -803,20 +803,6 @@ static inline unsigned int calc_tx_flits(const struct sk_buff *skb,
 	return flits;
 }
 
-/**
- *	calc_tx_descs - calculate the number of Tx descriptors for a packet
- *	@skb: the packet
- *	@chip_ver: chip version
- *
- *	Returns the number of Tx descriptors needed for the given Ethernet
- *	packet, including the needed WR and CPL headers.
- */
-static inline unsigned int calc_tx_descs(const struct sk_buff *skb,
-					 unsigned int chip_ver)
-{
-	return flits_to_desc(calc_tx_flits(skb, chip_ver));
-}
-
 /**
  *	cxgb4_write_sgl - populate a scatter/gather list for a packet
  *	@skb: the packet
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH][next] net: chelsio: remove unused function calc_tx_descs
  2024-03-07 11:22 [PATCH][next] net: chelsio: remove unused function calc_tx_descs Colin Ian King
@ 2024-03-08 10:30 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-03-08 10:30 UTC (permalink / raw)
  To: Colin Ian King
  Cc: davem, edumazet, kuba, pabeni, netdev, kernel-janitors, linux-kernel

Hello:

This patch was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:

On Thu,  7 Mar 2024 11:22:37 +0000 you wrote:
> The inlined helper function calc_tx_descs is not used and is redundant.
> Remove it.
> 
> Cleans up clang scan build warning:
> drivers/net/ethernet/chelsio/cxgb4/sge.c:814:28: warning: unused
> function 'calc_tx_descs' [-Wunused-function]
> 
> [...]

Here is the summary with links:
  - [next] net: chelsio: remove unused function calc_tx_descs
    https://git.kernel.org/netdev/net-next/c/9b78bbef5138

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-03-08 10:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-07 11:22 [PATCH][next] net: chelsio: remove unused function calc_tx_descs Colin Ian King
2024-03-08 10:30 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).