linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v3] dt-bindings: rtc: zynqmp: Add support for Versal/Versal NET SoCs
@ 2024-03-07  9:43 Michal Simek
  2024-03-07 15:01 ` Rob Herring
  2024-03-08 11:06 ` Alexandre Belloni
  0 siblings, 2 replies; 3+ messages in thread
From: Michal Simek @ 2024-03-07  9:43 UTC (permalink / raw)
  To: linux-kernel, monstr, michal.simek, git
  Cc: Alexandre Belloni, Conor Dooley, Krzysztof Kozlowski,
	Rob Herring,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	moderated list:ARM/ZYNQ ARCHITECTURE,
	open list:REAL TIME CLOCK (RTC) SUBSYSTEM

Add support for Versal and Versal NET SoCs. Both of them should use the
same IP core but differences can be in integration part that's why create
separate compatible strings.

Also describe optional power-domains property. It is optional because power
domain doesn't need to be onwed by non secure firmware hence no access to
control it via any driver.

Signed-off-by: Michal Simek <michal.simek@amd.com>
---

Changes in v3:
- make versal/versal-net fallback to zynqmp

Changes in v2:
- Change subject
- Add compatible string for versal and versal NET
- Update commit message to reflect why power domain is optional.

 .../devicetree/bindings/rtc/xlnx,zynqmp-rtc.yaml      | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/rtc/xlnx,zynqmp-rtc.yaml b/Documentation/devicetree/bindings/rtc/xlnx,zynqmp-rtc.yaml
index d1f5eb996dba..01cc90fee81e 100644
--- a/Documentation/devicetree/bindings/rtc/xlnx,zynqmp-rtc.yaml
+++ b/Documentation/devicetree/bindings/rtc/xlnx,zynqmp-rtc.yaml
@@ -18,7 +18,13 @@ allOf:
 
 properties:
   compatible:
-    const: xlnx,zynqmp-rtc
+    oneOf:
+      - const: xlnx,zynqmp-rtc
+      - items:
+          - enum:
+              - xlnx,versal-rtc
+              - xlnx,versal-net-rtc
+          - const: xlnx,zynqmp-rtc
 
   reg:
     maxItems: 1
@@ -48,6 +54,9 @@ properties:
     default: 0x198233
     deprecated: true
 
+  power-domains:
+    maxItems: 1
+
 required:
   - compatible
   - reg
-- 
2.36.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v3] dt-bindings: rtc: zynqmp: Add support for Versal/Versal NET SoCs
  2024-03-07  9:43 [PATCH v3] dt-bindings: rtc: zynqmp: Add support for Versal/Versal NET SoCs Michal Simek
@ 2024-03-07 15:01 ` Rob Herring
  2024-03-08 11:06 ` Alexandre Belloni
  1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2024-03-07 15:01 UTC (permalink / raw)
  To: Michal Simek
  Cc: open list:REAL TIME CLOCK (RTC) SUBSYSTEM, Rob Herring, git,
	monstr, linux-kernel, Conor Dooley,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	michal.simek, moderated list:ARM/ZYNQ ARCHITECTURE,
	Alexandre Belloni, Krzysztof Kozlowski


On Thu, 07 Mar 2024 10:43:46 +0100, Michal Simek wrote:
> Add support for Versal and Versal NET SoCs. Both of them should use the
> same IP core but differences can be in integration part that's why create
> separate compatible strings.
> 
> Also describe optional power-domains property. It is optional because power
> domain doesn't need to be onwed by non secure firmware hence no access to
> control it via any driver.
> 
> Signed-off-by: Michal Simek <michal.simek@amd.com>
> ---
> 
> Changes in v3:
> - make versal/versal-net fallback to zynqmp
> 
> Changes in v2:
> - Change subject
> - Add compatible string for versal and versal NET
> - Update commit message to reflect why power domain is optional.
> 
>  .../devicetree/bindings/rtc/xlnx,zynqmp-rtc.yaml      | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
> 

Reviewed-by: Rob Herring <robh@kernel.org>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v3] dt-bindings: rtc: zynqmp: Add support for Versal/Versal NET SoCs
  2024-03-07  9:43 [PATCH v3] dt-bindings: rtc: zynqmp: Add support for Versal/Versal NET SoCs Michal Simek
  2024-03-07 15:01 ` Rob Herring
@ 2024-03-08 11:06 ` Alexandre Belloni
  1 sibling, 0 replies; 3+ messages in thread
From: Alexandre Belloni @ 2024-03-08 11:06 UTC (permalink / raw)
  To: linux-kernel, monstr, git, Michal Simek
  Cc: Conor Dooley, Krzysztof Kozlowski, Rob Herring,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	moderated list:ARM/ZYNQ ARCHITECTURE,
	open list:REAL TIME CLOCK (RTC) SUBSYSTEM

On Thu, 07 Mar 2024 10:43:46 +0100, Michal Simek wrote:
> Add support for Versal and Versal NET SoCs. Both of them should use the
> same IP core but differences can be in integration part that's why create
> separate compatible strings.
> 
> Also describe optional power-domains property. It is optional because power
> domain doesn't need to be onwed by non secure firmware hence no access to
> control it via any driver.
> 
> [...]

Applied, thanks!

[1/1] dt-bindings: rtc: zynqmp: Add support for Versal/Versal NET SoCs
      https://git.kernel.org/abelloni/c/f0109900462d

Best regards,

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-03-08 11:06 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-07  9:43 [PATCH v3] dt-bindings: rtc: zynqmp: Add support for Versal/Versal NET SoCs Michal Simek
2024-03-07 15:01 ` Rob Herring
2024-03-08 11:06 ` Alexandre Belloni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).