* [PATCH] phy: phy-rockchip-samsung-hdptx: Select CONFIG_RATIONAL
@ 2024-04-08 22:29 Cristian Ciocaltea
2024-04-11 19:03 ` Heiko Stuebner
2024-04-12 11:35 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Cristian Ciocaltea @ 2024-04-08 22:29 UTC (permalink / raw)
To: Vinod Koul, Kishon Vijay Abraham I, Heiko Stuebner, Algea Cao
Cc: linux-phy, linux-arm-kernel, linux-rockchip, linux-kernel,
kernel, kernel test robot
Ensure CONFIG_RATIONAL is selected in order to fix the following link
error with some kernel configurations:
drivers/phy/rockchip/phy-rockchip-samsung-hdptx.o: in function `rk_hdptx_ropll_tmds_cmn_config':
phy-rockchip-samsung-hdptx.c:(.text+0x950): undefined reference to `rational_best_approximation'
Fixes: 553be2830c5f ("phy: rockchip: Add Samsung HDMI/eDP Combo PHY driver")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202404090540.2l1TEkDF-lkp@intel.com/
Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
---
drivers/phy/rockchip/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/phy/rockchip/Kconfig b/drivers/phy/rockchip/Kconfig
index a34f67bb7e61..b60a4b60451e 100644
--- a/drivers/phy/rockchip/Kconfig
+++ b/drivers/phy/rockchip/Kconfig
@@ -87,6 +87,7 @@ config PHY_ROCKCHIP_SAMSUNG_HDPTX
tristate "Rockchip Samsung HDMI/eDP Combo PHY driver"
depends on (ARCH_ROCKCHIP || COMPILE_TEST) && OF
select GENERIC_PHY
+ select RATIONAL
help
Enable this to support the Rockchip HDMI/eDP Combo PHY
with Samsung IP block.
--
2.44.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] phy: phy-rockchip-samsung-hdptx: Select CONFIG_RATIONAL
2024-04-08 22:29 [PATCH] phy: phy-rockchip-samsung-hdptx: Select CONFIG_RATIONAL Cristian Ciocaltea
@ 2024-04-11 19:03 ` Heiko Stuebner
2024-04-12 11:35 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Heiko Stuebner @ 2024-04-11 19:03 UTC (permalink / raw)
To: Vinod Koul, Kishon Vijay Abraham I, Algea Cao, Cristian Ciocaltea
Cc: linux-phy, linux-arm-kernel, linux-rockchip, linux-kernel,
kernel, kernel test robot
Am Dienstag, 9. April 2024, 00:29:25 CEST schrieb Cristian Ciocaltea:
> Ensure CONFIG_RATIONAL is selected in order to fix the following link
> error with some kernel configurations:
>
> drivers/phy/rockchip/phy-rockchip-samsung-hdptx.o: in function `rk_hdptx_ropll_tmds_cmn_config':
> phy-rockchip-samsung-hdptx.c:(.text+0x950): undefined reference to `rational_best_approximation'
>
> Fixes: 553be2830c5f ("phy: rockchip: Add Samsung HDMI/eDP Combo PHY driver")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202404090540.2l1TEkDF-lkp@intel.com/
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> ---
> drivers/phy/rockchip/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/phy/rockchip/Kconfig b/drivers/phy/rockchip/Kconfig
> index a34f67bb7e61..b60a4b60451e 100644
> --- a/drivers/phy/rockchip/Kconfig
> +++ b/drivers/phy/rockchip/Kconfig
> @@ -87,6 +87,7 @@ config PHY_ROCKCHIP_SAMSUNG_HDPTX
> tristate "Rockchip Samsung HDMI/eDP Combo PHY driver"
> depends on (ARCH_ROCKCHIP || COMPILE_TEST) && OF
> select GENERIC_PHY
> + select RATIONAL
> help
> Enable this to support the Rockchip HDMI/eDP Combo PHY
> with Samsung IP block.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] phy: phy-rockchip-samsung-hdptx: Select CONFIG_RATIONAL
2024-04-08 22:29 [PATCH] phy: phy-rockchip-samsung-hdptx: Select CONFIG_RATIONAL Cristian Ciocaltea
2024-04-11 19:03 ` Heiko Stuebner
@ 2024-04-12 11:35 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2024-04-12 11:35 UTC (permalink / raw)
To: Kishon Vijay Abraham I, Heiko Stuebner, Algea Cao, Cristian Ciocaltea
Cc: linux-phy, linux-arm-kernel, linux-rockchip, linux-kernel,
kernel, kernel test robot
On Tue, 09 Apr 2024 01:29:25 +0300, Cristian Ciocaltea wrote:
> Ensure CONFIG_RATIONAL is selected in order to fix the following link
> error with some kernel configurations:
>
> drivers/phy/rockchip/phy-rockchip-samsung-hdptx.o: in function `rk_hdptx_ropll_tmds_cmn_config':
> phy-rockchip-samsung-hdptx.c:(.text+0x950): undefined reference to `rational_best_approximation'
>
>
> [...]
Applied, thanks!
[1/1] phy: phy-rockchip-samsung-hdptx: Select CONFIG_RATIONAL
commit: e1c9216bec2793d051f83d77d93d3d6a899d06d1
Best regards,
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-12 11:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-08 22:29 [PATCH] phy: phy-rockchip-samsung-hdptx: Select CONFIG_RATIONAL Cristian Ciocaltea
2024-04-11 19:03 ` Heiko Stuebner
2024-04-12 11:35 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).