linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drm/bridge: dw-mipi-dsi.c: remove unused header file
@ 2020-04-03 13:30 Angelo Ribeiro
  2020-06-24 15:08 ` Yannick FERTRE
  0 siblings, 1 reply; 3+ messages in thread
From: Angelo Ribeiro @ 2020-04-03 13:30 UTC (permalink / raw)
  To: yannick.fertre, philippe.cornu, benjamin.gaignard, airlied,
	daniel, mcoquelin.stm32, alexandre.torgue, dri-devel,
	linux-stm32, linux-arm-kernel, linux-kernel
  Cc: Angelo Ribeiro, Gustavo Pimentel, Joao Pinto, Jose Abreu

dw-mipi-dsi does not use any definition from drm_probe_helper.

Coverity output:
Event unnecessary_header:
Including .../include/drm/drm_probe_helper.h does not provide any
needed symbols.

Cc: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
Cc: Joao Pinto <jpinto@synopsys.com>
Cc: Jose Abreu <jose.abreu@synopsys.com>
Signed-off-by: Angelo Ribeiro <angelo.ribeiro@synopsys.com>
---
 drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
index 024acad..582635d 100644
--- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
+++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
@@ -27,7 +27,6 @@
 #include <drm/drm_modes.h>
 #include <drm/drm_of.h>
 #include <drm/drm_print.h>
-#include <drm/drm_probe_helper.h>
 
 #define HWVER_131			0x31333100	/* IP version 1.31 */
 
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] drm/bridge: dw-mipi-dsi.c: remove unused header file
  2020-04-03 13:30 [PATCH] drm/bridge: dw-mipi-dsi.c: remove unused header file Angelo Ribeiro
@ 2020-06-24 15:08 ` Yannick FERTRE
  2020-06-25  7:53   ` Daniel Vetter
  0 siblings, 1 reply; 3+ messages in thread
From: Yannick FERTRE @ 2020-06-24 15:08 UTC (permalink / raw)
  To: Angelo Ribeiro, Philippe CORNU, Benjamin GAIGNARD, airlied,
	daniel, mcoquelin.stm32, Alexandre TORGUE, dri-devel,
	linux-stm32, linux-arm-kernel, linux-kernel
  Cc: Gustavo Pimentel, Joao Pinto, Jose Abreu

Hello Angelo,
thank for patch.

Reviewed-by: Yannick Fertre <yannick.fertre@st.com>



On 4/3/20 3:30 PM, Angelo Ribeiro wrote:
> dw-mipi-dsi does not use any definition from drm_probe_helper.
> 
> Coverity output:
> Event unnecessary_header:
> Including .../include/drm/drm_probe_helper.h does not provide any
> needed symbols.
> 
> Cc: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
> Cc: Joao Pinto <jpinto@synopsys.com>
> Cc: Jose Abreu <jose.abreu@synopsys.com>
> Signed-off-by: Angelo Ribeiro <angelo.ribeiro@synopsys.com>
> ---
>   drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
> index 024acad..582635d 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
> @@ -27,7 +27,6 @@
>   #include <drm/drm_modes.h>
>   #include <drm/drm_of.h>
>   #include <drm/drm_print.h>
> -#include <drm/drm_probe_helper.h>
>   
>   #define HWVER_131			0x31333100	/* IP version 1.31 */
>   
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] drm/bridge: dw-mipi-dsi.c: remove unused header file
  2020-06-24 15:08 ` Yannick FERTRE
@ 2020-06-25  7:53   ` Daniel Vetter
  0 siblings, 0 replies; 3+ messages in thread
From: Daniel Vetter @ 2020-06-25  7:53 UTC (permalink / raw)
  To: Yannick FERTRE
  Cc: Angelo Ribeiro, Philippe CORNU, Benjamin GAIGNARD, airlied,
	daniel, mcoquelin.stm32, Alexandre TORGUE, dri-devel,
	linux-stm32, linux-arm-kernel, linux-kernel, Gustavo Pimentel,
	Joao Pinto, Jose Abreu

On Wed, Jun 24, 2020 at 03:08:22PM +0000, Yannick FERTRE wrote:
> Hello Angelo,
> thank for patch.
> 
> Reviewed-by: Yannick Fertre <yannick.fertre@st.com>

Patch applied, thanks.
-Daniel

> 
> 
> 
> On 4/3/20 3:30 PM, Angelo Ribeiro wrote:
> > dw-mipi-dsi does not use any definition from drm_probe_helper.
> > 
> > Coverity output:
> > Event unnecessary_header:
> > Including .../include/drm/drm_probe_helper.h does not provide any
> > needed symbols.
> > 
> > Cc: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
> > Cc: Joao Pinto <jpinto@synopsys.com>
> > Cc: Jose Abreu <jose.abreu@synopsys.com>
> > Signed-off-by: Angelo Ribeiro <angelo.ribeiro@synopsys.com>
> > ---
> >   drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 1 -
> >   1 file changed, 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
> > index 024acad..582635d 100644
> > --- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
> > +++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
> > @@ -27,7 +27,6 @@
> >   #include <drm/drm_modes.h>
> >   #include <drm/drm_of.h>
> >   #include <drm/drm_print.h>
> > -#include <drm/drm_probe_helper.h>
> >   
> >   #define HWVER_131			0x31333100	/* IP version 1.31 */
> >   
> > 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-06-25  7:53 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-03 13:30 [PATCH] drm/bridge: dw-mipi-dsi.c: remove unused header file Angelo Ribeiro
2020-06-24 15:08 ` Yannick FERTRE
2020-06-25  7:53   ` Daniel Vetter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).