From: Mark Lord <mlord@pobox.com>
To: Kai Heng Feng <kai.heng.feng@canonical.com>
Cc: Ansis Atteka <aatteka@nicira.com>,
Hayes Wang <hayeswang@realtek.com>,
David Miller <davem@davemloft.net>,
"greg@kroah.com" <greg@kroah.com>,
"romieu@fr.zoreil.com" <romieu@fr.zoreil.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
nic_swsd <nic_swsd@realtek.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
Mario Limonciello <mario.limonciello@dell.com>
Subject: Re: r8152: data corruption in various scenarios
Date: Sun, 6 Jan 2019 16:13:13 -0500 [thread overview]
Message-ID: <1726a1ef-cfa7-0f97-4388-bf2ba72cb9a9@pobox.com> (raw)
In-Reply-To: <3D7273C4-D378-42D5-92FA-4ED72041D820@canonical.com>
On 2019-01-06 2:14 p.m., Kai Heng Feng wrote:>> On Jan 5, 2019, at 10:14 PM, Mark Lord
<mlord@pobox.com> wrote:
..
>> There is even now a special hack in the upstream r8152.c to attempt to detect
>> a Dell TB16 dock and disable RX Aggregation in the driver to prevent such issues.
>>
>> Well.. I have a WD15 dock, not a TB16, and that same hack also catches my dock
>> in its net:
>>
>> [5.794641] usb 4-1.2: Dell TB16 Dock, disable RX aggregation
>
> The serial should be unique according to Dell.
>
>> So one issue is that the code is not correctly identifying the dock,
>> and the WD15 is claimed to be immune from the r8152 issues.
>
> The WD15 I tested didn't use that serial number though...
What info do you need from me about the WD15 so this can be corrected?
>> xhci_hcd 0000:39:00.0: ERROR Transfer event TRB DMA ptr not part of current TD ep_index 13
>> comp_code 1
>
> This is probably an xHC bug. A similar issue is fixed by commit 9da5a1092b13
> ("xhci: Bad Ethernet performance plugged in ASM1042A host”).
>
>> I just got that exact message above, with the r8152 in my 1-day old WD15 dock,
>> with the TB16 "workaround" enabled in Linux kernel 4.20.0.
>
> Is the xHC WD15 connected an ASMedia one?
I don't know. I *think* it identifies as a DSL6340 (see below).
Here is lspci and lsusb:
$ lspci -vt
-[0000:00]-+-00.0 Intel Corporation Xeon E3-1200 v6/7th Gen Core Processor Host Bridge/DRAM Registers
+-02.0 Intel Corporation UHD Graphics 620
+-04.0 Intel Corporation Skylake Processor Thermal Subsystem
+-14.0 Intel Corporation Sunrise Point-LP USB 3.0 xHCI Controller
+-14.2 Intel Corporation Sunrise Point-LP Thermal subsystem
+-15.0 Intel Corporation Sunrise Point-LP Serial IO I2C Controller #0
+-15.1 Intel Corporation Sunrise Point-LP Serial IO I2C Controller #1
+-16.0 Intel Corporation Sunrise Point-LP CSME HECI #1
+-1c.0-[01-39]----00.0-[02-39]--+-00.0-[03]--
| +-01.0-[04-38]--
| \-02.0-[39]----00.0 Intel Corporation DSL6340 USB 3.1
Controller [Alpine Ridge]
+-1c.4-[3a]----00.0 Qualcomm Atheros QCA6174 802.11ac Wireless Network Adapter
+-1d.0-[3b]----00.0 Samsung Electronics Co Ltd Device a808
+-1f.0 Intel Corporation Device 9d4e
+-1f.2 Intel Corporation Sunrise Point-LP PMC
+-1f.3 Intel Corporation Sunrise Point-LP HD Audio
\-1f.4 Intel Corporation Sunrise Point-LP SMBus
$ lsusb -t
/: Bus 04.Port 1: Dev 1, Class=root_hub, Driver=xhci_hcd/2p, 10000M
|__ Port 1: Dev 2, If 0, Class=Hub, Driver=hub/7p, 5000M
|__ Port 2: Dev 3, If 0, Class=Vendor Specific Class, Driver=r8152, 5000M
/: Bus 03.Port 1: Dev 1, Class=root_hub, Driver=xhci_hcd/2p, 480M
|__ Port 1: Dev 2, If 0, Class=Hub, Driver=hub/7p, 480M
|__ Port 5: Dev 3, If 1, Class=Audio, Driver=snd-usb-audio, 480M
|__ Port 5: Dev 3, If 2, Class=Audio, Driver=snd-usb-audio, 480M
|__ Port 5: Dev 3, If 0, Class=Audio, Driver=snd-usb-audio, 480M
|__ Port 5: Dev 3, If 3, Class=Audio, Driver=snd-usb-audio, 480M
|__ Port 6: Dev 4, If 0, Class=Human Interface Device, Driver=usbhid, 12M
|__ Port 6: Dev 4, If 1, Class=Human Interface Device, Driver=usbhid, 12M
|__ Port 6: Dev 4, If 2, Class=Human Interface Device, Driver=usbhid, 12M
|__ Port 7: Dev 5, If 0, Class=Human Interface Device, Driver=usbhid, 1.5M
/: Bus 02.Port 1: Dev 1, Class=root_hub, Driver=xhci_hcd/6p, 5000M
/: Bus 01.Port 1: Dev 1, Class=root_hub, Driver=xhci_hcd/12p, 480M
|__ Port 3: Dev 2, If 0, Class=Wireless, Driver=btusb, 12M
|__ Port 3: Dev 2, If 1, Class=Wireless, Driver=btusb, 12M
Thanks for having a look.
--
Mark Lord
Real-Time Remedies Inc.
mlord@pobox.com
next prev parent reply other threads:[~2019-01-06 21:13 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-11 7:15 [PATCH net 0/2] r8152: rx patches Hayes Wang
2016-11-11 7:15 ` [PATCH net 1/2] r8152: fix the sw rx checksum is unavailable Hayes Wang
2016-11-17 3:36 ` Hayes Wang
2016-11-17 14:14 ` Mark Lord
2016-11-17 14:25 ` Mark Lord
[not found] ` <d683c019-4e0f-6fe6-368c-c4fc86c72fe6@pobox.com>
2016-11-18 7:57 ` Hayes Wang
2016-11-18 12:03 ` Mark Lord
2016-11-22 13:12 ` Mark Lord
2016-11-23 3:52 ` Hayes Wang
2016-11-23 13:41 ` Mark Lord
2016-11-23 15:12 ` Hayes Wang
2016-11-23 19:29 ` Mark Lord
2016-11-24 3:24 ` Hayes Wang
2016-11-24 12:31 ` Mark Lord
2016-11-24 13:26 ` Hayes Wang
2016-11-24 15:24 ` Mark Lord
2016-11-25 6:11 ` Hayes Wang
2016-11-25 12:36 ` Mark Lord
2016-11-24 16:21 ` David Miller
2016-11-24 16:43 ` Mark Lord
2016-11-24 17:00 ` Mark Lord
2016-11-24 17:13 ` David Miller
2016-11-24 17:11 ` David Miller
2016-11-24 18:34 ` Mark Lord
2016-11-24 18:49 ` Mark Lord
2016-11-24 19:00 ` Greg KH
2016-11-24 19:10 ` Mark Lord
2016-11-24 19:17 ` Greg KH
2016-11-25 9:52 ` Hayes Wang
2016-11-25 13:32 ` Mark Lord
2016-11-25 0:27 ` Francois Romieu
2016-11-25 3:49 ` Mark Lord
2016-11-25 9:53 ` Greg KH
2016-11-25 12:34 ` Mark Lord
2016-11-25 12:41 ` Mark Lord
2016-11-25 14:22 ` Greg KH
2016-11-25 14:35 ` Mark Lord
2016-11-25 12:49 ` Mark Lord
2016-11-25 14:24 ` Greg KH
2016-11-25 16:58 ` David Miller
2016-11-30 11:58 ` Hayes Wang
2016-12-09 3:23 ` Hayes Wang
2016-12-09 13:05 ` Mark Lord
2017-01-01 0:07 ` Ansis Atteka
2017-01-03 0:40 ` Ansis Atteka
2017-01-03 13:19 ` Mark Lord
2017-01-09 7:58 ` Hayes Wang
2019-01-05 14:14 ` r8152: data corruption in various scenarios Mark Lord
2019-01-05 14:22 ` Mark Lord
2019-01-06 19:14 ` Kai Heng Feng
2019-01-06 21:13 ` Mark Lord [this message]
2019-01-06 21:16 ` Mark Lord
2019-01-07 3:53 ` Hayes Wang
2019-01-07 16:01 ` Mario.Limonciello
2019-01-07 18:06 ` Mark Lord
2019-01-07 18:27 ` Mario.Limonciello
2019-01-07 19:24 ` Mark Lord
2019-01-07 4:09 ` Kai Heng Feng
2019-01-07 4:13 ` Mark Lord
2019-01-07 6:46 ` Kai Heng Feng
2019-01-07 7:01 ` Mark Lord
2016-11-24 18:42 ` [PATCH net 1/2] r8152: fix the sw rx checksum is unavailable Greg KH
2016-11-24 18:58 ` Mark Lord
2016-11-25 6:31 ` Hayes Wang
2016-11-25 6:51 ` Hayes Wang
2016-11-25 12:35 ` Mark Lord
2016-11-24 16:19 ` David Miller
2016-11-24 12:37 ` Hayes Wang
2016-11-11 7:15 ` [PATCH net 2/2] r8152: rx descriptor check Hayes Wang
2016-11-11 12:13 ` Francois Romieu
2016-11-12 13:21 ` Mark Lord
2016-11-14 6:43 ` Hayes Wang
2016-11-15 1:10 ` Francois Romieu
2016-11-17 3:05 ` Hayes Wang
2016-11-13 17:39 ` David Miller
2016-11-13 20:34 ` Mark Lord
2016-11-13 20:38 ` Mark Lord
2016-11-14 7:23 ` Hayes Wang
2016-11-14 17:27 ` David Miller
2016-11-14 7:03 ` Hayes Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1726a1ef-cfa7-0f97-4388-bf2ba72cb9a9@pobox.com \
--to=mlord@pobox.com \
--cc=aatteka@nicira.com \
--cc=davem@davemloft.net \
--cc=greg@kroah.com \
--cc=hayeswang@realtek.com \
--cc=kai.heng.feng@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mario.limonciello@dell.com \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).