From: Nathan Scott <nathans@redhat.com>
To: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>,
"Eric W. Biederman" <ebiederm@xmission.com>
Cc: Serge Hallyn <serge.hallyn@ubuntu.com>,
containers@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [resend][PATCH v9 2/3] /proc/PID/status: show all sets of pid according to ns
Date: Tue, 3 Feb 2015 20:12:08 -0500 (EST) [thread overview]
Message-ID: <175563041.6778432.1423012328350.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <55349719.6775592.1423011445985.JavaMail.zimbra@redhat.com>
Hi Chen, Eric,
Eric W. Biederman <ebiederm@xmission.com> writes:
> Chen Hanxiao <chenhanxiao@cn.fujitsu.com> writes:
> > If some issues occurred inside a container guest, host user
> > could not know which process is in trouble just by guest pid:
> > [...]
> > Acked-by: Serge Hallyn <serge.hallyn@canonical.com>
> > Tested-by: Serge Hallyn <serge.hallyn@canonical.com>
> >
> > Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
>
> Acked-by: "Eric W. Biederman" <ebiederm@xmission.com>
>
> At a quick review and read through this looks good. Once I finish
> clearing the security bug fixes from my tree I will see about picking
> this up.
I recently came across a need for this patch so I just wanted to
say thanks and since I've used it a fair bit feel free to add:
Tested-by: Nathan Scott <nathans@redhat.com>
One small tweak you could make is to drop the extra whitespace
from those new seq_printf calls - "\t%d " has a trailing space
that isn't needed.
Also there's proc status docs below Documentation/ that should be
updated for these changes. They are slightly out-of-date already
and there's a few typos in the vicinity - something like this may
do the trick though ... ? (will need to be updated at merge time
with the correct kernel version)
docs: add missing and new /proc/PID/status file entries, fix typos
Signed-off-by: Nathan Scott <nathans@redhat.com>
diff --git a/Documentation/filesystems/proc.txt b/Documentation/filesystems/proc.txt
index aae9dd1..457cebd 100644
--- a/Documentation/filesystems/proc.txt
+++ b/Documentation/filesystems/proc.txt
@@ -197,12 +197,12 @@ contains details information about the process itself. Its fields are
explained in Table 1-4.
(for SMP CONFIG users)
-For making accounting scalable, RSS related information are handled in
-asynchronous manner and the vaule may not be very precise. To see a precise
+For making accounting scalable, RSS related information are handled in an
+asynchronous manner and the value may not be very precise. To see a precise
snapshot of a moment, you can see /proc/<pid>/smaps file and scan page table.
It's slow but very precise.
-Table 1-2: Contents of the status files (as of 2.6.30-rc7)
+Table 1-2: Contents of the status files (as of 3.20.0)
..............................................................................
Field Content
Name filename of the executable
@@ -210,6 +210,7 @@ Table 1-2: Contents of the status files (as of 2.6.30-rc7)
in an uninterruptible wait, Z is zombie,
T is traced or stopped)
Tgid thread group ID
+ Ngid NUMA group ID (0 if none)
Pid process id
PPid process id of the parent process
TracerPid PID of process tracing this process (0 if not)
@@ -217,6 +218,10 @@ Table 1-2: Contents of the status files (as of 2.6.30-rc7)
Gid Real, effective, saved set, and file system GIDs
FDSize number of file descriptor slots currently allocated
Groups supplementary group list
+ NStgid descendant namespace thread group ID hierarchy
+ NSpid descendant namespace process ID hierarchy
+ NSpgid descendant namespace process group ID hierarchy
+ NSsid descendant namespace session ID hierarchy
VmPeak peak virtual memory size
VmSize total program size
VmLck locked memory size
next parent reply other threads:[~2015-02-04 1:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <55349719.6775592.1423011445985.JavaMail.zimbra@redhat.com>
2015-02-04 1:12 ` Nathan Scott [this message]
2014-12-23 10:20 [resend][PATCH v9 0/3] ns, procfs: pid conversion between ns and showing pidns hierarchy Chen Hanxiao
2014-12-23 10:20 ` [resend][PATCH v9 2/3] /proc/PID/status: show all sets of pid according to ns Chen Hanxiao
2014-12-30 5:39 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175563041.6778432.1423012328350.JavaMail.zimbra@redhat.com \
--to=nathans@redhat.com \
--cc=chenhanxiao@cn.fujitsu.com \
--cc=containers@lists.linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=serge.hallyn@ubuntu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).