From: ebiederm@xmission.com (Eric W. Biederman)
To: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
Cc: Serge Hallyn <serge.hallyn@ubuntu.com>,
Andrew Morton <akpm@linux-foundation.org>,
Pavel Emelyanov <xemul@parallels.com>,
<containers@lists.linux-foundation.org>,
<linux-kernel@vger.kernel.org>,
David Howells <dhowells@redhat.com>,
Vasiliy Kulikov <segooon@gmail.com>,
Mateusz Guzik <mguzik@redhat.com>,
Oleg Nesterov <oleg@redhat.com>,
Richard Weinberger <richard.weinberger@gmail.com>
Subject: Re: [resend][PATCH v9 2/3] /proc/PID/status: show all sets of pid according to ns
Date: Mon, 29 Dec 2014 23:39:26 -0600 [thread overview]
Message-ID: <87k3191ysx.fsf@x220.int.ebiederm.org> (raw)
In-Reply-To: <1419330039-29207-3-git-send-email-chenhanxiao@cn.fujitsu.com> (Chen Hanxiao's message of "Tue, 23 Dec 2014 18:20:38 +0800")
Chen Hanxiao <chenhanxiao@cn.fujitsu.com> writes:
> If some issues occurred inside a container guest, host user
> could not know which process is in trouble just by guest pid:
> the users of container guest only knew the pid inside containers.
> This will bring obstacle for trouble shooting.
>
> This patch adds four fields: NStgid, NSpid, NSpgid and NSsid:
> a) In init_pid_ns, nothing changed;
>
> b) In one pidns, will tell the pid inside containers:
> NStgid: 21776 5 1
> NSpid: 21776 5 1
> NSpgid: 21776 5 1
> NSsid: 21729 1 0
> ** Process id is 21776 in level 0, 5 in level 1, 1 in level 2.
>
> c) If pidns is nested, it depends on which pidns are you in.
> NStgid: 5 1
> NSpid: 5 1
> NSpgid: 5 1
> NSsid: 1 0
> ** Views from level 1
>
> Acked-by: Serge Hallyn <serge.hallyn@canonical.com>
> Tested-by: Serge Hallyn <serge.hallyn@canonical.com>
>
> Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
Acked-by: "Eric W. Biederman" <ebiederm@xmission.com>
At a quick review and read through this looks good. Once I finish
clearing the security bug fixes from my tree I will see about picking this
up.
Eric
> ---
> v9: rebased on 3.19-rc1
> No change from v4-v8
> v3: add another two fielsd: NSpgid and NSsid.
> v2: add two new fields: NStgid and NSpid.
> keep fields of Tgid and Pid unchanged for back compatibility.
>
> fs/proc/array.c | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/fs/proc/array.c b/fs/proc/array.c
> index bd117d0..35205d4 100644
> --- a/fs/proc/array.c
> +++ b/fs/proc/array.c
> @@ -208,6 +208,22 @@ static inline void task_state(struct seq_file *m, struct pid_namespace *ns,
> from_kgid_munged(user_ns, GROUP_AT(group_info, g)));
> put_cred(cred);
>
> + seq_puts(m, "\nNStgid:");
> + for (g = ns->level; g <= pid->level; g++)
> + seq_printf(m, "\t%d ",
> + task_tgid_nr_ns(p, pid->numbers[g].ns));
> + seq_puts(m, "\nNSpid:");
> + for (g = ns->level; g <= pid->level; g++)
> + seq_printf(m, "\t%d ",
> + task_pid_nr_ns(p, pid->numbers[g].ns));
> + seq_puts(m, "\nNSpgid:");
> + for (g = ns->level; g <= pid->level; g++)
> + seq_printf(m, "\t%d ",
> + task_pgrp_nr_ns(p, pid->numbers[g].ns));
> + seq_puts(m, "\nNSsid:");
> + for (g = ns->level; g <= pid->level; g++)
> + seq_printf(m, "\t%d ",
> + task_session_nr_ns(p, pid->numbers[g].ns));
> seq_putc(m, '\n');
> }
next prev parent reply other threads:[~2014-12-30 5:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-23 10:20 [resend][PATCH v9 0/3] ns, procfs: pid conversion between ns and showing pidns hierarchy Chen Hanxiao
2014-12-23 10:20 ` [resend][PATCH v9 1/3] procfs: show hierarchy of pid namespace Chen Hanxiao
2014-12-30 1:17 ` Chen, Hanxiao
2014-12-30 5:54 ` Eric W. Biederman
2014-12-23 10:20 ` [resend][PATCH v9 2/3] /proc/PID/status: show all sets of pid according to ns Chen Hanxiao
2014-12-30 5:39 ` Eric W. Biederman [this message]
2014-12-23 10:20 ` [PATCH v9 3/3] Documentation: add docs for /proc/pidns_hierarchy Chen Hanxiao
[not found] <55349719.6775592.1423011445985.JavaMail.zimbra@redhat.com>
2015-02-04 1:12 ` [resend][PATCH v9 2/3] /proc/PID/status: show all sets of pid according to ns Nathan Scott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k3191ysx.fsf@x220.int.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=akpm@linux-foundation.org \
--cc=chenhanxiao@cn.fujitsu.com \
--cc=containers@lists.linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mguzik@redhat.com \
--cc=oleg@redhat.com \
--cc=richard.weinberger@gmail.com \
--cc=segooon@gmail.com \
--cc=serge.hallyn@ubuntu.com \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).