From: Christian Eggers <ceggers@arri.de>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: Woojung Huh <woojung.huh@microchip.com>,
Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [net v2] net: dsa: microchip: fix race condition
Date: Tue, 6 Oct 2020 18:30:57 +0200 [thread overview]
Message-ID: <1774255.9Jiduhijpd@n95hx1g2> (raw)
In-Reply-To: <20201006162125.ulftqdiufdxjesn7@skbuf>
On Tuesday, 6 October 2020, 18:21:25 CEST, Vladimir Oltean wrote:
> On Tue, Oct 06, 2020 at 05:56:51PM +0200, Christian Eggers wrote:
> > - Checking for mib_read_interval in ksz_switch_remove() can be obmitted,
> > as the condition is always true when ksz_switch_remove() is called.
>
> If there's an error in the probe path, I expect that the
> mib_read_interval will not get set, and the delayed workqueue will not
> be scheduled, will it? So I think the check is ok there.
If think that ksz_switch_remove() will not be called at all if there is an
error in the probe path. In all other cases, the work should be queued.
Regards
Christian
next prev parent reply other threads:[~2020-10-06 16:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-06 15:56 [net v2] net: dsa: microchip: fix race condition Christian Eggers
2020-10-06 16:21 ` Vladimir Oltean
2020-10-06 16:24 ` Vladimir Oltean
2020-10-06 16:30 ` Christian Eggers [this message]
2020-10-06 16:57 ` Vladimir Oltean
2020-10-06 20:36 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1774255.9Jiduhijpd@n95hx1g2 \
--to=ceggers@arri.de \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=vivien.didelot@gmail.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).