From: Vladimir Oltean <olteanv@gmail.com>
To: Christian Eggers <ceggers@arri.de>
Cc: Woojung Huh <woojung.huh@microchip.com>,
Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [net v2] net: dsa: microchip: fix race condition
Date: Tue, 6 Oct 2020 19:24:36 +0300 [thread overview]
Message-ID: <20201006162436.ri5ifcqr5xsec3m3@skbuf> (raw)
In-Reply-To: <20201006162125.ulftqdiufdxjesn7@skbuf>
On Tue, Oct 06, 2020 at 07:21:25PM +0300, Vladimir Oltean wrote:
> You forgot to copy Florian's review tag from v1.
Ah, Florian did not leave a review tag in v1. Just a comment:
> don't you need to pair the test for dev->mib_read_internal being non
> zero with setting it to zero in ksz_switch_unregister()?
I may be wrong, but I don't think that setting the interval to zero in
unregister() would change anything.
next prev parent reply other threads:[~2020-10-06 16:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-06 15:56 [net v2] net: dsa: microchip: fix race condition Christian Eggers
2020-10-06 16:21 ` Vladimir Oltean
2020-10-06 16:24 ` Vladimir Oltean [this message]
2020-10-06 16:30 ` Christian Eggers
2020-10-06 16:57 ` Vladimir Oltean
2020-10-06 20:36 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201006162436.ri5ifcqr5xsec3m3@skbuf \
--to=olteanv@gmail.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=ceggers@arri.de \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).