* [PATCH] thermal: intel: int340x_thermal: Remove unnecessary acpi_has_method() uses
@ 2019-07-17 19:26 Kelsey Skunberg
2019-07-18 8:36 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: Kelsey Skunberg @ 2019-07-17 19:26 UTC (permalink / raw)
To: rui.zhang, edubezval, daniel.lezcano, linux-pm, linux-kernel
Cc: skunberg.kelsey, bjorn, skhan, linux-kernel-mentees, rjw
acpi_evaluate_object() will already return in error if the method does not
exist. Checking if the method is absent before the acpi_evaluate_object()
call is not needed. Remove acpi_has_method() calls to avoid additional
work.
Signed-off-by: Kelsey Skunberg <skunberg.kelsey@gmail.com>
---
drivers/thermal/intel/int340x_thermal/acpi_thermal_rel.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/thermal/intel/int340x_thermal/acpi_thermal_rel.c b/drivers/thermal/intel/int340x_thermal/acpi_thermal_rel.c
index 9716bc3abaf9..7130e90773ed 100644
--- a/drivers/thermal/intel/int340x_thermal/acpi_thermal_rel.c
+++ b/drivers/thermal/intel/int340x_thermal/acpi_thermal_rel.c
@@ -77,9 +77,6 @@ int acpi_parse_trt(acpi_handle handle, int *trt_count, struct trt **trtp,
struct acpi_buffer element = { 0, NULL };
struct acpi_buffer trt_format = { sizeof("RRNNNNNN"), "RRNNNNNN" };
- if (!acpi_has_method(handle, "_TRT"))
- return -ENODEV;
-
status = acpi_evaluate_object(handle, "_TRT", NULL, &buffer);
if (ACPI_FAILURE(status))
return -ENODEV;
@@ -158,9 +155,6 @@ int acpi_parse_art(acpi_handle handle, int *art_count, struct art **artp,
struct acpi_buffer art_format = {
sizeof("RRNNNNNNNNNNN"), "RRNNNNNNNNNNN" };
- if (!acpi_has_method(handle, "_ART"))
- return -ENODEV;
-
status = acpi_evaluate_object(handle, "_ART", NULL, &buffer);
if (ACPI_FAILURE(status))
return -ENODEV;
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] thermal: intel: int340x_thermal: Remove unnecessary acpi_has_method() uses
2019-07-17 19:26 [PATCH] thermal: intel: int340x_thermal: Remove unnecessary acpi_has_method() uses Kelsey Skunberg
@ 2019-07-18 8:36 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2019-07-18 8:36 UTC (permalink / raw)
To: Kelsey Skunberg
Cc: rui.zhang, edubezval, daniel.lezcano, linux-pm, linux-kernel,
bjorn, skhan, linux-kernel-mentees
On Wednesday, July 17, 2019 9:26:39 PM CEST Kelsey Skunberg wrote:
> acpi_evaluate_object() will already return in error if the method does not
> exist. Checking if the method is absent before the acpi_evaluate_object()
> call is not needed. Remove acpi_has_method() calls to avoid additional
> work.
>
> Signed-off-by: Kelsey Skunberg <skunberg.kelsey@gmail.com>
LGTM:
Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
> drivers/thermal/intel/int340x_thermal/acpi_thermal_rel.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/thermal/intel/int340x_thermal/acpi_thermal_rel.c b/drivers/thermal/intel/int340x_thermal/acpi_thermal_rel.c
> index 9716bc3abaf9..7130e90773ed 100644
> --- a/drivers/thermal/intel/int340x_thermal/acpi_thermal_rel.c
> +++ b/drivers/thermal/intel/int340x_thermal/acpi_thermal_rel.c
> @@ -77,9 +77,6 @@ int acpi_parse_trt(acpi_handle handle, int *trt_count, struct trt **trtp,
> struct acpi_buffer element = { 0, NULL };
> struct acpi_buffer trt_format = { sizeof("RRNNNNNN"), "RRNNNNNN" };
>
> - if (!acpi_has_method(handle, "_TRT"))
> - return -ENODEV;
> -
> status = acpi_evaluate_object(handle, "_TRT", NULL, &buffer);
> if (ACPI_FAILURE(status))
> return -ENODEV;
> @@ -158,9 +155,6 @@ int acpi_parse_art(acpi_handle handle, int *art_count, struct art **artp,
> struct acpi_buffer art_format = {
> sizeof("RRNNNNNNNNNNN"), "RRNNNNNNNNNNN" };
>
> - if (!acpi_has_method(handle, "_ART"))
> - return -ENODEV;
> -
> status = acpi_evaluate_object(handle, "_ART", NULL, &buffer);
> if (ACPI_FAILURE(status))
> return -ENODEV;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-07-18 8:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-17 19:26 [PATCH] thermal: intel: int340x_thermal: Remove unnecessary acpi_has_method() uses Kelsey Skunberg
2019-07-18 8:36 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).