* [PATCH -next] drm/ttm: remove set but not used variable 'vgdev'
@ 2019-03-20 2:03 YueHaibing
2019-03-25 9:02 ` Daniel Vetter
2019-03-25 9:26 ` [PATCH v2 -next] drm/virtio: " YueHaibing
0 siblings, 2 replies; 6+ messages in thread
From: YueHaibing @ 2019-03-20 2:03 UTC (permalink / raw)
To: David Airlie, Gerd Hoffmann, Daniel Vetter
Cc: YueHaibing, dri-devel, virtualization, linux-kernel, kernel-janitors
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/gpu/drm/virtio/virtgpu_ttm.c: In function 'virtio_gpu_init_mem_type':
drivers/gpu/drm/virtio/virtgpu_ttm.c:117:28: warning:
variable 'vgdev' set but not used [-Wunused-but-set-variable]
drivers/gpu/drm/virtio/virtgpu_ttm.c: In function 'virtio_gpu_bo_swap_notify':
drivers/gpu/drm/virtio/virtgpu_ttm.c:300:28: warning:
variable 'vgdev' set but not used [-Wunused-but-set-variable]
It is never used since introduction in dc5698e80cf7 ("Add virtio gpu driver.")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/gpu/drm/virtio/virtgpu_ttm.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/gpu/drm/virtio/virtgpu_ttm.c b/drivers/gpu/drm/virtio/virtgpu_ttm.c
index d6225ba20b30..eb007c2569d8 100644
--- a/drivers/gpu/drm/virtio/virtgpu_ttm.c
+++ b/drivers/gpu/drm/virtio/virtgpu_ttm.c
@@ -114,10 +114,6 @@ static const struct ttm_mem_type_manager_func virtio_gpu_bo_manager_func = {
static int virtio_gpu_init_mem_type(struct ttm_bo_device *bdev, uint32_t type,
struct ttm_mem_type_manager *man)
{
- struct virtio_gpu_device *vgdev;
-
- vgdev = virtio_gpu_get_vgdev(bdev);
-
switch (type) {
case TTM_PL_SYSTEM:
/* System memory */
@@ -297,10 +293,8 @@ static void virtio_gpu_bo_move_notify(struct ttm_buffer_object *tbo,
static void virtio_gpu_bo_swap_notify(struct ttm_buffer_object *tbo)
{
struct virtio_gpu_object *bo;
- struct virtio_gpu_device *vgdev;
bo = container_of(tbo, struct virtio_gpu_object, tbo);
- vgdev = (struct virtio_gpu_device *)bo->gem_base.dev->dev_private;
if (bo->pages)
virtio_gpu_object_free_sg_table(bo);
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH -next] drm/ttm: remove set but not used variable 'vgdev'
2019-03-20 2:03 [PATCH -next] drm/ttm: remove set but not used variable 'vgdev' YueHaibing
@ 2019-03-25 9:02 ` Daniel Vetter
2019-03-25 9:11 ` YueHaibing
2019-03-25 9:26 ` [PATCH v2 -next] drm/virtio: " YueHaibing
1 sibling, 1 reply; 6+ messages in thread
From: Daniel Vetter @ 2019-03-25 9:02 UTC (permalink / raw)
To: YueHaibing
Cc: David Airlie, Gerd Hoffmann, Daniel Vetter, dri-devel,
virtualization, linux-kernel, kernel-janitors
On Wed, Mar 20, 2019 at 02:03:08AM +0000, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/virtio/virtgpu_ttm.c: In function 'virtio_gpu_init_mem_type':
> drivers/gpu/drm/virtio/virtgpu_ttm.c:117:28: warning:
> variable 'vgdev' set but not used [-Wunused-but-set-variable]
>
> drivers/gpu/drm/virtio/virtgpu_ttm.c: In function 'virtio_gpu_bo_swap_notify':
> drivers/gpu/drm/virtio/virtgpu_ttm.c:300:28: warning:
> variable 'vgdev' set but not used [-Wunused-but-set-variable]
>
> It is never used since introduction in dc5698e80cf7 ("Add virtio gpu driver.")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Subject prefix should be drm/virtio: which is maybe the reason Gerd hasn't
spotted this yet.
-Daniel
> ---
> drivers/gpu/drm/virtio/virtgpu_ttm.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/virtio/virtgpu_ttm.c b/drivers/gpu/drm/virtio/virtgpu_ttm.c
> index d6225ba20b30..eb007c2569d8 100644
> --- a/drivers/gpu/drm/virtio/virtgpu_ttm.c
> +++ b/drivers/gpu/drm/virtio/virtgpu_ttm.c
> @@ -114,10 +114,6 @@ static const struct ttm_mem_type_manager_func virtio_gpu_bo_manager_func = {
> static int virtio_gpu_init_mem_type(struct ttm_bo_device *bdev, uint32_t type,
> struct ttm_mem_type_manager *man)
> {
> - struct virtio_gpu_device *vgdev;
> -
> - vgdev = virtio_gpu_get_vgdev(bdev);
> -
> switch (type) {
> case TTM_PL_SYSTEM:
> /* System memory */
> @@ -297,10 +293,8 @@ static void virtio_gpu_bo_move_notify(struct ttm_buffer_object *tbo,
> static void virtio_gpu_bo_swap_notify(struct ttm_buffer_object *tbo)
> {
> struct virtio_gpu_object *bo;
> - struct virtio_gpu_device *vgdev;
>
> bo = container_of(tbo, struct virtio_gpu_object, tbo);
> - vgdev = (struct virtio_gpu_device *)bo->gem_base.dev->dev_private;
>
> if (bo->pages)
> virtio_gpu_object_free_sg_table(bo);
>
>
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH -next] drm/ttm: remove set but not used variable 'vgdev'
2019-03-25 9:02 ` Daniel Vetter
@ 2019-03-25 9:11 ` YueHaibing
0 siblings, 0 replies; 6+ messages in thread
From: YueHaibing @ 2019-03-25 9:11 UTC (permalink / raw)
To: David Airlie, Gerd Hoffmann, dri-devel, virtualization,
linux-kernel, kernel-janitors
On 2019/3/25 17:02, Daniel Vetter wrote:
> On Wed, Mar 20, 2019 at 02:03:08AM +0000, YueHaibing wrote:
>> Fixes gcc '-Wunused-but-set-variable' warning:
>>
>> drivers/gpu/drm/virtio/virtgpu_ttm.c: In function 'virtio_gpu_init_mem_type':
>> drivers/gpu/drm/virtio/virtgpu_ttm.c:117:28: warning:
>> variable 'vgdev' set but not used [-Wunused-but-set-variable]
>>
>> drivers/gpu/drm/virtio/virtgpu_ttm.c: In function 'virtio_gpu_bo_swap_notify':
>> drivers/gpu/drm/virtio/virtgpu_ttm.c:300:28: warning:
>> variable 'vgdev' set but not used [-Wunused-but-set-variable]
>>
>> It is never used since introduction in dc5698e80cf7 ("Add virtio gpu driver.")
>>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>
> Subject prefix should be drm/virtio: which is maybe the reason Gerd hasn't
> spotted this yet.
Thanks, will fix it.
> -Daniel
>
>> ---
>> drivers/gpu/drm/virtio/virtgpu_ttm.c | 6 ------
>> 1 file changed, 6 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/virtio/virtgpu_ttm.c b/drivers/gpu/drm/virtio/virtgpu_ttm.c
>> index d6225ba20b30..eb007c2569d8 100644
>> --- a/drivers/gpu/drm/virtio/virtgpu_ttm.c
>> +++ b/drivers/gpu/drm/virtio/virtgpu_ttm.c
>> @@ -114,10 +114,6 @@ static const struct ttm_mem_type_manager_func virtio_gpu_bo_manager_func = {
>> static int virtio_gpu_init_mem_type(struct ttm_bo_device *bdev, uint32_t type,
>> struct ttm_mem_type_manager *man)
>> {
>> - struct virtio_gpu_device *vgdev;
>> -
>> - vgdev = virtio_gpu_get_vgdev(bdev);
>> -
>> switch (type) {
>> case TTM_PL_SYSTEM:
>> /* System memory */
>> @@ -297,10 +293,8 @@ static void virtio_gpu_bo_move_notify(struct ttm_buffer_object *tbo,
>> static void virtio_gpu_bo_swap_notify(struct ttm_buffer_object *tbo)
>> {
>> struct virtio_gpu_object *bo;
>> - struct virtio_gpu_device *vgdev;
>>
>> bo = container_of(tbo, struct virtio_gpu_object, tbo);
>> - vgdev = (struct virtio_gpu_device *)bo->gem_base.dev->dev_private;
>>
>> if (bo->pages)
>> virtio_gpu_object_free_sg_table(bo);
>>
>>
>>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2 -next] drm/virtio: remove set but not used variable 'vgdev'
2019-03-20 2:03 [PATCH -next] drm/ttm: remove set but not used variable 'vgdev' YueHaibing
2019-03-25 9:02 ` Daniel Vetter
@ 2019-03-25 9:26 ` YueHaibing
2019-03-27 14:47 ` Mukesh Ojha
2019-03-28 10:32 ` Gerd Hoffmann
1 sibling, 2 replies; 6+ messages in thread
From: YueHaibing @ 2019-03-25 9:26 UTC (permalink / raw)
To: David Airlie, Gerd Hoffmann, Daniel Vetter
Cc: YueHaibing, dri-devel, virtualization, linux-kernel, kernel-janitors
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/gpu/drm/virtio/virtgpu_ttm.c: In function 'virtio_gpu_init_mem_type':
drivers/gpu/drm/virtio/virtgpu_ttm.c:117:28: warning:
variable 'vgdev' set but not used [-Wunused-but-set-variable]
drivers/gpu/drm/virtio/virtgpu_ttm.c: In function 'virtio_gpu_bo_swap_notify':
drivers/gpu/drm/virtio/virtgpu_ttm.c:300:28: warning:
variable 'vgdev' set but not used [-Wunused-but-set-variable]
It is never used since introduction in dc5698e80cf7 ("Add virtio gpu driver.")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
v2: fix patch prefix
---
drivers/gpu/drm/virtio/virtgpu_ttm.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/gpu/drm/virtio/virtgpu_ttm.c b/drivers/gpu/drm/virtio/virtgpu_ttm.c
index d6225ba20b30..eb007c2569d8 100644
--- a/drivers/gpu/drm/virtio/virtgpu_ttm.c
+++ b/drivers/gpu/drm/virtio/virtgpu_ttm.c
@@ -114,10 +114,6 @@ static const struct ttm_mem_type_manager_func virtio_gpu_bo_manager_func = {
static int virtio_gpu_init_mem_type(struct ttm_bo_device *bdev, uint32_t type,
struct ttm_mem_type_manager *man)
{
- struct virtio_gpu_device *vgdev;
-
- vgdev = virtio_gpu_get_vgdev(bdev);
-
switch (type) {
case TTM_PL_SYSTEM:
/* System memory */
@@ -297,10 +293,8 @@ static void virtio_gpu_bo_move_notify(struct ttm_buffer_object *tbo,
static void virtio_gpu_bo_swap_notify(struct ttm_buffer_object *tbo)
{
struct virtio_gpu_object *bo;
- struct virtio_gpu_device *vgdev;
bo = container_of(tbo, struct virtio_gpu_object, tbo);
- vgdev = (struct virtio_gpu_device *)bo->gem_base.dev->dev_private;
if (bo->pages)
virtio_gpu_object_free_sg_table(bo);
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v2 -next] drm/virtio: remove set but not used variable 'vgdev'
2019-03-25 9:26 ` [PATCH v2 -next] drm/virtio: " YueHaibing
@ 2019-03-27 14:47 ` Mukesh Ojha
2019-03-28 10:32 ` Gerd Hoffmann
1 sibling, 0 replies; 6+ messages in thread
From: Mukesh Ojha @ 2019-03-27 14:47 UTC (permalink / raw)
To: YueHaibing, David Airlie, Gerd Hoffmann, Daniel Vetter
Cc: dri-devel, virtualization, linux-kernel, kernel-janitors
On 3/25/2019 2:56 PM, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/virtio/virtgpu_ttm.c: In function 'virtio_gpu_init_mem_type':
> drivers/gpu/drm/virtio/virtgpu_ttm.c:117:28: warning:
> variable 'vgdev' set but not used [-Wunused-but-set-variable]
>
> drivers/gpu/drm/virtio/virtgpu_ttm.c: In function 'virtio_gpu_bo_swap_notify':
> drivers/gpu/drm/virtio/virtgpu_ttm.c:300:28: warning:
> variable 'vgdev' set but not used [-Wunused-but-set-variable]
>
> It is never used since introduction in dc5698e80cf7 ("Add virtio gpu driver.")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
-Mukesh
> ---
> v2: fix patch prefix
> ---
> drivers/gpu/drm/virtio/virtgpu_ttm.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/virtio/virtgpu_ttm.c b/drivers/gpu/drm/virtio/virtgpu_ttm.c
> index d6225ba20b30..eb007c2569d8 100644
> --- a/drivers/gpu/drm/virtio/virtgpu_ttm.c
> +++ b/drivers/gpu/drm/virtio/virtgpu_ttm.c
> @@ -114,10 +114,6 @@ static const struct ttm_mem_type_manager_func virtio_gpu_bo_manager_func = {
> static int virtio_gpu_init_mem_type(struct ttm_bo_device *bdev, uint32_t type,
> struct ttm_mem_type_manager *man)
> {
> - struct virtio_gpu_device *vgdev;
> -
> - vgdev = virtio_gpu_get_vgdev(bdev);
> -
> switch (type) {
> case TTM_PL_SYSTEM:
> /* System memory */
> @@ -297,10 +293,8 @@ static void virtio_gpu_bo_move_notify(struct ttm_buffer_object *tbo,
> static void virtio_gpu_bo_swap_notify(struct ttm_buffer_object *tbo)
> {
> struct virtio_gpu_object *bo;
> - struct virtio_gpu_device *vgdev;
>
> bo = container_of(tbo, struct virtio_gpu_object, tbo);
> - vgdev = (struct virtio_gpu_device *)bo->gem_base.dev->dev_private;
>
> if (bo->pages)
> virtio_gpu_object_free_sg_table(bo);
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2 -next] drm/virtio: remove set but not used variable 'vgdev'
2019-03-25 9:26 ` [PATCH v2 -next] drm/virtio: " YueHaibing
2019-03-27 14:47 ` Mukesh Ojha
@ 2019-03-28 10:32 ` Gerd Hoffmann
1 sibling, 0 replies; 6+ messages in thread
From: Gerd Hoffmann @ 2019-03-28 10:32 UTC (permalink / raw)
To: YueHaibing
Cc: David Airlie, Daniel Vetter, dri-devel, virtualization,
linux-kernel, kernel-janitors
On Mon, Mar 25, 2019 at 09:26:31AM +0000, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/virtio/virtgpu_ttm.c: In function 'virtio_gpu_init_mem_type':
> drivers/gpu/drm/virtio/virtgpu_ttm.c:117:28: warning:
> variable 'vgdev' set but not used [-Wunused-but-set-variable]
>
> drivers/gpu/drm/virtio/virtgpu_ttm.c: In function 'virtio_gpu_bo_swap_notify':
> drivers/gpu/drm/virtio/virtgpu_ttm.c:300:28: warning:
> variable 'vgdev' set but not used [-Wunused-but-set-variable]
>
> It is never used since introduction in dc5698e80cf7 ("Add virtio gpu driver.")
Patch queued up.
thanks,
Gerd
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-03-28 10:32 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-20 2:03 [PATCH -next] drm/ttm: remove set but not used variable 'vgdev' YueHaibing
2019-03-25 9:02 ` Daniel Vetter
2019-03-25 9:11 ` YueHaibing
2019-03-25 9:26 ` [PATCH v2 -next] drm/virtio: " YueHaibing
2019-03-27 14:47 ` Mukesh Ojha
2019-03-28 10:32 ` Gerd Hoffmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).